[PATCH] drm/amdkfd: CRIU fix extra whitespace and block comment warnings

[PATCH] drm/amdkfd: CRIU fix extra whitespace and block comment warnings

[Rajneesh Bhardwaj]

Fix checkpatch reported warning for a quoted line and block line
comments.

Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 783826640da9..b71d47afd243 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -3514,7 +3514,7 @@ int kfd_criu_resume_svm(struct kfd_process *p)
 			 i, criu_svm_md->data.start_addr, criu_svm_md->data.size);
 
 		for (j = 0; j < num_attrs; j++) {
-			pr_debug("\ncriu_svm_md[%d]->attrs[%d].type : 0x%x \ncriu_svm_md[%d]->attrs[%d].value : 0x%x\n",
+			pr_debug("\ncriu_svm_md[%d]->attrs[%d].type : 0x%x\ncriu_svm_md[%d]->attrs[%d].value : 0x%x\n",
 				 i, j, criu_svm_md->data.attrs[j].type,
 				 i, j, criu_svm_md->data.attrs[j].value);
 			switch (criu_svm_md->data.attrs[j].type) {
@@ -3601,7 +3601,8 @@ int kfd_criu_restore_svm(struct kfd_process *p,
 	num_devices = p->n_pdds;
 	/* Handle one SVM range object at a time, also the number of gpus are
 	 * assumed to be same on the restore node, checking must be done while
-	 * evaluating the topology earlier */
+	 * evaluating the topology earlier
+	 */
 
 	svm_attrs_size = sizeof(struct kfd_ioctl_svm_attribute) *
 		(nattr_common + nattr_accessibility * num_devices);
-- 
2.17.1

[PATCH] drm/amdkfd: Fix prototype warning for get_process_num_bos

[Rajneesh Bhardwaj]

Fix the warning: no previous prototype for 'get_process_num_bos'
[-Wmissing-prototypes]

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index d5699aa79578..54d997f304b5 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -1648,7 +1648,7 @@ static int criu_checkpoint_devices(struct kfd_process *p,
 	return ret;
 }
 
-uint32_t get_process_num_bos(struct kfd_process *p)
+static uint32_t get_process_num_bos(struct kfd_process *p)
 {
 	uint32_t num_of_bos = 0;
 	int i;
-- 
2.17.1

Re: [PATCH] drm/amdkfd: Fix prototype warning for get_process_num_bos

[Felix Kuehling]

Am 2022-02-10 um 23:30 schrieb Rajneesh Bhardwaj:
> Fix the warning: no previous prototype for 'get_process_num_bos'
> [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>

The series is

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index d5699aa79578..54d997f304b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1648,7 +1648,7 @@ static int criu_checkpoint_devices(struct kfd_process *p,
>   	return ret;
>   }
>   
> -uint32_t get_process_num_bos(struct kfd_process *p)
> +static uint32_t get_process_num_bos(struct kfd_process *p)
>   {
>   	uint32_t num_of_bos = 0;
>   	int i;