[Qemu-devel] [PATCH] nbd/client.c: Correct trace format string

[Qemu-devel] [PATCH] nbd/client.c: Correct trace format string

[Peter Maydell]

The trace format string in nbd_send_request uses PRIu16 for
request->type, but request->type is a uint32_t. This provokes
compiler warnings on the OSX clang. Use PRIu32 instead.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I didn't catch this when I ran the merge build test for the
pull request, because I don't have warnings-as-errors enabled
on the OSX test machine yet.

 nbd/client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nbd/client.c b/nbd/client.c
index 287487c..78a7195 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -711,7 +711,7 @@ ssize_t nbd_send_request(QIOChannel *ioc, struct nbd_request *request)
 
     TRACE("Sending request to server: "
           "{ .from = %" PRIu64", .len = %" PRIu32 ", .handle = %" PRIu64
-          ", .type=%" PRIu16 " }",
+          ", .type=%" PRIu32 " }",
           request->from, request->len, request->handle, request->type);
 
     stl_be_p(buf, NBD_REQUEST_MAGIC);
-- 
1.9.1

Re: [Qemu-devel] [PATCH] nbd/client.c: Correct trace format string

[Paolo Bonzini]

On 17/06/2016 14:42, Peter Maydell wrote:
> The trace format string in nbd_send_request uses PRIu16 for
> request->type, but request->type is a uint32_t. This provokes
> compiler warnings on the OSX clang. Use PRIu32 instead.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I didn't catch this when I ran the merge build test for the
> pull request, because I don't have warnings-as-errors enabled
> on the OSX test machine yet.

Thanks, please apply directly if you wish.

Paolo

Re: [Qemu-devel] [PATCH] nbd/client.c: Correct trace format string

[Peter Maydell]

On 17 June 2016 at 14:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 17/06/2016 14:42, Peter Maydell wrote:
>> The trace format string in nbd_send_request uses PRIu16 for
>> request->type, but request->type is a uint32_t. This provokes
>> compiler warnings on the OSX clang. Use PRIu32 instead.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I didn't catch this when I ran the merge build test for the
>> pull request, because I don't have warnings-as-errors enabled
>> on the OSX test machine yet.
>
> Thanks, please apply directly if you wish.

thanks, applied to master

-- PMM