From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-riscv@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"David Hildenbrand" <david@redhat.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 01/14] Makefile: Only build virtiofsd if system-mode is enabled
Date: Fri, 13 Mar 2020 23:28:08 +0100 [thread overview]
Message-ID: <8f73d608-d28e-b896-b1f0-f95d599502f0@vivier.eu> (raw)
In-Reply-To: <20200313183652.10258-2-philmd@redhat.com>
Le 13/03/2020 à 19:36, Philippe Mathieu-Daudé a écrit :
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 7df22fcc5d..ed77b6e50b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -346,8 +346,8 @@ vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
>
> ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
> -HELPERS-y += virtiofsd$(EXESUF)
> -vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
> +HELPERS-$(CONFIG_SOFTMMU) += virtiofsd$(EXESUF)
> +vhost-user-json-$(CONFIG_SOFTMMU) += tools/virtiofsd/50-qemu-virtiofsd.json
> endif
>
> # Sphinx does not allow building manuals into the same directory as
>
Why don't you do that instead?
ifeq
($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG)$(CONFIG_SOFTMMU),yyyy)
Thanks,
Laurent
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
qemu-ppc@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-s390x@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Richard Henderson" <rth@twiddle.net>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-riscv@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
qemu-arm@nongnu.org,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 01/14] Makefile: Only build virtiofsd if system-mode is enabled
Date: Fri, 13 Mar 2020 23:28:08 +0100 [thread overview]
Message-ID: <8f73d608-d28e-b896-b1f0-f95d599502f0@vivier.eu> (raw)
In-Reply-To: <20200313183652.10258-2-philmd@redhat.com>
Le 13/03/2020 à 19:36, Philippe Mathieu-Daudé a écrit :
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 7df22fcc5d..ed77b6e50b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -346,8 +346,8 @@ vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
>
> ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
> -HELPERS-y += virtiofsd$(EXESUF)
> -vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
> +HELPERS-$(CONFIG_SOFTMMU) += virtiofsd$(EXESUF)
> +vhost-user-json-$(CONFIG_SOFTMMU) += tools/virtiofsd/50-qemu-virtiofsd.json
> endif
>
> # Sphinx does not allow building manuals into the same directory as
>
Why don't you do that instead?
ifeq
($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG)$(CONFIG_SOFTMMU),yyyy)
Thanks,
Laurent
next prev parent reply other threads:[~2020-03-13 22:29 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 18:36 [PATCH 00/14] user-mode: Prune build dependencies (part 1) Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 18:36 ` [PATCH 01/14] Makefile: Only build virtiofsd if system-mode is enabled Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 22:28 ` Laurent Vivier [this message]
2020-03-13 22:28 ` Laurent Vivier
2020-03-15 19:40 ` Richard Henderson
2020-03-15 19:40 ` Richard Henderson
2020-03-15 22:16 ` Philippe Mathieu-Daudé
2020-03-15 22:16 ` Philippe Mathieu-Daudé
2020-03-15 22:33 ` Richard Henderson
2020-03-15 22:33 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 02/14] configure: Avoid building TCG when not needed Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 18:56 ` Richard Henderson
2020-03-15 18:56 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 03/14] tests/Makefile: Only display TCG-related tests when TCG is available Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 19:45 ` Alistair Francis
2020-03-13 19:45 ` Alistair Francis
2020-03-15 18:57 ` Richard Henderson
2020-03-15 18:57 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 04/14] tests/Makefile: Restrict some softmmu-only tests Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:07 ` Richard Henderson
2020-03-15 20:07 ` Richard Henderson
2020-03-15 20:17 ` Richard Henderson
2020-03-15 20:17 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 05/14] stubs/Makefile: Reduce the user-mode object list Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:17 ` Richard Henderson
2020-03-15 20:17 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 06/14] util/Makefile: " Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:18 ` Richard Henderson
2020-03-15 20:18 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 07/14] target/riscv/cpu: Restrict CPU migration to system-mode Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 20:01 ` Alistair Francis
2020-03-13 20:01 ` Alistair Francis
2020-03-15 20:18 ` Richard Henderson
2020-03-15 20:18 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 08/14] exec: Assert CPU migration is not used on user-only build Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:19 ` Richard Henderson
2020-03-15 20:19 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 09/14] exec: Drop redundant #ifdeffery Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 20:02 ` Alistair Francis
2020-03-13 20:02 ` Alistair Francis
2020-03-15 20:39 ` Richard Henderson
2020-03-15 20:39 ` Richard Henderson
2020-03-15 22:20 ` Philippe Mathieu-Daudé
2020-03-15 22:20 ` Philippe Mathieu-Daudé
2020-03-13 18:36 ` [PATCH 10/14] arch_init: Remove unused 'qapi-commands-misc.h' include Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-13 20:02 ` Alistair Francis
2020-03-13 20:02 ` Alistair Francis
2020-03-15 20:41 ` Richard Henderson
2020-03-15 20:41 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 11/14] target: Restrict write_elfXX_note() handlers to system-mode Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:44 ` Richard Henderson
2020-03-15 20:44 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 12/14] target/i386: Restrict CpuClass::get_crash_info() " Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:46 ` Richard Henderson
2020-03-15 20:46 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 13/14] target/s390x: " Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 20:46 ` Richard Henderson
2020-03-15 20:46 ` Richard Henderson
2020-03-13 18:36 ` [PATCH 14/14] hw/core: " Philippe Mathieu-Daudé
2020-03-13 18:36 ` Philippe Mathieu-Daudé
2020-03-15 21:03 ` Richard Henderson
2020-03-15 21:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f73d608-d28e-b896-b1f0-f95d599502f0@vivier.eu \
--to=laurent@vivier.eu \
--cc=Alistair.Francis@wdc.com \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.