* [PATCH] qcow2: Remove unused fields from BDRVQcow2State
@ 2020-03-26 17:07 Kevin Wolf
2020-03-26 17:11 ` Eric Blake
2020-03-26 18:36 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2020-03-26 17:07 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel, mreitz
These fields were already removed in commit c3c10f72, but then commit
b58deb34 revived them probably due to bad merge conflict resolution.
They are still unused, so remove them again.
Fixes: b58deb344ddff3b9d8b265bf73a65274767ee5f4
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 0942126232..f4de0a27d5 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -301,9 +301,6 @@ typedef struct BDRVQcow2State {
QEMUTimer *cache_clean_timer;
unsigned cache_clean_interval;
- uint8_t *cluster_cache;
- uint8_t *cluster_data;
- uint64_t cluster_cache_offset;
QLIST_HEAD(, QCowL2Meta) cluster_allocs;
uint64_t *refcount_table;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qcow2: Remove unused fields from BDRVQcow2State
2020-03-26 17:07 [PATCH] qcow2: Remove unused fields from BDRVQcow2State Kevin Wolf
@ 2020-03-26 17:11 ` Eric Blake
2020-03-26 18:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2020-03-26 17:11 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel, mreitz
On 3/26/20 12:07 PM, Kevin Wolf wrote:
> These fields were already removed in commit c3c10f72, but then commit
> b58deb34 revived them probably due to bad merge conflict resolution.
> They are still unused, so remove them again.
>
> Fixes: b58deb344ddff3b9d8b265bf73a65274767ee5f4
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.h | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0942126232..f4de0a27d5 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -301,9 +301,6 @@ typedef struct BDRVQcow2State {
> QEMUTimer *cache_clean_timer;
> unsigned cache_clean_interval;
>
> - uint8_t *cluster_cache;
> - uint8_t *cluster_data;
> - uint64_t cluster_cache_offset;
> QLIST_HEAD(, QCowL2Meta) cluster_allocs;
>
> uint64_t *refcount_table;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qcow2: Remove unused fields from BDRVQcow2State
2020-03-26 17:07 [PATCH] qcow2: Remove unused fields from BDRVQcow2State Kevin Wolf
2020-03-26 17:11 ` Eric Blake
@ 2020-03-26 18:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-26 18:36 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel, mreitz
On 3/26/20 6:07 PM, Kevin Wolf wrote:
> These fields were already removed in commit c3c10f72, but then commit
> b58deb34 revived them probably due to bad merge conflict resolution.
> They are still unused, so remove them again.
>
> Fixes: b58deb344ddff3b9d8b265bf73a65274767ee5f4
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0942126232..f4de0a27d5 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -301,9 +301,6 @@ typedef struct BDRVQcow2State {
> QEMUTimer *cache_clean_timer;
> unsigned cache_clean_interval;
>
> - uint8_t *cluster_cache;
> - uint8_t *cluster_data;
> - uint64_t cluster_cache_offset;
> QLIST_HEAD(, QCowL2Meta) cluster_allocs;
>
> uint64_t *refcount_table;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 17:07 [PATCH] qcow2: Remove unused fields from BDRVQcow2State Kevin Wolf
2020-03-26 17:11 ` Eric Blake
2020-03-26 18:36 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.