From: Haren Myneni <haren@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, mpe@ellerman.id.au, herbert@gondor.apana.org.au, npiggin@gmail.com Cc: hbabu@us.ibm.com, haren@us.ibm.com Subject: [PATCH v5 17/17] crypto/nx: Add sysfs interface to export NX capabilities Date: Sun, 13 Jun 2021 04:05:58 -0700 [thread overview] Message-ID: <8fd529d8612ea47cce69101b62e9498de9324850.camel@linux.ibm.com> (raw) In-Reply-To: <ed7a09822cf3a2e463f942e5a37309a2365c9d79.camel@linux.ibm.com> Changes to export the following NXGZIP capabilities through sysfs: /sys/devices/vio/ibm,compression-v1/nx_gzip_caps: min_compress_len /*Recommended minimum compress length in bytes*/ min_decompress_len /*Recommended minimum decompress length in bytes*/ req_max_processed_len /* Maximum number of bytes processed in one request */ NX will return RMA_Reject if the request buffer size is greater than req_max_processed_len. Signed-off-by: Haren Myneni <haren@linux.ibm.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> --- drivers/crypto/nx/nx-common-pseries.c | 43 +++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c index 60b5049ec9f7..db28a84a826c 100644 --- a/drivers/crypto/nx/nx-common-pseries.c +++ b/drivers/crypto/nx/nx-common-pseries.c @@ -967,6 +967,36 @@ static struct attribute_group nx842_attribute_group = { .attrs = nx842_sysfs_entries, }; +#define nxct_caps_read(_name) \ +static ssize_t nxct_##_name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ +{ \ + return sprintf(buf, "%lld\n", nx_ct_caps._name); \ +} + +#define NXCT_ATTR_RO(_name) \ + nxct_caps_read(_name); \ + static struct device_attribute dev_attr_##_name = __ATTR(_name, \ + 0444, \ + nxct_##_name##_show, \ + NULL); + +NXCT_ATTR_RO(req_max_processed_len); +NXCT_ATTR_RO(min_compress_len); +NXCT_ATTR_RO(min_decompress_len); + +static struct attribute *nxct_caps_sysfs_entries[] = { + &dev_attr_req_max_processed_len.attr, + &dev_attr_min_compress_len.attr, + &dev_attr_min_decompress_len.attr, + NULL, +}; + +static struct attribute_group nxct_caps_attr_group = { + .name = "nx_gzip_caps", + .attrs = nxct_caps_sysfs_entries, +}; + static struct nx842_driver nx842_pseries_driver = { .name = KBUILD_MODNAME, .owner = THIS_MODULE, @@ -1056,6 +1086,16 @@ static int nx842_probe(struct vio_dev *viodev, goto error; } + if (caps_feat) { + if (sysfs_create_group(&viodev->dev.kobj, + &nxct_caps_attr_group)) { + dev_err(&viodev->dev, + "Could not create sysfs NX capability entries\n"); + ret = -1; + goto error; + } + } + return 0; error_unlock: @@ -1075,6 +1115,9 @@ static void nx842_remove(struct vio_dev *viodev) pr_info("Removing IBM Power 842 compression device\n"); sysfs_remove_group(&viodev->dev.kobj, &nx842_attribute_group); + if (caps_feat) + sysfs_remove_group(&viodev->dev.kobj, &nxct_caps_attr_group); + crypto_unregister_alg(&nx842_pseries_alg); spin_lock_irqsave(&devdata_mutex, flags); -- 2.18.2
WARNING: multiple messages have this Message-ID (diff)
From: Haren Myneni <haren@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, mpe@ellerman.id.au, herbert@gondor.apana.org.au, npiggin@gmail.com Subject: [PATCH v5 17/17] crypto/nx: Add sysfs interface to export NX capabilities Date: Sun, 13 Jun 2021 04:05:58 -0700 [thread overview] Message-ID: <8fd529d8612ea47cce69101b62e9498de9324850.camel@linux.ibm.com> (raw) In-Reply-To: <ed7a09822cf3a2e463f942e5a37309a2365c9d79.camel@linux.ibm.com> Changes to export the following NXGZIP capabilities through sysfs: /sys/devices/vio/ibm,compression-v1/nx_gzip_caps: min_compress_len /*Recommended minimum compress length in bytes*/ min_decompress_len /*Recommended minimum decompress length in bytes*/ req_max_processed_len /* Maximum number of bytes processed in one request */ NX will return RMA_Reject if the request buffer size is greater than req_max_processed_len. Signed-off-by: Haren Myneni <haren@linux.ibm.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> --- drivers/crypto/nx/nx-common-pseries.c | 43 +++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c index 60b5049ec9f7..db28a84a826c 100644 --- a/drivers/crypto/nx/nx-common-pseries.c +++ b/drivers/crypto/nx/nx-common-pseries.c @@ -967,6 +967,36 @@ static struct attribute_group nx842_attribute_group = { .attrs = nx842_sysfs_entries, }; +#define nxct_caps_read(_name) \ +static ssize_t nxct_##_name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ +{ \ + return sprintf(buf, "%lld\n", nx_ct_caps._name); \ +} + +#define NXCT_ATTR_RO(_name) \ + nxct_caps_read(_name); \ + static struct device_attribute dev_attr_##_name = __ATTR(_name, \ + 0444, \ + nxct_##_name##_show, \ + NULL); + +NXCT_ATTR_RO(req_max_processed_len); +NXCT_ATTR_RO(min_compress_len); +NXCT_ATTR_RO(min_decompress_len); + +static struct attribute *nxct_caps_sysfs_entries[] = { + &dev_attr_req_max_processed_len.attr, + &dev_attr_min_compress_len.attr, + &dev_attr_min_decompress_len.attr, + NULL, +}; + +static struct attribute_group nxct_caps_attr_group = { + .name = "nx_gzip_caps", + .attrs = nxct_caps_sysfs_entries, +}; + static struct nx842_driver nx842_pseries_driver = { .name = KBUILD_MODNAME, .owner = THIS_MODULE, @@ -1056,6 +1086,16 @@ static int nx842_probe(struct vio_dev *viodev, goto error; } + if (caps_feat) { + if (sysfs_create_group(&viodev->dev.kobj, + &nxct_caps_attr_group)) { + dev_err(&viodev->dev, + "Could not create sysfs NX capability entries\n"); + ret = -1; + goto error; + } + } + return 0; error_unlock: @@ -1075,6 +1115,9 @@ static void nx842_remove(struct vio_dev *viodev) pr_info("Removing IBM Power 842 compression device\n"); sysfs_remove_group(&viodev->dev.kobj, &nx842_attribute_group); + if (caps_feat) + sysfs_remove_group(&viodev->dev.kobj, &nxct_caps_attr_group); + crypto_unregister_alg(&nx842_pseries_alg); spin_lock_irqsave(&devdata_mutex, flags); -- 2.18.2
next prev parent reply other threads:[~2021-06-13 11:06 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-13 10:53 [PATCH v5 00/17] Enable VAS and NX-GZIP support on PowerVM Haren Myneni 2021-06-13 10:53 ` Haren Myneni 2021-06-13 10:54 ` [PATCH v5 01/17] powerpc/powernv/vas: Release reference to tgid during window close Haren Myneni 2021-06-13 10:54 ` Haren Myneni 2021-06-14 2:11 ` Nicholas Piggin 2021-06-14 2:11 ` Nicholas Piggin 2021-06-13 10:55 ` [PATCH v5 02/17] powerpc/vas: Move VAS API to book3s common platform Haren Myneni 2021-06-13 10:55 ` Haren Myneni 2021-06-14 2:10 ` Nicholas Piggin 2021-06-14 2:10 ` Nicholas Piggin 2021-06-13 10:56 ` [PATCH v5 03/17] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni 2021-06-13 10:56 ` Haren Myneni 2021-06-13 10:57 ` [PATCH v5 04/17] powerpc/vas: Add platform specific user window operations Haren Myneni 2021-06-13 10:57 ` Haren Myneni 2021-06-14 2:24 ` Nicholas Piggin 2021-06-14 2:24 ` Nicholas Piggin 2021-06-15 6:37 ` Haren Myneni 2021-06-15 6:37 ` Haren Myneni 2021-06-16 9:11 ` Nicholas Piggin 2021-06-16 9:11 ` Nicholas Piggin 2021-06-13 10:57 ` [PATCH v5 05/17] powerpc/vas: Create take/drop pid and mm reference functions Haren Myneni 2021-06-13 10:57 ` Haren Myneni 2021-06-14 2:26 ` Nicholas Piggin 2021-06-14 2:26 ` Nicholas Piggin 2021-06-13 10:58 ` [PATCH v5 06/17] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni 2021-06-13 10:58 ` Haren Myneni 2021-06-14 3:34 ` Nicholas Piggin 2021-06-14 3:34 ` Nicholas Piggin 2021-06-13 10:58 ` [PATCH v5 07/17] powerpc/vas: Define and use common vas_window struct Haren Myneni 2021-06-13 10:58 ` Haren Myneni 2021-06-14 2:28 ` Nicholas Piggin 2021-06-14 2:28 ` Nicholas Piggin 2021-06-13 10:59 ` [PATCH v5 08/17] powerpc/pseries/vas: Define VAS/NXGZIP hcalls and structs Haren Myneni 2021-06-13 10:59 ` Haren Myneni 2021-06-14 2:32 ` Nicholas Piggin 2021-06-14 2:32 ` Nicholas Piggin 2021-06-13 11:00 ` [PATCH v5 09/17] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni 2021-06-13 11:00 ` Haren Myneni 2021-06-14 2:32 ` Nicholas Piggin 2021-06-14 2:32 ` Nicholas Piggin 2021-06-13 11:00 ` [PATCH v5 10/17] powerpc/pseries/vas: Add hcall wrappers for VAS handling Haren Myneni 2021-06-13 11:00 ` Haren Myneni 2021-06-13 11:01 ` [PATCH v5 11/17] powerpc/pseries/vas: Implement getting capabilities from hypervisor Haren Myneni 2021-06-13 11:01 ` Haren Myneni 2021-06-14 2:35 ` Nicholas Piggin 2021-06-14 2:35 ` Nicholas Piggin 2021-06-13 11:02 ` [PATCH v5 12/17] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni 2021-06-13 11:02 ` Haren Myneni 2021-06-14 2:55 ` Nicholas Piggin 2021-06-14 2:55 ` Nicholas Piggin 2021-06-15 6:51 ` Haren Myneni 2021-06-15 6:51 ` Haren Myneni 2021-06-15 7:26 ` Haren Myneni 2021-06-15 7:26 ` Haren Myneni 2021-06-16 9:38 ` Nicholas Piggin 2021-06-16 9:38 ` Nicholas Piggin 2021-06-13 11:02 ` [PATCH v5 13/17] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni 2021-06-13 11:02 ` Haren Myneni 2021-06-14 3:07 ` Nicholas Piggin 2021-06-14 3:07 ` Nicholas Piggin 2021-06-15 9:01 ` Haren Myneni 2021-06-15 9:01 ` Haren Myneni 2021-06-16 9:40 ` Nicholas Piggin 2021-06-16 9:40 ` Nicholas Piggin 2021-06-13 11:03 ` [PATCH v5 14/17] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni 2021-06-13 11:03 ` Haren Myneni 2021-06-14 3:07 ` Nicholas Piggin 2021-06-14 3:07 ` Nicholas Piggin 2021-06-13 11:04 ` [PATCH v5 15/17] crypto/nx: Register and unregister VAS interface on PowerVM Haren Myneni 2021-06-13 11:04 ` Haren Myneni 2021-06-14 3:35 ` Nicholas Piggin 2021-06-14 3:35 ` Nicholas Piggin 2021-06-13 11:04 ` [PATCH v5 16/17] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni 2021-06-13 11:04 ` Haren Myneni 2021-06-14 3:39 ` Nicholas Piggin 2021-06-14 3:39 ` Nicholas Piggin 2021-06-15 0:01 ` Haren Myneni 2021-06-15 0:01 ` Haren Myneni 2021-06-13 11:05 ` Haren Myneni [this message] 2021-06-13 11:05 ` [PATCH v5 17/17] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni 2021-06-14 3:46 ` Nicholas Piggin 2021-06-14 3:46 ` Nicholas Piggin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8fd529d8612ea47cce69101b62e9498de9324850.camel@linux.ibm.com \ --to=haren@linux.ibm.com \ --cc=haren@us.ibm.com \ --cc=hbabu@us.ibm.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-crypto@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.