All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale
@ 2016-12-04  9:43 Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 1/3] core: add a kconfig option to require an UTF8 locale on the host Yann E. MORIN
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-12-04  9:43 UTC (permalink / raw)
  To: buildroot

Hello All!

When configured with support for locales, uClibc needs an UTF-8 locale
on the build machine.

This series makes it simpler to require such a locale, by introducing a
blind kconfig option to require an UTF-8 locale.

uClibc is made to select this option when it wants to build locales.

Then, when checking dependencies, we use that option rather than
reconstructign the conditions in the script. This means we no longer
check it for glibc or musl, but tests have shown that this is not
needed.

Changes v1 -> v2;
  - drop the tvheadend patch
  - rework changelogs accordingly

Regards,
Yann E. MORIN.


The following changes since commit 9139822448592b8b388c525f2e7beb0b14fa9bc7

  core: find an UFT8 locale on the host (2016-12-03 16:52:15 +0100)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 8b7030696b25d8b072124ac60530bd98eca8f3f6

  support/dependencies: use the new kconfig option to check UTF8 locale (2016-12-04 10:38:29 +0100)


----------------------------------------------------------------
Yann E. MORIN (3):
      core: add a kconfig option to require an UTF8 locale on the host
      package/uclibc: needs a host with an UTF8 locale to build locales
      support/dependencies: use the new kconfig option to check UTF8 locale

 Config.in                            | 5 +++++
 package/uclibc/Config.in             | 1 +
 support/dependencies/dependencies.sh | 3 +--
 3 files changed, 7 insertions(+), 2 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/3] core: add a kconfig option to require an UTF8 locale on the host
  2016-12-04  9:43 [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale Yann E. MORIN
@ 2016-12-04  9:43 ` Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 2/3] package/uclibc: needs a host with an UTF8 locale to build locales Yann E. MORIN
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-12-04  9:43 UTC (permalink / raw)
  To: buildroot

This can be selected when we need the host to have an UTF-8 locale
(e.g. to build uClibc with support for locales).

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Config.in b/Config.in
index 98096df..495b71c 100644
--- a/Config.in
+++ b/Config.in
@@ -84,6 +84,11 @@ config BR2_HOSTARCH_NEEDS_IA32_LIBS
 config BR2_HOSTARCH_NEEDS_IA32_COMPILER
 	bool
 
+# Hidden boolean selected by packages that need the host to have an
+# UTF8 locale.
+config BR2_NEEDS_HOST_UTF8_LOCALE
+	bool
+
 source "arch/Config.in"
 
 menu "Build options"
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/3] package/uclibc: needs a host with an UTF8 locale to build locales
  2016-12-04  9:43 [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 1/3] core: add a kconfig option to require an UTF8 locale on the host Yann E. MORIN
@ 2016-12-04  9:43 ` Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 3/3] support/dependencies: use the new kconfig option to check UTF8 locale Yann E. MORIN
  2016-12-04 14:38 ` [Buildroot] [PATCH 0/3 v2] support: better check for a host with an " Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-12-04  9:43 UTC (permalink / raw)
  To: buildroot

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/uclibc/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index fdf007e..88b9947 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -41,6 +41,7 @@ config BR2_TOOLCHAIN_BUILDROOT_LOCALE
 	bool "Enable toolchain locale/i18n support"
 	select BR2_TOOLCHAIN_BUILDROOT_WCHAR
 	select BR2_ENABLE_LOCALE
+	select BR2_NEEDS_HOST_UTF8_LOCALE
 	help
 	  Enable this option if you want your toolchain to support
 	  localization and internationalization.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 3/3] support/dependencies: use the new kconfig option to check UTF8 locale
  2016-12-04  9:43 [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 1/3] core: add a kconfig option to require an UTF8 locale on the host Yann E. MORIN
  2016-12-04  9:43 ` [Buildroot] [PATCH 2/3] package/uclibc: needs a host with an UTF8 locale to build locales Yann E. MORIN
@ 2016-12-04  9:43 ` Yann E. MORIN
  2016-12-04 14:38 ` [Buildroot] [PATCH 0/3 v2] support: better check for a host with an " Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-12-04  9:43 UTC (permalink / raw)
  To: buildroot

Currently, we require a host with an UTF-8 locale as soone as we build a
Buildroot toolchain with support for locales. This means that we do
erquire such a locale when building a toolchain with either uClibc,
glibc or musl.

However, glibc and musl do not require such a locale to be present.

Use the new option to check if an UTF8 locale is needed on the host,
rather than deriving that from toolchain settings.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/dependencies/dependencies.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index e632a14..bfd6596 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -178,8 +178,7 @@ if test "${missing_progs}" = "yes" ; then
 	exit 1
 fi
 
-if grep ^BR2_TOOLCHAIN_BUILDROOT=y $BR2_CONFIG > /dev/null && \
-	grep ^BR2_ENABLE_LOCALE=y       $BR2_CONFIG > /dev/null ; then
+if grep ^BR2_NEEDS_HOST_UTF8_LOCALE=y $BR2_CONFIG > /dev/null; then
 	if ! which locale > /dev/null ; then
 		echo
 		echo "You need locale support on your build machine to build a toolchain supporting locales"
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale
  2016-12-04  9:43 [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale Yann E. MORIN
                   ` (2 preceding siblings ...)
  2016-12-04  9:43 ` [Buildroot] [PATCH 3/3] support/dependencies: use the new kconfig option to check UTF8 locale Yann E. MORIN
@ 2016-12-04 14:38 ` Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2016-12-04 14:38 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  4 Dec 2016 10:43:03 +0100, Yann E. MORIN wrote:

> Yann E. MORIN (3):
>       core: add a kconfig option to require an UTF8 locale on the host
>       package/uclibc: needs a host with an UTF8 locale to build locales
>       support/dependencies: use the new kconfig option to check UTF8 locale

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-04 14:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-04  9:43 [Buildroot] [PATCH 0/3 v2] support: better check for a host with an UTF8 locale Yann E. MORIN
2016-12-04  9:43 ` [Buildroot] [PATCH 1/3] core: add a kconfig option to require an UTF8 locale on the host Yann E. MORIN
2016-12-04  9:43 ` [Buildroot] [PATCH 2/3] package/uclibc: needs a host with an UTF8 locale to build locales Yann E. MORIN
2016-12-04  9:43 ` [Buildroot] [PATCH 3/3] support/dependencies: use the new kconfig option to check UTF8 locale Yann E. MORIN
2016-12-04 14:38 ` [Buildroot] [PATCH 0/3 v2] support: better check for a host with an " Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.