From: Sean Anderson <sean.anderson@seco.com>
To: Pratyush Yadav <p.yadav@ti.com>, Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: sf: Set SF parameters as env variables
Date: Thu, 2 Dec 2021 11:41:24 -0500 [thread overview]
Message-ID: <8fe29da5-5017-b222-4eb7-b28dbd061f82@seco.com> (raw)
In-Reply-To: <20211007124010.3aibcajzt4ojwcqr@ti.com>
On 10/7/21 8:40 AM, Pratyush Yadav wrote:
> On 23/09/21 10:00PM, Marek Vasut wrote:
>> On 9/23/21 8:53 PM, Pratyush Yadav wrote:
>> > On 14/09/21 05:28AM, Marek Vasut wrote:
>> > > Set the SF page size, erase block size and total size as an environment
>> > > variable after "sf probe". This lets us discern boards with multiple
>> > > distinct SPI flash options and also e.g. set mtdparts accordingly.
>> >
>> > I don't quite follow the rationale for making these environment
>> > variables. Wouldn't you be better off finding this info out via mtd or
>> > sf command?
>>
>> I need to use that info in a script, that's why these env vars.
>
> Ok. Honestly, it doesn't feel quite right to me.
>
> I haven't played with U-Boot's shell too much but is there no way to
> assign variables from command outputs? For example, can we do something
> like `foo=$(cat a.txt)`? If that is possible, maybe add some new
> subcommands to "sf" that return this information?
>
There is not.
IMO the current solution (exporting to environment variables in an ad-hoc
manner) is rather ugly, but fixing it is difficult :)
--Sean
next prev parent reply other threads:[~2021-12-02 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 3:28 [PATCH] mtd: sf: Set SF parameters as env variables Marek Vasut
2021-09-23 18:53 ` Pratyush Yadav
2021-09-23 20:00 ` Marek Vasut
2021-10-07 12:40 ` Pratyush Yadav
2021-10-07 12:46 ` Marek Vasut
2021-11-28 21:56 ` Marek Vasut
2021-12-02 9:14 ` Pratyush Yadav
2021-12-02 16:41 ` Sean Anderson [this message]
2021-12-02 5:47 ` Jagan Teki
2021-12-02 5:49 ` Marek Vasut
2021-12-02 5:57 ` Jagan Teki
2021-12-02 6:03 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe29da5-5017-b222-4eb7-b28dbd061f82@seco.com \
--to=sean.anderson@seco.com \
--cc=jagan@amarulasolutions.com \
--cc=marex@denx.de \
--cc=p.yadav@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.