* [PATCH] obexd: Fix can't receive small files sent by windows
@ 2022-03-23 5:21 xinpeng wang
2022-03-23 6:47 ` bluez.test.bot
2022-03-23 6:49 ` [PATCH] " Paul Menzel
0 siblings, 2 replies; 4+ messages in thread
From: xinpeng wang @ 2022-03-23 5:21 UTC (permalink / raw)
To: linux-bluetooth; +Cc: xinpeng wang
Windows devices use streaming mode to send files. If a small file is
sent,the first time processing data will be completed successfully,
and the transfer_complete function will be called before the end to
clear os->path.At this time, the dbus signal is still pending, and
the dbus method call requesting the file path has not been processed;
in this way, the upper-level program will not be able to obtain the
file path, resulting in failure to receive the file.
Therefore, the signal of Filename is generated, and it is forced to
be sent when status=active.
Signed-off-by: xinpeng wang <wangxinpeng@uniontech.com>
---
obexd/src/manager.c | 6 +++++-
obexd/src/obex.c | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/obexd/src/manager.c b/obexd/src/manager.c
index 01741fe62..2c180dc44 100644
--- a/obexd/src/manager.c
+++ b/obexd/src/manager.c
@@ -533,8 +533,12 @@ void manager_emit_transfer_property(struct obex_transfer *transfer,
void manager_emit_transfer_started(struct obex_transfer *transfer)
{
transfer->status = TRANSFER_STATUS_ACTIVE;
+ if (!transfer->path)
+ return;
- manager_emit_transfer_property(transfer, "Status");
+ g_dbus_emit_property_changed_full(connection, transfer->path,
+ TRANSFER_INTERFACE, "Status",
+ G_DBUS_PROPERTY_CHANGED_FLAG_FLUSH);
}
static void emit_transfer_completed(struct obex_transfer *transfer,
diff --git a/obexd/src/obex.c b/obexd/src/obex.c
index 3a68fd66c..c0d9e160a 100644
--- a/obexd/src/obex.c
+++ b/obexd/src/obex.c
@@ -720,6 +720,7 @@ int obex_put_stream_start(struct obex_session *os, const char *filename)
manager_emit_transfer_property(os->service_data, "Size");
os->path = g_strdup(filename);
+ manager_emit_transfer_property(os->service_data, "Filename");
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: obexd: Fix can't receive small files sent by windows
2022-03-23 5:21 [PATCH] obexd: Fix can't receive small files sent by windows xinpeng wang
@ 2022-03-23 6:47 ` bluez.test.bot
2022-03-23 6:49 ` [PATCH] " Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-03-23 6:47 UTC (permalink / raw)
To: linux-bluetooth, wangxinpeng
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=625643
---Test result---
Test Summary:
CheckPatch PASS 1.48 seconds
GitLint PASS 0.92 seconds
Prep - Setup ELL PASS 52.57 seconds
Build - Prep PASS 0.81 seconds
Build - Configure PASS 10.33 seconds
Build - Make PASS 1493.17 seconds
Make Check PASS 12.78 seconds
Make Check w/Valgrind PASS 538.63 seconds
Make Distcheck PASS 280.99 seconds
Build w/ext ELL - Configure PASS 10.66 seconds
Build w/ext ELL - Make PASS 1479.03 seconds
Incremental Build with patchesPASS 0.00 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] obexd: Fix can't receive small files sent by windows
2022-03-23 5:21 [PATCH] obexd: Fix can't receive small files sent by windows xinpeng wang
2022-03-23 6:47 ` bluez.test.bot
@ 2022-03-23 6:49 ` Paul Menzel
[not found] ` <2022032321151404413716@uniontech.com>
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2022-03-23 6:49 UTC (permalink / raw)
To: Xinpeng Wang; +Cc: linux-bluetooth
Dear Xinpeng,
Thank you for the patch.
You can use `git format-patch`’s switch `--reroll-count` to denote that
it’s replacing an earlier sent in patch. It’s also good practice to
write the changes between the version below the `---` line, so it’s
clear for the reviewer, what changed. For example:
v2: Fix typo in commit message summary
Am 23.03.22 um 06:21 schrieb xinpeng wang:
> Windows devices use streaming mode to send files. If a small file is
What do you mean by Windows devices exactly? Windows phone or any computer?
> sent,the first time processing data will be completed successfully,
Please add a space after the comma.
> and the transfer_complete function will be called before the end to
> clear os->path.At this time, the dbus signal is still pending, and
Please add a space after the dot/period.
> the dbus method call requesting the file path has not been processed;
> in this way, the upper-level program will not be able to obtain the
> file path, resulting in failure to receive the file.
> Therefore, the signal of Filename is generated, and it is forced to
> be sent when status=active.
I’d also add a blank line between paragraphs.
How can your issue be reproduced, and the fix verified?
> Signed-off-by: xinpeng wang <wangxinpeng@uniontech.com>
> ---
> obexd/src/manager.c | 6 +++++-
> obexd/src/obex.c | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/obexd/src/manager.c b/obexd/src/manager.c
> index 01741fe62..2c180dc44 100644
> --- a/obexd/src/manager.c
> +++ b/obexd/src/manager.c
> @@ -533,8 +533,12 @@ void manager_emit_transfer_property(struct obex_transfer *transfer,
> void manager_emit_transfer_started(struct obex_transfer *transfer)
> {
> transfer->status = TRANSFER_STATUS_ACTIVE;
> + if (!transfer->path)
> + return;
>
> - manager_emit_transfer_property(transfer, "Status");
> + g_dbus_emit_property_changed_full(connection, transfer->path,
> + TRANSFER_INTERFACE, "Status",
> + G_DBUS_PROPERTY_CHANGED_FLAG_FLUSH);
> }
>
> static void emit_transfer_completed(struct obex_transfer *transfer,
> diff --git a/obexd/src/obex.c b/obexd/src/obex.c
> index 3a68fd66c..c0d9e160a 100644
> --- a/obexd/src/obex.c
> +++ b/obexd/src/obex.c
> @@ -720,6 +720,7 @@ int obex_put_stream_start(struct obex_session *os, const char *filename)
> manager_emit_transfer_property(os->service_data, "Size");
>
> os->path = g_strdup(filename);
> + manager_emit_transfer_property(os->service_data, "Filename");
>
> return 0;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-25 5:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 5:21 [PATCH] obexd: Fix can't receive small files sent by windows xinpeng wang
2022-03-23 6:47 ` bluez.test.bot
2022-03-23 6:49 ` [PATCH] " Paul Menzel
[not found] ` <2022032321151404413716@uniontech.com>
2022-03-25 5:58 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.