All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brown <davidb@codeaurora.org>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: "Matthieu CASTET" <matthieu.castet@parrot.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Dima Zavin" <dima@android.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Brian Swetland" <swetland@google.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Wed, 27 Apr 2011 10:36:06 -0700	[thread overview]
Message-ID: <8yapqo74mwp.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4DB83E70.4050402@codeaurora.org> (Murali Nalajala's message of "Wed, 27 Apr 2011 21:34:00 +0530")

On Wed, Apr 27 2011, Murali Nalajala wrote:

> We have used nand base kind of implementation wherever is possible.
> eg: We have leveraged the code from nand base to detect the nand
> device properties.

Basing code off of other code but with modification is very different
than using that other code.  Copying and modifying creates more code
that can miss fixes and other changes.

I do think there is value in working with the nand code.  Remember that
the nand code is not immutable.  If there is something that almost does
what msm_nand needs, perhaps is can be changed to support that as well.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: David Brown <davidb@codeaurora.org>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Matthieu CASTET" <matthieu.castet@parrot.com>,
	"Dima Zavin" <dima@android.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Brian Swetland" <swetland@google.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Wed, 27 Apr 2011 10:36:06 -0700	[thread overview]
Message-ID: <8yapqo74mwp.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4DB83E70.4050402@codeaurora.org> (Murali Nalajala's message of "Wed, 27 Apr 2011 21:34:00 +0530")

On Wed, Apr 27 2011, Murali Nalajala wrote:

> We have used nand base kind of implementation wherever is possible.
> eg: We have leveraged the code from nand base to detect the nand
> device properties.

Basing code off of other code but with modification is very different
than using that other code.  Copying and modifying creates more code
that can miss fixes and other changes.

I do think there is value in working with the nand code.  Remember that
the nand code is not immutable.  If there is something that almost does
what msm_nand needs, perhaps is can be changed to support that as well.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Wed, 27 Apr 2011 10:36:06 -0700	[thread overview]
Message-ID: <8yapqo74mwp.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4DB83E70.4050402@codeaurora.org> (Murali Nalajala's message of "Wed, 27 Apr 2011 21:34:00 +0530")

On Wed, Apr 27 2011, Murali Nalajala wrote:

> We have used nand base kind of implementation wherever is possible.
> eg: We have leveraged the code from nand base to detect the nand
> device properties.

Basing code off of other code but with modification is very different
than using that other code.  Copying and modifying creates more code
that can miss fixes and other changes.

I do think there is value in working with the nand code.  Remember that
the nand code is not immutable.  If there is something that almost does
what msm_nand needs, perhaps is can be changed to support that as well.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-04-27 17:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  7:17 [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support Murali Nalajala
2011-07-08 16:50 ` Murali Nalajala
2011-04-16  7:17 ` Murali Nalajala
2011-04-18  7:32 ` Matthieu CASTET
2011-04-18  7:32   ` Matthieu CASTET
2011-04-18  7:32   ` Matthieu CASTET
2011-04-18  7:56   ` Artem Bityutskiy
2011-04-18  7:56     ` Artem Bityutskiy
2011-04-18  7:56     ` Artem Bityutskiy
2011-04-26 12:57   ` Murali Nalajala
2011-04-26 12:57     ` Murali Nalajala
2011-04-26 12:57     ` Murali Nalajala
2011-04-27 12:38     ` Matthieu CASTET
2011-04-27 12:38       ` Matthieu CASTET
2011-04-27 12:38       ` Matthieu CASTET
2011-04-27 16:04       ` Murali Nalajala
2011-04-27 16:04         ` Murali Nalajala
2011-04-27 16:04         ` Murali Nalajala
2011-04-27 17:36         ` David Brown [this message]
2011-04-27 17:36           ` David Brown
2011-04-27 17:36           ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8yapqo74mwp.fsf@huya.qualcomm.com \
    --to=davidb@codeaurora.org \
    --cc=arve@android.com \
    --cc=dima@android.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.com \
    --cc=mnalajal@codeaurora.org \
    --cc=swetland@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.