From: Alex Ghiti <alex@ghiti.fr> To: Helge Deller <deller@gmx.de>, Andrew Morton <akpm@linux-foundation.org> Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, "David S . Miller" <davem@davemloft.net>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Date: Wed, 28 Aug 2019 04:53:12 +0000 [thread overview] Message-ID: <904d05d1-e42e-233f-2321-7cd3a2a742eb@ghiti.fr> (raw) In-Reply-To: <9639ebd4-7dcb-0ea5-e0a6-adb8eaecd92a@gmx.de> On 8/26/19 6:37 PM, Helge Deller wrote: > On 26.08.19 09:34, Alexandre Ghiti wrote: >> On 6/20/19 7:03 AM, Alexandre Ghiti wrote: >>> This series fixes the fallback of the top-down mmap: in case of >>> failure, a bottom-up scheme can be tried as a last resort between >>> the top-down mmap base and the stack, hoping for a large unused stack >>> limit. >>> >>> Lots of architectures and even mm code start this fallback >>> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme >>> already failed on the whole address space: instead, simply use >>> mmap_base. >>> >>> Along the way, it allows to get rid of of mmap_legacy_base and >>> mmap_compat_legacy_base from mm_struct. >>> >>> Note that arm and mips already implement this behaviour. >>> >>> Alexandre Ghiti (8): >>> s390: Start fallback of top-down mmap at mm->mmap_base >>> sh: Start fallback of top-down mmap at mm->mmap_base >>> sparc: Start fallback of top-down mmap at mm->mmap_base >>> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base >>> mm: Start fallback top-down mmap at mm->mmap_base >>> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for >>> bottom-up mmap >>> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for >>> bottom-up >>> mmap >>> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from >>> mm_struct >>> >>> arch/parisc/kernel/sys_parisc.c | 8 +++----- >>> arch/s390/mm/mmap.c | 2 +- >>> arch/sh/mm/mmap.c | 2 +- >>> arch/sparc/kernel/sys_sparc_64.c | 2 +- >>> arch/sparc/mm/hugetlbpage.c | 2 +- >>> arch/x86/include/asm/elf.h | 2 +- >>> arch/x86/kernel/sys_x86_64.c | 4 ++-- >>> arch/x86/mm/hugetlbpage.c | 7 ++++--- >>> arch/x86/mm/mmap.c | 20 +++++++++----------- >>> include/linux/mm_types.h | 2 -- >>> mm/debug.c | 4 ++-- >>> mm/mmap.c | 2 +- >>> 12 files changed, 26 insertions(+), 31 deletions(-) >>> >> >> Any thoughts about that series ? As said before, this is just a >> preparatory patchset in order to >> merge x86 mmap top down code with the generic version. > > I just tested your patch series successfully on the parisc > architeture. You may add: > > Tested-by: Helge Deller <deller@gmx.de> # parisc Thanks again Helge ! Alex > > Thanks! > Helge
WARNING: multiple messages have this Message-ID (diff)
From: Alex Ghiti <alex@ghiti.fr> To: Helge Deller <deller@gmx.de>, Andrew Morton <akpm@linux-foundation.org> Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, "David S . Miller" <davem@davemloft.net>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Date: Wed, 28 Aug 2019 00:53:12 -0400 [thread overview] Message-ID: <904d05d1-e42e-233f-2321-7cd3a2a742eb@ghiti.fr> (raw) In-Reply-To: <9639ebd4-7dcb-0ea5-e0a6-adb8eaecd92a@gmx.de> On 8/26/19 6:37 PM, Helge Deller wrote: > On 26.08.19 09:34, Alexandre Ghiti wrote: >> On 6/20/19 7:03 AM, Alexandre Ghiti wrote: >>> This series fixes the fallback of the top-down mmap: in case of >>> failure, a bottom-up scheme can be tried as a last resort between >>> the top-down mmap base and the stack, hoping for a large unused stack >>> limit. >>> >>> Lots of architectures and even mm code start this fallback >>> at TASK_UNMAPPED_BASE, which is useless since the top-down scheme >>> already failed on the whole address space: instead, simply use >>> mmap_base. >>> >>> Along the way, it allows to get rid of of mmap_legacy_base and >>> mmap_compat_legacy_base from mm_struct. >>> >>> Note that arm and mips already implement this behaviour. >>> >>> Alexandre Ghiti (8): >>> s390: Start fallback of top-down mmap at mm->mmap_base >>> sh: Start fallback of top-down mmap at mm->mmap_base >>> sparc: Start fallback of top-down mmap at mm->mmap_base >>> x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base >>> mm: Start fallback top-down mmap at mm->mmap_base >>> parisc: Use mmap_base, not mmap_legacy_base, as low_limit for >>> bottom-up mmap >>> x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for >>> bottom-up >>> mmap >>> mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from >>> mm_struct >>> >>> arch/parisc/kernel/sys_parisc.c | 8 +++----- >>> arch/s390/mm/mmap.c | 2 +- >>> arch/sh/mm/mmap.c | 2 +- >>> arch/sparc/kernel/sys_sparc_64.c | 2 +- >>> arch/sparc/mm/hugetlbpage.c | 2 +- >>> arch/x86/include/asm/elf.h | 2 +- >>> arch/x86/kernel/sys_x86_64.c | 4 ++-- >>> arch/x86/mm/hugetlbpage.c | 7 ++++--- >>> arch/x86/mm/mmap.c | 20 +++++++++----------- >>> include/linux/mm_types.h | 2 -- >>> mm/debug.c | 4 ++-- >>> mm/mmap.c | 2 +- >>> 12 files changed, 26 insertions(+), 31 deletions(-) >>> >> >> Any thoughts about that series ? As said before, this is just a >> preparatory patchset in order to >> merge x86 mmap top down code with the generic version. > > I just tested your patch series successfully on the parisc > architeture. You may add: > > Tested-by: Helge Deller <deller@gmx.de> # parisc Thanks again Helge ! Alex > > Thanks! > Helge
next prev parent reply other threads:[~2019-08-28 4:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-19 5:38 [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Alexandre Ghiti 2019-06-19 5:38 ` Alexandre Ghiti 2019-06-19 5:42 ` Alexandre Ghiti 2019-06-19 5:42 ` Alexandre Ghiti 2019-06-19 5:42 ` [PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base Alexandre Ghiti 2019-06-19 5:42 ` Alexandre Ghiti 2019-06-19 5:54 ` Alex Ghiti 2019-06-19 5:54 ` Alex Ghiti 2019-06-20 5:03 ` [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 2/8] sh: " Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 3/8] sparc: " Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 4/8] x86, hugetlbpage: " Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 5/8] mm: Start fallback " Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 6/8] parisc: Use mmap_base, not mmap_legacy_base, as low_limit for bottom-up mmap Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-25 14:09 ` Helge Deller 2019-06-25 14:09 ` Helge Deller 2019-06-26 5:20 ` Alex Ghiti 2019-06-26 5:20 ` Alex Ghiti 2019-06-20 5:03 ` [PATCH RESEND 7/8] x86: Use mmap_*base, not mmap_*legacy_base, " Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-06-20 5:03 ` [PATCH RESEND 8/8] mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from mm_struct Alexandre Ghiti 2019-06-20 5:03 ` Alexandre Ghiti 2019-07-30 6:12 ` [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap Alexandre Ghiti 2019-07-30 6:12 ` Alexandre Ghiti 2019-08-26 7:34 ` Alexandre Ghiti 2019-08-26 7:34 ` Alexandre Ghiti 2019-08-26 22:37 ` Helge Deller 2019-08-26 22:37 ` Helge Deller 2019-08-28 4:53 ` Alex Ghiti [this message] 2019-08-28 4:53 ` Alex Ghiti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=904d05d1-e42e-233f-2321-7cd3a2a742eb@ghiti.fr \ --to=alex@ghiti.fr \ --cc=James.Bottomley@HansenPartnership.com \ --cc=akpm@linux-foundation.org \ --cc=borntraeger@de.ibm.com \ --cc=bp@alien8.de \ --cc=dalias@libc.org \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=deller@gmx.de \ --cc=gor@linux.ibm.com \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=sparclinux@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.