All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] selftests: pidfd: Fix compling warnings
@ 2022-09-01  3:17 Li Zhijian
  2022-09-29  0:55 ` Li Zhijian
  2022-10-30  8:29 ` Shuah Khan
  0 siblings, 2 replies; 4+ messages in thread
From: Li Zhijian @ 2022-09-01  3:17 UTC (permalink / raw)
  To: brauner, shuah, linux-kselftest; +Cc: linux-kernel, Li Zhijian

Fix warnings and enable Wall.

pidfd_wait.c: In function ‘wait_nonblock’:
pidfd_wait.c:150:13: warning: unused variable ‘status’ [-Wunused-variable]
  150 |  int pidfd, status = 0;
      |             ^~~~~~
...
pidfd_test.c: In function ‘child_poll_exec_test’:
pidfd_test.c:438:1: warning: no return statement in function returning non-void [-Wreturn-type]
  438 | }
      | ^

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
v2: fix mistake assignment to pidfd
---
 tools/testing/selftests/pidfd/Makefile     | 2 +-
 tools/testing/selftests/pidfd/pidfd_test.c | 2 ++
 tools/testing/selftests/pidfd/pidfd_wait.c | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/pidfd/Makefile b/tools/testing/selftests/pidfd/Makefile
index f4a2f28f926b..778b6cdc8aed 100644
--- a/tools/testing/selftests/pidfd/Makefile
+++ b/tools/testing/selftests/pidfd/Makefile
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
-CFLAGS += -g -I../../../../usr/include/ -pthread
+CFLAGS += -g -I../../../../usr/include/ -pthread -Wall
 
 TEST_GEN_PROGS := pidfd_test pidfd_fdinfo_test pidfd_open_test \
 	pidfd_poll_test pidfd_wait pidfd_getfd_test pidfd_setns_test
diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
index 9a2d64901d59..d36654265b7a 100644
--- a/tools/testing/selftests/pidfd/pidfd_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_test.c
@@ -435,6 +435,8 @@ static int child_poll_exec_test(void *args)
 	 */
 	while (1)
 		sleep(1);
+
+	return 0;
 }
 
 static void test_pidfd_poll_exec(int use_waitpid)
diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c
index c3e2a3041f55..0dcb8365ddc3 100644
--- a/tools/testing/selftests/pidfd/pidfd_wait.c
+++ b/tools/testing/selftests/pidfd/pidfd_wait.c
@@ -148,7 +148,7 @@ static int sys_waitid(int which, pid_t pid, siginfo_t *info, int options,
 
 TEST(wait_nonblock)
 {
-	int pidfd, status = 0;
+	int pidfd;
 	unsigned int flags = 0;
 	pid_t parent_tid = -1;
 	struct clone_args args = {
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests: pidfd: Fix compling warnings
  2022-09-01  3:17 [PATCH v2] selftests: pidfd: Fix compling warnings Li Zhijian
@ 2022-09-29  0:55 ` Li Zhijian
  2022-10-30  8:08   ` Li Zhijian
  2022-10-30  8:29 ` Shuah Khan
  1 sibling, 1 reply; 4+ messages in thread
From: Li Zhijian @ 2022-09-29  0:55 UTC (permalink / raw)
  To: brauner, shuah, linux-kselftest; +Cc: linux-kernel

ping

On 01/09/2022 11:17, Li Zhijian wrote:
> Fix warnings and enable Wall.
>
> pidfd_wait.c: In function ‘wait_nonblock’:
> pidfd_wait.c:150:13: warning: unused variable ‘status’ [-Wunused-variable]
>    150 |  int pidfd, status = 0;
>        |             ^~~~~~
> ...
> pidfd_test.c: In function ‘child_poll_exec_test’:
> pidfd_test.c:438:1: warning: no return statement in function returning non-void [-Wreturn-type]
>    438 | }
>        | ^
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> v2: fix mistake assignment to pidfd
> ---
>   tools/testing/selftests/pidfd/Makefile     | 2 +-
>   tools/testing/selftests/pidfd/pidfd_test.c | 2 ++
>   tools/testing/selftests/pidfd/pidfd_wait.c | 2 +-
>   3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/pidfd/Makefile b/tools/testing/selftests/pidfd/Makefile
> index f4a2f28f926b..778b6cdc8aed 100644
> --- a/tools/testing/selftests/pidfd/Makefile
> +++ b/tools/testing/selftests/pidfd/Makefile
> @@ -1,5 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0-only
> -CFLAGS += -g -I../../../../usr/include/ -pthread
> +CFLAGS += -g -I../../../../usr/include/ -pthread -Wall
>   
>   TEST_GEN_PROGS := pidfd_test pidfd_fdinfo_test pidfd_open_test \
>   	pidfd_poll_test pidfd_wait pidfd_getfd_test pidfd_setns_test
> diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
> index 9a2d64901d59..d36654265b7a 100644
> --- a/tools/testing/selftests/pidfd/pidfd_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_test.c
> @@ -435,6 +435,8 @@ static int child_poll_exec_test(void *args)
>   	 */
>   	while (1)
>   		sleep(1);
> +
> +	return 0;
>   }
>   
>   static void test_pidfd_poll_exec(int use_waitpid)
> diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c
> index c3e2a3041f55..0dcb8365ddc3 100644
> --- a/tools/testing/selftests/pidfd/pidfd_wait.c
> +++ b/tools/testing/selftests/pidfd/pidfd_wait.c
> @@ -148,7 +148,7 @@ static int sys_waitid(int which, pid_t pid, siginfo_t *info, int options,
>   
>   TEST(wait_nonblock)
>   {
> -	int pidfd, status = 0;
> +	int pidfd;
>   	unsigned int flags = 0;
>   	pid_t parent_tid = -1;
>   	struct clone_args args = {


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests: pidfd: Fix compling warnings
  2022-09-29  0:55 ` Li Zhijian
@ 2022-10-30  8:08   ` Li Zhijian
  0 siblings, 0 replies; 4+ messages in thread
From: Li Zhijian @ 2022-10-30  8:08 UTC (permalink / raw)
  To: brauner, shuah, linux-kselftest; +Cc: linux-kernel

ping again



On 29/09/2022 08:55, Li Zhijian wrote:
> ping
>
> On 01/09/2022 11:17, Li Zhijian wrote:
>> Fix warnings and enable Wall.
>>
>> pidfd_wait.c: In function ‘wait_nonblock’:
>> pidfd_wait.c:150:13: warning: unused variable ‘status’ [-Wunused-variable]
>>    150 |  int pidfd, status = 0;
>>        |             ^~~~~~
>> ...
>> pidfd_test.c: In function ‘child_poll_exec_test’:
>> pidfd_test.c:438:1: warning: no return statement in function returning non-void [-Wreturn-type]
>>    438 | }
>>        | ^
>>
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> v2: fix mistake assignment to pidfd
>> ---
>>   tools/testing/selftests/pidfd/Makefile     | 2 +-
>>   tools/testing/selftests/pidfd/pidfd_test.c | 2 ++
>>   tools/testing/selftests/pidfd/pidfd_wait.c | 2 +-
>>   3 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/pidfd/Makefile b/tools/testing/selftests/pidfd/Makefile
>> index f4a2f28f926b..778b6cdc8aed 100644
>> --- a/tools/testing/selftests/pidfd/Makefile
>> +++ b/tools/testing/selftests/pidfd/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>> -CFLAGS += -g -I../../../../usr/include/ -pthread
>> +CFLAGS += -g -I../../../../usr/include/ -pthread -Wall
>>     TEST_GEN_PROGS := pidfd_test pidfd_fdinfo_test pidfd_open_test \
>>       pidfd_poll_test pidfd_wait pidfd_getfd_test pidfd_setns_test
>> diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
>> index 9a2d64901d59..d36654265b7a 100644
>> --- a/tools/testing/selftests/pidfd/pidfd_test.c
>> +++ b/tools/testing/selftests/pidfd/pidfd_test.c
>> @@ -435,6 +435,8 @@ static int child_poll_exec_test(void *args)
>>        */
>>       while (1)
>>           sleep(1);
>> +
>> +    return 0;
>>   }
>>     static void test_pidfd_poll_exec(int use_waitpid)
>> diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c
>> index c3e2a3041f55..0dcb8365ddc3 100644
>> --- a/tools/testing/selftests/pidfd/pidfd_wait.c
>> +++ b/tools/testing/selftests/pidfd/pidfd_wait.c
>> @@ -148,7 +148,7 @@ static int sys_waitid(int which, pid_t pid, siginfo_t *info, int options,
>>     TEST(wait_nonblock)
>>   {
>> -    int pidfd, status = 0;
>> +    int pidfd;
>>       unsigned int flags = 0;
>>       pid_t parent_tid = -1;
>>       struct clone_args args = {
>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests: pidfd: Fix compling warnings
  2022-09-01  3:17 [PATCH v2] selftests: pidfd: Fix compling warnings Li Zhijian
  2022-09-29  0:55 ` Li Zhijian
@ 2022-10-30  8:29 ` Shuah Khan
  1 sibling, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2022-10-30  8:29 UTC (permalink / raw)
  To: Li Zhijian, brauner, shuah, linux-kselftest; +Cc: linux-kernel, Shuah Khan

On 8/31/22 21:17, Li Zhijian wrote:
> Fix warnings and enable Wall.
> 
> pidfd_wait.c: In function ‘wait_nonblock’:
> pidfd_wait.c:150:13: warning: unused variable ‘status’ [-Wunused-variable]
>    150 |  int pidfd, status = 0;
>        |             ^~~~~~
> ...
> pidfd_test.c: In function ‘child_poll_exec_test’:
> pidfd_test.c:438:1: warning: no return statement in function returning non-void [-Wreturn-type]
>    438 | }
>        | ^
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> v2: fix mistake assignment to pidfd
> ---

Sorry for the delay. Now applied to linux-kselftest fixes for rc4

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-30  8:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01  3:17 [PATCH v2] selftests: pidfd: Fix compling warnings Li Zhijian
2022-09-29  0:55 ` Li Zhijian
2022-10-30  8:08   ` Li Zhijian
2022-10-30  8:29 ` Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.