* [PATCH] media: staging: document that Imgu not output auto-exposure statistics
@ 2021-07-14 11:29 Bingbu Cao
2021-07-14 11:42 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Bingbu Cao @ 2021-07-14 11:29 UTC (permalink / raw)
To: linux-media, sakari.ailus, laurent.pinchart; +Cc: tfiga, bingbu.cao, bingbu.cao
Currently, Imgu can not support output the auto-exposure statistics into
ae_raw_buffer in 3A stats buffer, this patch document it.
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
index fa3d6ee5adf2..605113da1aed 100644
--- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
+++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
@@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
*
* @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
* @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
+ * current Imgu does not output the auto exposure statistics
+ * to ae_raw_buffer, the user such as 3A algorithm can use the
+ * RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.
* @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
* @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
* @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: document that Imgu not output auto-exposure statistics
2021-07-14 11:29 [PATCH] media: staging: document that Imgu not output auto-exposure statistics Bingbu Cao
@ 2021-07-14 11:42 ` Laurent Pinchart
2021-07-14 11:48 ` Bingbu Cao
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2021-07-14 11:42 UTC (permalink / raw)
To: Bingbu Cao; +Cc: linux-media, sakari.ailus, tfiga, bingbu.cao
Hi Bingbu,
Thank you for the patch.
On Wed, Jul 14, 2021 at 07:29:40PM +0800, Bingbu Cao wrote:
> Currently, Imgu can not support output the auto-exposure statistics into
> ae_raw_buffer in 3A stats buffer, this patch document it.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> ---
> drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> index fa3d6ee5adf2..605113da1aed 100644
> --- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> +++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> @@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
> *
> * @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
> * @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
> + * current Imgu does not output the auto exposure statistics
> + * to ae_raw_buffer, the user such as 3A algorithm can use the
> + * RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.
Is there any other fields in the statistics buffer that is not populated
by the device, or is this the only one ?
Could you please also mark the corresponding parameters fields as unused
by the device ?
> * @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
> * @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
> * @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: document that Imgu not output auto-exposure statistics
2021-07-14 11:42 ` Laurent Pinchart
@ 2021-07-14 11:48 ` Bingbu Cao
0 siblings, 0 replies; 3+ messages in thread
From: Bingbu Cao @ 2021-07-14 11:48 UTC (permalink / raw)
To: Laurent Pinchart, Bingbu Cao; +Cc: linux-media, sakari.ailus, tfiga
Laurent,
Thanks for your review.
On 7/14/21 7:42 PM, Laurent Pinchart wrote:
> Hi Bingbu,
>
> Thank you for the patch.
>
> On Wed, Jul 14, 2021 at 07:29:40PM +0800, Bingbu Cao wrote:
>> Currently, Imgu can not support output the auto-exposure statistics into
>> ae_raw_buffer in 3A stats buffer, this patch document it.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> ---
>> drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
>> index fa3d6ee5adf2..605113da1aed 100644
>> --- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
>> +++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
>> @@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
>> *
>> * @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
>> * @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
>> + * current Imgu does not output the auto exposure statistics
>> + * to ae_raw_buffer, the user such as 3A algorithm can use the
>> + * RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.
>
> Is there any other fields in the statistics buffer that is not populated
> by the device, or is this the only one ?
I will check again whether there is any I missed.
>
> Could you please also mark the corresponding parameters fields as unused
> by the device ?
Yes, sure.
>
>> * @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
>> * @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
>> * @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-14 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 11:29 [PATCH] media: staging: document that Imgu not output auto-exposure statistics Bingbu Cao
2021-07-14 11:42 ` Laurent Pinchart
2021-07-14 11:48 ` Bingbu Cao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.