[Xen-devel] [PATCH] AMD/IOMMU: drop unused PCI-generic #define-s

[Xen-devel] [PATCH] AMD/IOMMU: drop unused PCI-generic #define-s

[Jan Beulich]

Quite possibly they had been in use when some of the PCI interfacing was
done in an ad hoc way rather than using the PCI functions we have. Right
now these have no users (left).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu-defs.h
+++ b/xen/drivers/passthrough/amd/iommu-defs.h
@@ -40,10 +40,6 @@
 #define amd_offset_level_address(offset, level) \
         ((uint64_t)(offset) << (12 + (PTE_PER_TABLE_SHIFT * ((level) - 1))))
 
-#define PCI_MIN_CAP_OFFSET	0x40
-#define PCI_MAX_CAP_BLOCKS	48
-#define PCI_CAP_PTR_MASK	0xFC
-
 /* IOMMU Capability */
 #define PCI_CAP_ID_MASK		0x000000FF
 #define PCI_CAP_ID_SHIFT	0

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] AMD/IOMMU: drop unused PCI-generic #define-s

[Andrew Cooper]

On 19/02/2020 13:37, Jan Beulich wrote:
> Quite possibly they had been in use when some of the PCI interfacing was
> done in an ad hoc way rather than using the PCI functions we have. Right
> now these have no users (left).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel