From: Daniel Borkmann <daniel@iogearbox.net>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
peterz@infradead.org, netdev@vger.kernel.org,
namhyung@kernel.org
Subject: Re: [PATCH bpf] tools: bpf: fix NULL return handling in bpf__prepare_load
Date: Tue, 15 May 2018 16:20:48 +0200 [thread overview]
Message-ID: <90ea1b1c-26f5-3928-4897-536e576d2b4a@iogearbox.net> (raw)
In-Reply-To: <20180515141143.GH2917@kernel.org>
On 05/15/2018 04:11 PM, Arnaldo Carvalho de Melo wrote:
> Em Sun, May 13, 2018 at 01:20:22AM +0200, Daniel Borkmann escreveu:
>> [ +Arnaldo ]
>>
>> On 05/11/2018 01:21 PM, YueHaibing wrote:
>>> bpf_object__open()/bpf_object__open_buffer can return error pointer or NULL,
>>> check the return values with IS_ERR_OR_NULL() in bpf__prepare_load and
>>> bpf__prepare_load_buffer
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> tools/perf/util/bpf-loader.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> This should probably be routed via Arnaldo due to the fix in perf itself. If
>> there's no particular preference on which tree, we could potentially route it
>> as well via bpf with Acked-by from Arnaldo, but that is up to him. Arnaldo,
>> any preference?
>
> I'm preparing a pull req right now, and working a bit on perf's BPF
> support, so why not, I'll merge it, thanks,
Sounds good, thanks Arnaldo!
> - Arnaldo
prev parent reply other threads:[~2018-05-15 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 11:21 [PATCH bpf] tools: bpf: fix NULL return handling in bpf__prepare_load YueHaibing
2018-05-12 23:20 ` Daniel Borkmann
2018-05-15 14:11 ` Arnaldo Carvalho de Melo
2018-05-15 14:20 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ea1b1c-26f5-3928-4897-536e576d2b4a@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.