From: Zefan Li <lizefan@huawei.com>
To: Muchun Song <songmuchun@bytedance.com>,
Chris Down <chris@chrisdown.name>
Cc: <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
<corbet@lwn.net>, Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.com>,
Cgroups <cgroups@vger.kernel.org>, <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2
Date: Mon, 14 Sep 2020 11:18:52 +0800 [thread overview]
Message-ID: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> (raw)
In-Reply-To: <CAMZfGtVBFCodKuNKzG8TxKjeuC1_hF_YKdqMTmX5ENE_FfDmzw@mail.gmail.com>
On 2020/9/14 11:10, Muchun Song wrote:
> On Mon, Sep 14, 2020 at 1:09 AM Chris Down <chris@chrisdown.name> wrote:
>>
>> Muchun Song writes:
>>> In the cgroup v1, we have a numa_stat interface. This is useful for
>>> providing visibility into the numa locality information within an
>>> memcg since the pages are allowed to be allocated from any physical
>>> node. One of the use cases is evaluating application performance by
>>> combining this information with the application's CPU allocation.
>>> But the cgroup v2 does not. So this patch adds the missing information.
>>>
>>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>>> Suggested-by: Shakeel Butt <shakeelb@google.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> This is a feature patch, why does this have LKP's Reported-by?
>
> In the v2 version, the kernel test robot reported a compiler error
> on the powerpc architecture. So I added that. Thanks.
>
You should remove this reported-by, and then add v2->v3 changelog:
...original changelog...
v3:
- fixed something reported by test rebot
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
Chris Down <chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
corbet-T1hC0tSOHrs@public.gmane.org,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Memory Management List
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2
Date: Mon, 14 Sep 2020 11:18:52 +0800 [thread overview]
Message-ID: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> (raw)
In-Reply-To: <CAMZfGtVBFCodKuNKzG8TxKjeuC1_hF_YKdqMTmX5ENE_FfDmzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2020/9/14 11:10, Muchun Song wrote:
> On Mon, Sep 14, 2020 at 1:09 AM Chris Down <chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org> wrote:
>>
>> Muchun Song writes:
>>> In the cgroup v1, we have a numa_stat interface. This is useful for
>>> providing visibility into the numa locality information within an
>>> memcg since the pages are allowed to be allocated from any physical
>>> node. One of the use cases is evaluating application performance by
>>> combining this information with the application's CPU allocation.
>>> But the cgroup v2 does not. So this patch adds the missing information.
>>>
>>> Signed-off-by: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
>>> Suggested-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>>> Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> This is a feature patch, why does this have LKP's Reported-by?
>
> In the v2 version, the kernel test robot reported a compiler error
> on the powerpc architecture. So I added that. Thanks.
>
You should remove this reported-by, and then add v2->v3 changelog:
...original changelog...
v3:
- fixed something reported by test rebot
next prev parent reply other threads:[~2020-09-14 3:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 7:00 [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 Muchun Song
2020-09-13 17:09 ` Chris Down
2020-09-14 3:10 ` [External] " Muchun Song
2020-09-14 3:10 ` Muchun Song
2020-09-14 3:18 ` Zefan Li [this message]
2020-09-14 3:18 ` Zefan Li
2020-09-14 3:28 ` Muchun Song
2020-09-14 3:28 ` Muchun Song
2020-09-14 16:07 ` Shakeel Butt
2020-09-14 16:07 ` Shakeel Butt
2020-09-14 16:54 ` [External] " Muchun Song
2020-09-14 16:54 ` Muchun Song
2020-09-14 16:54 ` Muchun Song
2020-09-14 22:57 ` Shakeel Butt
2020-09-14 22:57 ` Shakeel Butt
2020-09-14 22:57 ` Shakeel Butt
2020-09-15 2:46 ` Muchun Song
2020-09-15 2:46 ` Muchun Song
2020-09-15 2:46 ` Muchun Song
2020-09-14 19:06 ` Randy Dunlap
2020-09-15 2:44 ` [External] " Muchun Song
2020-09-15 2:44 ` Muchun Song
2020-09-15 2:44 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91184891-6a12-87a2-5a82-099a637b072f@huawei.com \
--to=lizefan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=corbet@lwn.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.