[PATCH] meson: be strict for boolean options

[PATCH] meson: be strict for boolean options

[Anton Kochkov]

While Meson buildsystem accepts the 'false' as a value
for boolean options, it's not covered by the specification
and in general invalid. Some alternative Meson implementations,
like Muon, do not accept 'false' or 'true' as a valid value
for the boolean options.

See https://mesonbuild.com/Build-options.html

Signed-off-by: Anton Kochkov <anton.kochkov@proton.me>
---
 meson_options.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson_options.txt b/meson_options.txt
index e58e158396..63f0725174 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -82,9 +82,9 @@ option('tcg', type: 'feature', value: 'enabled',
        description: 'TCG support')
 option('tcg_interpreter', type: 'boolean', value: false,
        description: 'TCG with bytecode interpreter (slow)')
-option('cfi', type: 'boolean', value: 'false',
+option('cfi', type: 'boolean', value: false,
        description: 'Control-Flow Integrity (CFI)')
-option('cfi_debug', type: 'boolean', value: 'false',
+option('cfi_debug', type: 'boolean', value: false,
        description: 'Verbose errors in case of CFI violation')
 option('multiprocess', type: 'feature', value: 'auto',
        description: 'Out of process device emulation support')
--
2.37.1

Re: [PATCH] meson: be strict for boolean options

[Philippe Mathieu-Daudé via]

On 13/8/22 14:15, Anton Kochkov wrote:
> While Meson buildsystem accepts the 'false' as a value
> for boolean options, it's not covered by the specification
> and in general invalid. Some alternative Meson implementations,
> like Muon, do not accept 'false' or 'true' as a valid value
> for the boolean options.
> 
> See https://mesonbuild.com/Build-options.html
> 
> Signed-off-by: Anton Kochkov <anton.kochkov@proton.me>
> ---
>   meson_options.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index e58e158396..63f0725174 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -82,9 +82,9 @@ option('tcg', type: 'feature', value: 'enabled',
>          description: 'TCG support')
>   option('tcg_interpreter', type: 'boolean', value: false,
>          description: 'TCG with bytecode interpreter (slow)')
> -option('cfi', type: 'boolean', value: 'false',
> +option('cfi', type: 'boolean', value: false,
>          description: 'Control-Flow Integrity (CFI)')
> -option('cfi_debug', type: 'boolean', value: 'false',
> +option('cfi_debug', type: 'boolean', value: false,
>          description: 'Verbose errors in case of CFI violation')
>   option('multiprocess', type: 'feature', value: 'auto',
>          description: 'Out of process device emulation support')
> --
> 2.37.1
> 
> 
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

[PATCH] meson: be strict for boolean options

[Антон Кочков]

This patch allows to proceed further to be able to build with Muon buildsystem

https://sr.ht/~lattis/muon/

There are still few bugs remain, but they are on the Muon side:
https://todo.sr.ht/~lattis/muon/21

Best regards,
Anton Kochkov.

From fa80e0c17b14b8f5067d13ad7bc63e0d2cbb94ce Mon Sep 17 00:00:00 2001
From: Anton Kochkov <anton.kochkov@gmail.com>
Date: Fri, 10 Dec 2021 21:10:34 +0800
Subject: [PATCH] meson: be strict for boolean options

While Meson buildsystem accepts the 'false' as a value
for boolean options, it's not covered by the specification
and in general invalid. Some alternative Meson implementations,
like Muon, do not accept 'false' or 'true' as a valid value
for the boolean options.

See https://mesonbuild.com/Build-options.html

Signed-off-by: Anton Kochkov <anton.kochkov@gmail.com>
---
 meson_options.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson_options.txt b/meson_options.txt
index e392323732..4ca770c1bd 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -60,9 +60,9 @@ option('tcg', type: 'feature', value: 'auto',
        description: 'TCG support')
 option('tcg_interpreter', type: 'boolean', value: false,
        description: 'TCG with bytecode interpreter (slow)')
-option('cfi', type: 'boolean', value: 'false',
+option('cfi', type: 'boolean', value: false,
        description: 'Control-Flow Integrity (CFI)')
-option('cfi_debug', type: 'boolean', value: 'false',
+option('cfi_debug', type: 'boolean', value: false,
        description: 'Verbose errors in case of CFI violation')
 option('multiprocess', type: 'feature', value: 'auto',
        description: 'Out of process device emulation support')
-- 
2.33.1