Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Mathieu Desnoyers]

* Thibault, Daniel (Daniel.Thibault@drdc-rddc.gc.ca) wrote:
> ------------------------------
> Date: Wed, 7 Aug 2013 12:48:53 -0700
> From: Vomlehn <vomlehnd@amazon.com>
> 
> -- ./configure
> -- make
> -- make install
> +  $ ./configure
> +  $ make
> +  $ make install
> +
> +To compile the source tree from a git checkout, use:
> +
> +  $ autoreconf
> +  $ automake --add-missing --gnu
> +  $ make
> +  $ make install
>  
>  After running ./configure, you can also go in specific subdirectories and
>  use make, make install.
> ------------------------------
> 
>    Actually, in each instance of 'make install', you'll need to use 'sudo make install'.

(as root)
# make install

would be the proper way to document this.

sudo is just one way to gain root privileges. "su" can be used on many
distributions for this too. Also, if a configure --prefix is used to
target a user-writeable directory, root is not required (but it's
generally not the case).

Thanks,

Mathieu


> 
> Daniel U. Thibault
> Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
> Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
> R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
> 2459 route de la Bravoure
> Québec QC  G3J 1X5
> CANADA
> Vox : (418) 844-4000 x4245
> Fax : (418) 844-4538
> NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
> Gouvernement du Canada | Government of Canada
> <http://www.valcartier.drdc-rddc.gc.ca/>
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[VomLehn, David]

Oops, hit "Reply" instead of "Reply All", so:

+ Thibault, Daniel ‎[Daniel.Thibault@drdc-rddc.gc.ca]‎
+ lttng-dev@lists.lttng.org 
--
David VL

________________________________________
From: VomLehn, David
Sent: Thursday, August 08, 2013 11:48 AM
To: Mathieu Desnoyers
Subject: RE: [lttng-dev] [PATCH lttv] Add build instructions for git tree       pulls and use more standard formatting

My patch was only focused on the fact that the build procedure for what you get after a git pull requires a different build procedure since it doesn't have the ./configure file you would get from a tar release file. The sentence about going into specific subdirectories was part of the context, and not part of the patch. If we want to update that, too, I think it should be a separate patch.
--
David VL

________________________________________
From: Mathieu Desnoyers [mathieu.desnoyers@efficios.com]
Sent: Thursday, August 08, 2013 8:23 AM
To: Thibault, Daniel
Cc: lttng-dev@lists.lttng.org; VomLehn, David
Subject: Re: [lttng-dev] [PATCH lttv] Add build instructions for git tree       pulls and use more standard formatting

* Thibault, Daniel (Daniel.Thibault@drdc-rddc.gc.ca) wrote:
> ------------------------------
> Date: Wed, 7 Aug 2013 12:48:53 -0700
> From: Vomlehn <vomlehnd@amazon.com>
>
> -- ./configure
> -- make
> -- make install
> +  $ ./configure
> +  $ make
> +  $ make install
> +
> +To compile the source tree from a git checkout, use:
> +
> +  $ autoreconf
> +  $ automake --add-missing --gnu
> +  $ make
> +  $ make install
>
>  After running ./configure, you can also go in specific subdirectories and
>  use make, make install.
> ------------------------------
>
>    Actually, in each instance of 'make install', you'll need to use 'sudo make install'.

(as root)
# make install

would be the proper way to document this.

sudo is just one way to gain root privileges. "su" can be used on many
distributions for this too. Also, if a configure --prefix is used to
target a user-writeable directory, root is not required (but it's
generally not the case).

Thanks,

Mathieu


>
> Daniel U. Thibault
> Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
> Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
> R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
> 2459 route de la Bravoure
> Québec QC  G3J 1X5
> CANADA
> Vox : (418) 844-4000 x4245
> Fax : (418) 844-4538
> NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
> Gouvernement du Canada | Government of Canada
> <http://www.valcartier.drdc-rddc.gc.ca/>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Vomlehn]

Yes, I think you are right. Patch in following message.

On Mon, Aug 19, 2013 at 09:42:25AM +0300, Amit Margalit wrote:
> I thouhght that's what the 'bootstrap' script is for. I mean - it includes 
> autoreconf -i plus creation of config directory... So maybe the doc should 
> say "use the bootstrap script" instead of calling users to run autoreconf 
> -i ...
> 
> Amit Margalit
> IBM XIV - Storage Reinvented
> XIV-NAS Development Team
> Tel. 03-689-7774
> Fax. 03-689-7230
> 
> 
> 
> From:   Alexandre Montplaisir <alexmonthy@voxpopuli.im>
> To:     lttng-dev@lists.lttng.org
> Cc:     Vomlehn <vomlehnd@amazon.com>
> Date:   08/08/2013 10:08 PM
> Subject:        Re: [lttng-dev] [PATCH lttv] Add build instructions for 
> git tree pulls and use more standard formatting
> 
> 
> 
> On 13-08-07 03:48 PM, Vomlehn wrote:
> > If the source is obtained directly from git, the file "configure" must 
> be
> > built with the autoconf tools. In addition, example shell commands are
> > traditionally preceeded with a "$" instead of a "-", so this convention
> > is used.
> > ---
> >  README |   13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/README b/README
> > index 98849b3..ac28f9e 100644
> > --- a/README
> > +++ b/README
> > @@ -31,9 +31,16 @@ libc6 development librairies
> > 
> >  To compile the source tree from a tarball, simply follow these steps :
> > 
> > -- ./configure
> > -- make
> > -- make install
> > +  $ ./configure
> > +  $ make
> > +  $ make install
> > +
> > +To compile the source tree from a git checkout, use:
> > +
> > +  $ autoreconf
> > +  $ automake --add-missing --gnu
> 
> You should be able to use "autoreconf -i" instead of those two commands.
> It avoids the need to run autoconf, automake etc. manually.
> 
> > +  $ make
> > +  $ make install
> 
> As was mentioned in the other thread, this should be "# make install",
> since with the default configure options, it will install in /usr/local,
> and only root can write there.
> 
> Cheers,
> Alex
> 
> > 
> >  After running ./configure, you can also go in specific subdirectories 
> and
> >  use make, make install.
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 
> 

-- 
David VL

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Amit Margalit]

[-- Attachment #1.1: Type: text/plain, Size: 2045 bytes --]

I thouhght that's what the 'bootstrap' script is for. I mean - it includes 
autoreconf -i plus creation of config directory... So maybe the doc should 
say "use the bootstrap script" instead of calling users to run autoreconf 
-i ...

Amit Margalit
IBM XIV - Storage Reinvented
XIV-NAS Development Team
Tel. 03-689-7774
Fax. 03-689-7230



From:   Alexandre Montplaisir <alexmonthy@voxpopuli.im>
To:     lttng-dev@lists.lttng.org
Cc:     Vomlehn <vomlehnd@amazon.com>
Date:   08/08/2013 10:08 PM
Subject:        Re: [lttng-dev] [PATCH lttv] Add build instructions for 
git tree pulls and use more standard formatting



On 13-08-07 03:48 PM, Vomlehn wrote:
> If the source is obtained directly from git, the file "configure" must 
be
> built with the autoconf tools. In addition, example shell commands are
> traditionally preceeded with a "$" instead of a "-", so this convention
> is used.
> ---
>  README |   13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/README b/README
> index 98849b3..ac28f9e 100644
> --- a/README
> +++ b/README
> @@ -31,9 +31,16 @@ libc6 development librairies
> 
>  To compile the source tree from a tarball, simply follow these steps :
> 
> -- ./configure
> -- make
> -- make install
> +  $ ./configure
> +  $ make
> +  $ make install
> +
> +To compile the source tree from a git checkout, use:
> +
> +  $ autoreconf
> +  $ automake --add-missing --gnu

You should be able to use "autoreconf -i" instead of those two commands.
It avoids the need to run autoconf, automake etc. manually.

> +  $ make
> +  $ make install

As was mentioned in the other thread, this should be "# make install",
since with the default configure options, it will install in /usr/local,
and only root can write there.

Cheers,
Alex

> 
>  After running ./configure, you can also go in specific subdirectories 
and
>  use make, make install.


_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev



[-- Attachment #1.2: Type: text/html, Size: 3641 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Alexandre Montplaisir]

On 13-08-07 03:48 PM, Vomlehn wrote:
> If the source is obtained directly from git, the file "configure" must be
> built with the autoconf tools. In addition, example shell commands are
> traditionally preceeded with a "$" instead of a "-", so this convention
> is used.
> ---
>  README |   13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/README b/README
> index 98849b3..ac28f9e 100644
> --- a/README
> +++ b/README
> @@ -31,9 +31,16 @@ libc6 development librairies
>  
>  To compile the source tree from a tarball, simply follow these steps :
>  
> -- ./configure
> -- make
> -- make install
> +  $ ./configure
> +  $ make
> +  $ make install
> +
> +To compile the source tree from a git checkout, use:
> +
> +  $ autoreconf
> +  $ automake --add-missing --gnu

You should be able to use "autoreconf -i" instead of those two commands.
It avoids the need to run autoconf, automake etc. manually.

> +  $ make
> +  $ make install

As was mentioned in the other thread, this should be "# make install",
since with the default configure options, it will install in /usr/local,
and only root can write there.

Cheers,
Alex

>  
>  After running ./configure, you can also go in specific subdirectories and
>  use make, make install.

Re: [PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Thibault, Daniel]

------------------------------
Date: Wed, 7 Aug 2013 12:48:53 -0700
From: Vomlehn <vomlehnd@amazon.com>

-- ./configure
-- make
-- make install
+  $ ./configure
+  $ make
+  $ make install
+
+To compile the source tree from a git checkout, use:
+
+  $ autoreconf
+  $ automake --add-missing --gnu
+  $ make
+  $ make install
 
 After running ./configure, you can also go in specific subdirectories and
 use make, make install.
------------------------------

   Actually, in each instance of 'make install', you'll need to use 'sudo make install'.

Daniel U. Thibault
Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
2459 route de la Bravoure
Québec QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada | Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>

[PATCH lttv] Add build instructions for git tree pulls and use more standard formatting

[Vomlehn]

If the source is obtained directly from git, the file "configure" must be
built with the autoconf tools. In addition, example shell commands are
traditionally preceeded with a "$" instead of a "-", so this convention
is used.
---
 README |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/README b/README
index 98849b3..ac28f9e 100644
--- a/README
+++ b/README
@@ -31,9 +31,16 @@ libc6 development librairies
 
 To compile the source tree from a tarball, simply follow these steps :
 
-- ./configure
-- make
-- make install
+  $ ./configure
+  $ make
+  $ make install
+
+To compile the source tree from a git checkout, use:
+
+  $ autoreconf
+  $ automake --add-missing --gnu
+  $ make
+  $ make install
 
 After running ./configure, you can also go in specific subdirectories and
 use make, make install.
-- 
David VL