From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Yuantian Tang <andy.tang@nxp.com>, shawnguo@kernel.org Cc: leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, edubezval@gmail.com Subject: Re: [PATCH v5] arm64: dts: ls1088a: add one more thermal zone node Date: Thu, 11 Apr 2019 21:14:44 +0200 [thread overview] Message-ID: <915c86d8-d00e-f1e1-e7f5-24bc225c8e42@linaro.org> (raw) In-Reply-To: <20190411083236.9377-1-andy.tang@nxp.com> On 11/04/2019 10:32, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster > sensor is used to monitor the temperature of core and SoC platform is for > platform. The current dts only support the first sensor. > This patch adds the second sensor node to dts to enable it. > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > --- > v5: > - update the thermal zone name due to the length limitation > - remove cooling map in platform zone > v4: > - use hyphen instead of underscore in node name > v3: > - use more descriptive name for each zone > v2: > - Add more information about sensors to description > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 28 ++++++++++++++++++++--- > 1 files changed, 24 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index de93b42..de39672 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -129,19 +129,19 @@ > }; > > thermal-zones { > - cpu_thermal: cpu-thermal { > + core-cluster { > polling-delay-passive = <1000>; > polling-delay = <5000>; > thermal-sensors = <&tmu 0>; > > trips { > - cpu_alert: cpu-alert { > + core_cluster_alert: core-cluster-alert { > temperature = <85000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu_crit: cpu-crit { > + core_cluster_crit: core-cluster-crit { > temperature = <95000>; > hysteresis = <2000>; > type = "critical"; > @@ -150,7 +150,7 @@ > > cooling-maps { > map0 { > - trip = <&cpu_alert>; > + trip = <&core_cluster_alert>; > cooling-device = > <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > @@ -163,6 +163,26 @@ > }; > }; > }; > + > + platform { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + platform-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + platform-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; Unfortunately, the documentation says the thermal zone node must contain a "cooling-maps" entry. It makes sense as if there is no cooling device, there is no action to be taken thus polling the temperature just add noise to the system. > }; > > timer { > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Yuantian Tang <andy.tang@nxp.com>, shawnguo@kernel.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, edubezval@gmail.com, robh+dt@kernel.org, rui.zhang@intel.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5] arm64: dts: ls1088a: add one more thermal zone node Date: Thu, 11 Apr 2019 21:14:44 +0200 [thread overview] Message-ID: <915c86d8-d00e-f1e1-e7f5-24bc225c8e42@linaro.org> (raw) In-Reply-To: <20190411083236.9377-1-andy.tang@nxp.com> On 11/04/2019 10:32, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster > sensor is used to monitor the temperature of core and SoC platform is for > platform. The current dts only support the first sensor. > This patch adds the second sensor node to dts to enable it. > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > --- > v5: > - update the thermal zone name due to the length limitation > - remove cooling map in platform zone > v4: > - use hyphen instead of underscore in node name > v3: > - use more descriptive name for each zone > v2: > - Add more information about sensors to description > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 28 ++++++++++++++++++++--- > 1 files changed, 24 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index de93b42..de39672 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -129,19 +129,19 @@ > }; > > thermal-zones { > - cpu_thermal: cpu-thermal { > + core-cluster { > polling-delay-passive = <1000>; > polling-delay = <5000>; > thermal-sensors = <&tmu 0>; > > trips { > - cpu_alert: cpu-alert { > + core_cluster_alert: core-cluster-alert { > temperature = <85000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu_crit: cpu-crit { > + core_cluster_crit: core-cluster-crit { > temperature = <95000>; > hysteresis = <2000>; > type = "critical"; > @@ -150,7 +150,7 @@ > > cooling-maps { > map0 { > - trip = <&cpu_alert>; > + trip = <&core_cluster_alert>; > cooling-device = > <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > @@ -163,6 +163,26 @@ > }; > }; > }; > + > + platform { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + platform-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + platform-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; Unfortunately, the documentation says the thermal zone node must contain a "cooling-maps" entry. It makes sense as if there is no cooling device, there is no action to be taken thus polling the temperature just add noise to the system. > }; > > timer { > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 19:14 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-11 8:32 [PATCH v5] arm64: dts: ls1088a: add one more thermal zone node Yuantian Tang 2019-04-11 8:32 ` Yuantian Tang 2019-04-11 19:14 ` Daniel Lezcano [this message] 2019-04-11 19:14 ` Daniel Lezcano 2019-04-12 7:47 ` [EXT] " Andy Tang 2019-04-12 7:47 ` Andy Tang 2019-04-12 12:19 ` Daniel Lezcano 2019-04-12 12:19 ` Daniel Lezcano 2019-04-12 12:19 ` Daniel Lezcano 2019-04-18 3:28 ` Andy Tang 2019-04-18 3:28 ` Andy Tang 2019-04-21 6:45 ` Shawn Guo 2019-04-21 6:45 ` Shawn Guo 2019-04-21 6:45 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=915c86d8-d00e-f1e1-e7f5-24bc225c8e42@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=andy.tang@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.