* [PATCH v2] configure: Avoid compiling system tools on user build by default
@ 2020-02-17 9:59 Philippe Mathieu-Daudé
2020-02-17 10:04 ` Laurent Vivier
2020-02-17 12:35 ` Aleksandar Markovic
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-17 9:59 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-block, Richard Henderson, Philippe Mathieu-Daudé,
Laurent Vivier, Paolo Bonzini, Aleksandar Markovic
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
User-mode does not need the sytem tools. Do not build them by
default if user specified --disable-system.
This disables building the following binary on a user-only build:
- elf2dmp
- qemu-edid
- qemu-ga
- qemu-img
- qemu-io
- qemu-nbd
- ivshmem-client
- ivshmem-server
The qemu-user binary is not affected by this change.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2:
- use simpler if/else statement (therefore not adding Richard R-b)
- improved description (Aleksandar)
---
configure | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 16f94cd96b..d1877a60f5 100755
--- a/configure
+++ b/configure
@@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
guest_agent_msi=""
vss_win32_sdk=""
win_sdk="no"
-want_tools="yes"
+want_tools=""
libiscsi=""
libnfs=""
coroutine=""
@@ -2199,6 +2199,16 @@ else
echo big/little test failed
fi
+##########################################
+# system tools
+if test -z "$want_tools"; then
+ if test "$softmmu" = "no"; then
+ want_tools=no
+ else
+ want_tools=yes
+ fi
+fi
+
##########################################
# cocoa implies not SDL or GTK
# (the cocoa UI code currently assumes it is always the active UI
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] configure: Avoid compiling system tools on user build by default
2020-02-17 9:59 [PATCH v2] configure: Avoid compiling system tools on user build by default Philippe Mathieu-Daudé
@ 2020-02-17 10:04 ` Laurent Vivier
2020-02-17 12:35 ` Aleksandar Markovic
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-02-17 10:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Aleksandar Markovic,
qemu-block, Philippe Mathieu-Daudé
Le 17/02/2020 à 10:59, Philippe Mathieu-Daudé a écrit :
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> User-mode does not need the sytem tools. Do not build them by
> default if user specified --disable-system.
>
> This disables building the following binary on a user-only build:
>
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
>
> The qemu-user binary is not affected by this change.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
> configure | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 16f94cd96b..d1877a60f5 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
> guest_agent_msi=""
> vss_win32_sdk=""
> win_sdk="no"
> -want_tools="yes"
> +want_tools=""
> libiscsi=""
> libnfs=""
> coroutine=""
> @@ -2199,6 +2199,16 @@ else
> echo big/little test failed
> fi
>
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> + if test "$softmmu" = "no"; then
> + want_tools=no
> + else
> + want_tools=yes
> + fi
> +fi
> +
> ##########################################
> # cocoa implies not SDL or GTK
> # (the cocoa UI code currently assumes it is always the active UI
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] configure: Avoid compiling system tools on user build by default
2020-02-17 9:59 [PATCH v2] configure: Avoid compiling system tools on user build by default Philippe Mathieu-Daudé
2020-02-17 10:04 ` Laurent Vivier
@ 2020-02-17 12:35 ` Aleksandar Markovic
1 sibling, 0 replies; 3+ messages in thread
From: Aleksandar Markovic @ 2020-02-17 12:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: open list:bochs, Richard Henderson, Philippe Mathieu-Daudé,
QEMU Developers, Paolo Bonzini, Laurent Vivier
[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]
11:00 AM Pon, 17.02.2020. Philippe Mathieu-Daudé <philmd@redhat.com> је
написао/ла:
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> User-mode does not need the sytem tools.
system
> Do not build them by
> default if user specified --disable-system.
specifies
>
> This disables building the following binary on a user-only build:
binaries
>
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
>
> The qemu-user binary is not affected by this change.
binaries are
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
> configure | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 16f94cd96b..d1877a60f5 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
> guest_agent_msi=""
> vss_win32_sdk=""
> win_sdk="no"
> -want_tools="yes"
> +want_tools=""
> libiscsi=""
> libnfs=""
> coroutine=""
> @@ -2199,6 +2199,16 @@ else
> echo big/little test failed
> fi
>
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> + if test "$softmmu" = "no"; then
> + want_tools=no
> + else
> + want_tools=yes
> + fi
> +fi
> +
> ##########################################
> # cocoa implies not SDL or GTK
> # (the cocoa UI code currently assumes it is always the active UI
> --
> 2.21.1
>
[-- Attachment #2: Type: text/html, Size: 2514 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-17 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 9:59 [PATCH v2] configure: Avoid compiling system tools on user build by default Philippe Mathieu-Daudé
2020-02-17 10:04 ` Laurent Vivier
2020-02-17 12:35 ` Aleksandar Markovic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.