Need CRYPTO_CXXFLAGS with latest master?

Need CRYPTO_CXXFLAGS with latest master?

[Noah Watkins]

Pushed changes to Makefile.am in branch:

   wip-make-crypto-flags

Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
test targets. I needed these to build after updating to master this
afternoon.

Not sure if there is something else going on in my environment..

Thanks,
Noah

Re: Need CRYPTO_CXXFLAGS with latest master?

[Noah Watkins]

Whoops, here is the original error:

  CXX    test_idempotent_sequence.o
In file included from ./os/LFNIndex.h:27:0,
                 from ./os/HashIndex.h:20,
                 from ./os/IndexManager.h:26,
                 from ./os/ObjectMap.h:18,
                 from ./os/ObjectStore.h:22,
                 from ./os/FileStore.h:32,
                 from test/filestore/test_idempotent_sequence.cc:22:
./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
compilation terminated.
  CXX    DeterministicOpSequence.o
In file included from ./os/LFNIndex.h:27:0,
                 from ./os/HashIndex.h:20,
                 from ./os/IndexManager.h:26,
                 from ./os/ObjectMap.h:18,
                 from ./os/ObjectStore.h:22,
                 from ./os/FileStore.h:32,
                 from test/filestore/DeterministicOpSequence.cc:21:
./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
compilation terminated.


On Wed, Oct 31, 2012 at 6:27 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
> Pushed changes to Makefile.am in branch:
>
>    wip-make-crypto-flags
>
> Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
> test targets. I needed these to build after updating to master this
> afternoon.
>
> Not sure if there is something else going on in my environment..
>
> Thanks,
> Noah

Re: Need CRYPTO_CXXFLAGS with latest master?

[Gary Lowell]

Hi Noah -

What platform are you building on, and are you building with nss or  cryptopp ?

Thanks,
Gary

On Oct 31, 2012, at 8:22 PM, Noah Watkins wrote:

> Whoops, here is the original error:
> 
>  CXX    test_idempotent_sequence.o
> In file included from ./os/LFNIndex.h:27:0,
>                 from ./os/HashIndex.h:20,
>                 from ./os/IndexManager.h:26,
>                 from ./os/ObjectMap.h:18,
>                 from ./os/ObjectStore.h:22,
>                 from ./os/FileStore.h:32,
>                 from test/filestore/test_idempotent_sequence.cc:22:
> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
> compilation terminated.
>  CXX    DeterministicOpSequence.o
> In file included from ./os/LFNIndex.h:27:0,
>                 from ./os/HashIndex.h:20,
>                 from ./os/IndexManager.h:26,
>                 from ./os/ObjectMap.h:18,
>                 from ./os/ObjectStore.h:22,
>                 from ./os/FileStore.h:32,
>                 from test/filestore/DeterministicOpSequence.cc:21:
> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
> compilation terminated.
> 
> 
> On Wed, Oct 31, 2012 at 6:27 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>> Pushed changes to Makefile.am in branch:
>> 
>>   wip-make-crypto-flags
>> 
>> Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
>> test targets. I needed these to build after updating to master this
>> afternoon.
>> 
>> Not sure if there is something else going on in my environment..
>> 
>> Thanks,
>> Noah
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Need CRYPTO_CXXFLAGS with latest master?

[Noah Watkins]

I guess I'm going to have to retract this problem, as I can't
reproduce it today. No clue what happened :)

On Thu, Nov 1, 2012 at 12:05 PM, Gary Lowell <gary.lowell@inktank.com> wrote:
> Hi Noah -
>
> What platform are you building on, and are you building with nss or  cryptopp ?
>
> Thanks,
> Gary
>
> On Oct 31, 2012, at 8:22 PM, Noah Watkins wrote:
>
>> Whoops, here is the original error:
>>
>>  CXX    test_idempotent_sequence.o
>> In file included from ./os/LFNIndex.h:27:0,
>>                 from ./os/HashIndex.h:20,
>>                 from ./os/IndexManager.h:26,
>>                 from ./os/ObjectMap.h:18,
>>                 from ./os/ObjectStore.h:22,
>>                 from ./os/FileStore.h:32,
>>                 from test/filestore/test_idempotent_sequence.cc:22:
>> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
>> compilation terminated.
>>  CXX    DeterministicOpSequence.o
>> In file included from ./os/LFNIndex.h:27:0,
>>                 from ./os/HashIndex.h:20,
>>                 from ./os/IndexManager.h:26,
>>                 from ./os/ObjectMap.h:18,
>>                 from ./os/ObjectStore.h:22,
>>                 from ./os/FileStore.h:32,
>>                 from test/filestore/DeterministicOpSequence.cc:21:
>> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
>> compilation terminated.
>>
>>
>> On Wed, Oct 31, 2012 at 6:27 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>>> Pushed changes to Makefile.am in branch:
>>>
>>>   wip-make-crypto-flags
>>>
>>> Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
>>> test targets. I needed these to build after updating to master this
>>> afternoon.
>>>
>>> Not sure if there is something else going on in my environment..
>>>
>>> Thanks,
>>> Noah
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: Need CRYPTO_CXXFLAGS with latest master?

[Gary Lowell]

Let me know if you see the problem again.  It's probably something in the autotools dependencies resolution.

Cheers,
Gary


On Nov 1, 2012, at 8:54 PM, Noah Watkins wrote:

> I guess I'm going to have to retract this problem, as I can't
> reproduce it today. No clue what happened :)
> 
> On Thu, Nov 1, 2012 at 12:05 PM, Gary Lowell <gary.lowell@inktank.com> wrote:
>> Hi Noah -
>> 
>> What platform are you building on, and are you building with nss or  cryptopp ?
>> 
>> Thanks,
>> Gary
>> 
>> On Oct 31, 2012, at 8:22 PM, Noah Watkins wrote:
>> 
>>> Whoops, here is the original error:
>>> 
>>> CXX    test_idempotent_sequence.o
>>> In file included from ./os/LFNIndex.h:27:0,
>>>                from ./os/HashIndex.h:20,
>>>                from ./os/IndexManager.h:26,
>>>                from ./os/ObjectMap.h:18,
>>>                from ./os/ObjectStore.h:22,
>>>                from ./os/FileStore.h:32,
>>>                from test/filestore/test_idempotent_sequence.cc:22:
>>> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
>>> compilation terminated.
>>> CXX    DeterministicOpSequence.o
>>> In file included from ./os/LFNIndex.h:27:0,
>>>                from ./os/HashIndex.h:20,
>>>                from ./os/IndexManager.h:26,
>>>                from ./os/ObjectMap.h:18,
>>>                from ./os/ObjectStore.h:22,
>>>                from ./os/FileStore.h:32,
>>>                from test/filestore/DeterministicOpSequence.cc:21:
>>> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
>>> compilation terminated.
>>> 
>>> 
>>> On Wed, Oct 31, 2012 at 6:27 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>>>> Pushed changes to Makefile.am in branch:
>>>> 
>>>>  wip-make-crypto-flags
>>>> 
>>>> Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
>>>> test targets. I needed these to build after updating to master this
>>>> afternoon.
>>>> 
>>>> Not sure if there is something else going on in my environment..
>>>> 
>>>> Thanks,
>>>> Noah
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 

Re: Need CRYPTO_CXXFLAGS with latest master?

[Gary Lowell]

Looks like the complaints come from a small number of newish programs that are compiled only when the --with-debug flag is given.  When building against cryptpp (--with-cryptpp) the pk11 headers are found implicitly and  when building agains libnss (--with-nss) they are not.

So we probably need the changes in your wip-make-crypto-flags branch.

Cheers,
Gary

On Oct 31, 2012, at 8:22 PM, Noah Watkins wrote:

> Whoops, here is the original error:
> 
>  CXX    test_idempotent_sequence.o
> In file included from ./os/LFNIndex.h:27:0,
>                 from ./os/HashIndex.h:20,
>                 from ./os/IndexManager.h:26,
>                 from ./os/ObjectMap.h:18,
>                 from ./os/ObjectStore.h:22,
>                 from ./os/FileStore.h:32,
>                 from test/filestore/test_idempotent_sequence.cc:22:
> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
> compilation terminated.
>  CXX    DeterministicOpSequence.o
> In file included from ./os/LFNIndex.h:27:0,
>                 from ./os/HashIndex.h:20,
>                 from ./os/IndexManager.h:26,
>                 from ./os/ObjectMap.h:18,
>                 from ./os/ObjectStore.h:22,
>                 from ./os/FileStore.h:32,
>                 from test/filestore/DeterministicOpSequence.cc:21:
> ./common/ceph_crypto.h:44:22: fatal error: pk11pub.h: No such file or directory
> compilation terminated.
> 
> 
> On Wed, Oct 31, 2012 at 6:27 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>> Pushed changes to Makefile.am in branch:
>> 
>>   wip-make-crypto-flags
>> 
>> Several changes to Makefile.am that add CRYPTO_CXXFLAGS to various
>> test targets. I needed these to build after updating to master this
>> afternoon.
>> 
>> Not sure if there is something else going on in my environment..
>> 
>> Thanks,
>> Noah
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Need CRYPTO_CXXFLAGS with latest master?

[Noah Watkins]

On Fri, Nov 2, 2012 at 6:04 PM, Gary Lowell <gary.lowell@inktank.com> wrote:
> Looks like the complaints come from a small number of newish programs that are compiled only when the --with-debug flag is given.  When building against cryptpp (--with-cryptpp) the pk11 headers are found implicitly and  when building agains libnss (--with-nss) they are not.
>
> So we probably need the changes in your wip-make-crypto-flags branch.

Ahh that makes sense. Now I can reproduce it. The branch is up at
wip-crypto-flags. Seems like we should have ./configure blow up too if
it can't find this stuff?

- Noah

Re: Need CRYPTO_CXXFLAGS with latest master?

[Gary Lowell]

Digging a little bit deeper, there is actually a comment in common/ceph_crypto.h that when using libnss you need the CRYPTO_CXFLAGS.  Since the pk11 headers are installed, I'm not sure there is problem we could detect.

This may be related to dmick's question about include paths.  Someone who knows more history will have to answer that.

Cheers,
Gary



On Nov 2, 2012, at 7:21 PM, Noah Watkins wrote:

> On Fri, Nov 2, 2012 at 6:04 PM, Gary Lowell <gary.lowell@inktank.com> wrote:
>> Looks like the complaints come from a small number of newish programs that are compiled only when the --with-debug flag is given.  When building against cryptpp (--with-cryptpp) the pk11 headers are found implicitly and  when building agains libnss (--with-nss) they are not.
>> 
>> So we probably need the changes in your wip-make-crypto-flags branch.
> 
> Ahh that makes sense. Now I can reproduce it. The branch is up at
> wip-crypto-flags. Seems like we should have ./configure blow up too if
> it can't find this stuff?
> 
> - Noah

Re: Need CRYPTO_CXXFLAGS with latest master?

[Sage Weil]

On Fri, 2 Nov 2012, Gary Lowell wrote:
> Digging a little bit deeper, there is actually a comment in 
> common/ceph_crypto.h that when using libnss you need the CRYPTO_CXFLAGS.  
> Since the pk11 headers are installed, I'm not sure there is problem we 
> could detect.

Let's add the flags to all of our builds.  Is it possible to include them 
in AM_CXXFLAGS or something insetad of adding it to every target's 
CXXFLAGS?

sage

> This may be related to dmick's question about include paths.  Someone 
> who knows more history will have to answer that.
> 
> Cheers,
> Gary
> 
> 
> 
> On Nov 2, 2012, at 7:21 PM, Noah Watkins wrote:
> 
> > On Fri, Nov 2, 2012 at 6:04 PM, Gary Lowell <gary.lowell@inktank.com> wrote:
> >> Looks like the complaints come from a small number of newish programs that are compiled only when the --with-debug flag is given.  When building against cryptpp (--with-cryptpp) the pk11 headers are found implicitly and  when building agains libnss (--with-nss) they are not.
> >> 
> >> So we probably need the changes in your wip-make-crypto-flags branch.
> > 
> > Ahh that makes sense. Now I can reproduce it. The branch is up at
> > wip-crypto-flags. Seems like we should have ./configure blow up too if
> > it can't find this stuff?
> > 
> > - Noah
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>