* [PATCH] plugins: Add missing 'qemu/qht.h' header
@ 2021-05-24 16:52 Philippe Mathieu-Daudé
2021-06-14 11:17 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-24 16:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Alex Bennée, Philippe Mathieu-Daudé
When building a plugin we get:
cc ... -c ../plugins/api.c
In file included from ../plugins/api.c:43:
../plugins/plugin.h:45:16: error: field 'dyn_cb_arr_ht' has incomplete type
struct qht dyn_cb_arr_ht;
^~~~~~~~~~~~~
Since we expect all headers to be self-contained, add the missing
"qemu/qht.h" to avoid other developers to hit the same problem.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
plugins/plugin.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/plugin.h b/plugins/plugin.h
index 1aa29dcaddf..55017e35819 100644
--- a/plugins/plugin.h
+++ b/plugins/plugin.h
@@ -13,6 +13,7 @@
#define _PLUGIN_INTERNAL_H_
#include <gmodule.h>
+#include "qemu/qht.h"
#define QEMU_PLUGIN_MIN_VERSION 0
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] plugins: Add missing 'qemu/qht.h' header
2021-05-24 16:52 [PATCH] plugins: Add missing 'qemu/qht.h' header Philippe Mathieu-Daudé
@ 2021-06-14 11:17 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-14 11:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Alex Bennée
FWIW this patch has been merged as part of commit 824f4bac9ff
("accel/tcg: Reduce 'exec/tb-context.h' inclusion").
On 5/24/21 6:52 PM, Philippe Mathieu-Daudé wrote:
> When building a plugin we get:
>
> cc ... -c ../plugins/api.c
> In file included from ../plugins/api.c:43:
> ../plugins/plugin.h:45:16: error: field 'dyn_cb_arr_ht' has incomplete type
> struct qht dyn_cb_arr_ht;
> ^~~~~~~~~~~~~
>
> Since we expect all headers to be self-contained, add the missing
> "qemu/qht.h" to avoid other developers to hit the same problem.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> plugins/plugin.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/plugins/plugin.h b/plugins/plugin.h
> index 1aa29dcaddf..55017e35819 100644
> --- a/plugins/plugin.h
> +++ b/plugins/plugin.h
> @@ -13,6 +13,7 @@
> #define _PLUGIN_INTERNAL_H_
>
> #include <gmodule.h>
> +#include "qemu/qht.h"
>
> #define QEMU_PLUGIN_MIN_VERSION 0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-14 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 16:52 [PATCH] plugins: Add missing 'qemu/qht.h' header Philippe Mathieu-Daudé
2021-06-14 11:17 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.