All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Mesa3d-dev] [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
       [not found] <1266791605-22944-1-git-send-email-keithp@keithp.com>
@ 2010-02-22  0:54 ` Dan Nicholson
  2010-02-22 15:17   ` Brian Paul
  2010-02-22 15:16 ` Brian Paul
  1 sibling, 1 reply; 6+ messages in thread
From: Dan Nicholson @ 2010-02-22  0:54 UTC (permalink / raw)
  To: Keith Packard; +Cc: dri-devel, mesa3d-dev

On Sun, Feb 21, 2010 at 2:33 PM, Keith Packard <keithp@keithp.com> wrote:
> The bash 'cd' command tends to emit random stuff to stdout when the
> CDPATH variable is set, so clear it to keep extra filenames from being
> emitted from the expand_archive function, which would otherwise cause
> mklib to fail.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>

Congratulations on wading in to mklib, it's not a friendly place. :)

Reviewed-by: Dan Nicholson <dbn.lists@gmail.com>

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
       [not found] <1266791605-22944-1-git-send-email-keithp@keithp.com>
  2010-02-22  0:54 ` [Mesa3d-dev] [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output Dan Nicholson
@ 2010-02-22 15:16 ` Brian Paul
  2010-02-22 18:50   ` Keith Packard
  1 sibling, 1 reply; 6+ messages in thread
From: Brian Paul @ 2010-02-22 15:16 UTC (permalink / raw)
  To: Keith Packard; +Cc: dri-devel, mesa3d-dev

On Sun, Feb 21, 2010 at 3:33 PM, Keith Packard <keithp@keithp.com> wrote:
> The bash 'cd' command tends to emit random stuff to stdout when the
> CDPATH variable is set, so clear it to keep extra filenames from being
> emitted from the expand_archive function, which would otherwise cause
> mklib to fail.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>

Signed-off-by: Brian Paul <brianp@vmware.com>


Please commit to both master and mesa_7_7_branch.  Thanks.

-Brian

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
  2010-02-22  0:54 ` [Mesa3d-dev] [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output Dan Nicholson
@ 2010-02-22 15:17   ` Brian Paul
  2010-02-22 15:42     ` Daniel Stone
  2010-02-22 16:27     ` Dan Nicholson
  0 siblings, 2 replies; 6+ messages in thread
From: Brian Paul @ 2010-02-22 15:17 UTC (permalink / raw)
  To: Dan Nicholson; +Cc: dri-devel, mesa3d-dev

On Sun, Feb 21, 2010 at 5:54 PM, Dan Nicholson <dbn.lists@gmail.com> wrote:
> On Sun, Feb 21, 2010 at 2:33 PM, Keith Packard <keithp@keithp.com> wrote:
>> The bash 'cd' command tends to emit random stuff to stdout when the
>> CDPATH variable is set, so clear it to keep extra filenames from being
>> emitted from the expand_archive function, which would otherwise cause
>> mklib to fail.
>>
>> Signed-off-by: Keith Packard <keithp@keithp.com>
>
> Congratulations on wading in to mklib, it's not a friendly place. :)

Heh, I guess you've never had to debug libtool then.  mklib is a walk
in the park by comparison.

-Brian

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
  2010-02-22 15:17   ` Brian Paul
@ 2010-02-22 15:42     ` Daniel Stone
  2010-02-22 16:27     ` Dan Nicholson
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Stone @ 2010-02-22 15:42 UTC (permalink / raw)
  To: Brian Paul; +Cc: dri-devel, mesa3d-dev


[-- Attachment #1.1: Type: text/plain, Size: 931 bytes --]

On Mon, Feb 22, 2010 at 08:17:31AM -0700, Brian Paul wrote:
> On Sun, Feb 21, 2010 at 5:54 PM, Dan Nicholson <dbn.lists@gmail.com> wrote:
> > On Sun, Feb 21, 2010 at 2:33 PM, Keith Packard <keithp@keithp.com> wrote:
> >> The bash 'cd' command tends to emit random stuff to stdout when the
> >> CDPATH variable is set, so clear it to keep extra filenames from being
> >> emitted from the expand_archive function, which would otherwise cause
> >> mklib to fail.
> >>
> >> Signed-off-by: Keith Packard <keithp@keithp.com>
> >
> > Congratulations on wading in to mklib, it's not a friendly place. :)
> 
> Heh, I guess you've never had to debug libtool then.  mklib is a walk
> in the park by comparison.

In fairness though, I haven't had to debug libtool for several years
now, because it always seems to work, whereas mklib seems to encounter
new and exciting failures all the time.  Oh well. :)

Cheers,
Daniel

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
  2010-02-22 15:17   ` Brian Paul
  2010-02-22 15:42     ` Daniel Stone
@ 2010-02-22 16:27     ` Dan Nicholson
  1 sibling, 0 replies; 6+ messages in thread
From: Dan Nicholson @ 2010-02-22 16:27 UTC (permalink / raw)
  To: Brian Paul; +Cc: dri-devel, mesa3d-dev

On Mon, Feb 22, 2010 at 7:17 AM, Brian Paul <brian.e.paul@gmail.com> wrote:
> On Sun, Feb 21, 2010 at 5:54 PM, Dan Nicholson <dbn.lists@gmail.com> wrote:
>> On Sun, Feb 21, 2010 at 2:33 PM, Keith Packard <keithp@keithp.com> wrote:
>>> The bash 'cd' command tends to emit random stuff to stdout when the
>>> CDPATH variable is set, so clear it to keep extra filenames from being
>>> emitted from the expand_archive function, which would otherwise cause
>>> mklib to fail.
>>>
>>> Signed-off-by: Keith Packard <keithp@keithp.com>
>>
>> Congratulations on wading in to mklib, it's not a friendly place. :)
>
> Heh, I guess you've never had to debug libtool then.  mklib is a walk
> in the park by comparison.

Sorry, didn't mean to imply that it's simplicity is not a virtue. On
the other hand, it doesn't get a ton of love, so it tends to be pretty
incoherent. libtool debugging is an absolute nightmare, but thankfully
it's been a long time since most people had to deal with that.

--
Dan

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output
  2010-02-22 15:16 ` Brian Paul
@ 2010-02-22 18:50   ` Keith Packard
  0 siblings, 0 replies; 6+ messages in thread
From: Keith Packard @ 2010-02-22 18:50 UTC (permalink / raw)
  To: Brian Paul; +Cc: dri-devel, mesa3d-dev


[-- Attachment #1.1: Type: text/plain, Size: 142 bytes --]


> Please commit to both master and mesa_7_7_branch.  Thanks.

mesa_7_7_branch doesn't use 'cd' in mklib.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-02-22 18:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1266791605-22944-1-git-send-email-keithp@keithp.com>
2010-02-22  0:54 ` [Mesa3d-dev] [PATCH] bin/mklib: Clear CDPATH to avoid damaging expand_archive output Dan Nicholson
2010-02-22 15:17   ` Brian Paul
2010-02-22 15:42     ` Daniel Stone
2010-02-22 16:27     ` Dan Nicholson
2010-02-22 15:16 ` Brian Paul
2010-02-22 18:50   ` Keith Packard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.