From: Chao Yu <yuchao0@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Gao Xiang <hsiangkao@aol.com>,
Pavel Zemlyanoy <zemlyanoy@ispras.ru>,
<ldv-project@linuxtesting.org>, <devel@driverdev.osuosl.org>,
<linux-erofs@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison
Date: Mon, 3 Sep 2018 09:59:43 +0800 [thread overview]
Message-ID: <9172e7b7-ff42-85ca-f546-a369b8698d27@huawei.com> (raw)
In-Reply-To: <20180831094106.sxwsd5v2mmn3cux6@mwanda>
On 2018/8/31 17:41, Dan Carpenter wrote:
> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>
>> Hi Xiang,
>>
>> I'm not against this change which follows checkpatch's rule, since I think this
>> can help to unify coding style in different modules of Linux. Maybe cleanup in
>> other filesystem is needed as well.
>>
>
> That code is old, and those filesystems are not in staging so we're not
> going to change them.
Yup, anyway, it can be decided by their maintainer if they want the cleanup.
>
> Let's just apply the patch and not spend any time thinking about it.
> Part of the point of style guidelines is so that we don't have to
> repeat all these discussions over and over...
>
> Btw, I have a rename_rev.pl patch for reviewing these. I've attached
> it. rename_rev.pl -r NULL. I've seen some people screw up the
> conversion so having an automated review is nice.
Cool, thanks very much for providing this tools, it actually can help to save
some time during review. :)
>
> regards,
> dan carpenter
>
WARNING: multiple messages have this Message-ID (diff)
From: yuchao0@huawei.com (Chao Yu)
Subject: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison
Date: Mon, 3 Sep 2018 09:59:43 +0800 [thread overview]
Message-ID: <9172e7b7-ff42-85ca-f546-a369b8698d27@huawei.com> (raw)
In-Reply-To: <20180831094106.sxwsd5v2mmn3cux6@mwanda>
On 2018/8/31 17:41, Dan Carpenter wrote:
> On Fri, Aug 31, 2018@11:29:03AM +0800, Chao Yu wrote:
>>
>> Hi Xiang,
>>
>> I'm not against this change which follows checkpatch's rule, since I think this
>> can help to unify coding style in different modules of Linux. Maybe cleanup in
>> other filesystem is needed as well.
>>
>
> That code is old, and those filesystems are not in staging so we're not
> going to change them.
Yup, anyway, it can be decided by their maintainer if they want the cleanup.
>
> Let's just apply the patch and not spend any time thinking about it.
> Part of the point of style guidelines is so that we don't have to
> repeat all these discussions over and over...
>
> Btw, I have a rename_rev.pl patch for reviewing these. I've attached
> it. rename_rev.pl -r NULL. I've seen some people screw up the
> conversion so having an automated review is nice.
Cool, thanks very much for providing this tools, it actually can help to save
some time during review. :)
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2018-09-03 1:59 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 15:13 [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c Pavel Zemlyanoy
2018-08-30 15:13 ` Pavel Zemlyanoy
2018-08-30 15:13 ` [PATCH 2/6] staging: erofs: formatting fix to NULL comparison Pavel Zemlyanoy
2018-08-30 15:13 ` Pavel Zemlyanoy
2018-08-30 16:09 ` Gao Xiang
2018-08-30 16:09 ` Gao Xiang
2018-08-30 16:32 ` Gao Xiang
2018-08-30 16:32 ` Gao Xiang
2018-08-31 3:29 ` Chao Yu
2018-08-31 3:29 ` Chao Yu
2018-08-31 9:41 ` Dan Carpenter
2018-08-31 9:41 ` Dan Carpenter
2018-09-03 1:59 ` Chao Yu [this message]
2018-09-03 1:59 ` Chao Yu
2018-09-03 4:23 ` Gao Xiang
2018-09-03 4:23 ` Gao Xiang
2018-09-03 1:48 ` Chao Yu
2018-09-03 1:48 ` Chao Yu
2018-08-30 15:13 ` [PATCH 3/6] staging: erofs: formatting spaces around '-' Pavel Zemlyanoy
2018-08-30 15:13 ` Pavel Zemlyanoy
2018-09-03 1:48 ` Chao Yu
2018-09-03 1:48 ` Chao Yu
2018-09-03 4:32 ` Gao Xiang
2018-09-03 4:32 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 4/6] staging: erofs: formatting add spaces arround '*' Pavel Zemlyanoy
2018-08-30 15:14 ` Pavel Zemlyanoy
2018-09-03 1:48 ` Chao Yu
2018-09-03 1:48 ` Chao Yu
2018-09-03 4:33 ` Gao Xiang
2018-09-03 4:33 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 5/6] staging: erofs: formatting alignment parenthesis Pavel Zemlyanoy
2018-08-30 15:14 ` Pavel Zemlyanoy
2018-09-03 1:49 ` Chao Yu
2018-09-03 1:49 ` Chao Yu
2018-09-03 4:43 ` Gao Xiang
2018-09-03 4:43 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 6/6] staging: erofs: fix 1 warning and 9 checks Pavel Zemlyanoy
2018-08-30 15:14 ` Pavel Zemlyanoy
2018-09-03 1:49 ` Chao Yu
2018-09-03 1:49 ` Chao Yu
2018-09-03 4:50 ` Gao Xiang
2018-09-03 4:50 ` Gao Xiang
2018-09-03 1:47 ` [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c Chao Yu
2018-09-03 1:47 ` Chao Yu
2018-09-03 4:30 ` Gao Xiang
2018-09-03 4:30 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9172e7b7-ff42-85ca-f546-a369b8698d27@huawei.com \
--to=yuchao0@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsiangkao@aol.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zemlyanoy@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.