Xen 4.9 rc6

Xen 4.9 rc6

[Julien Grall]

Hi all,

Xen 4.9 rc6 is tagged. You can check that out from xen.git:

 git://xenbits.xen.org/xen.git 4.9.0-rc6

For your convenience there is also a tarball at:
https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz

And the signature is at:
https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz.sig

Please send bug reports and test reports to xen-devel@lists.xenproject.org.
When sending bug reports, please CC relevant maintainers and me (julien.grall@arm.com).

We are aware of bugs below:
	- Recent patches introduced a regression in the build. Some targets
	(e.g install-tools) will not install the headers. A patch has been sent
	on the mailing list (see [1]). A known workaround is to call `make`.
	- HVM_set_hvm_param and HVMOP_flush_tlbs may fail if requiring continuation.
	A patch has been sent on the mailing list (see [2]).


As a reminder, there will be another Xen Test Day tomorrow (Tuesday 23th May),
for the instructions see:

https://blog.xenproject.org/2017/04/13/announcing-xen-project-4-9-rc-and-test-day-schedule/

Cheers,

[1] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02165.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02108.html

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6

[M A Young]

On Mon, 22 May 2017, Julien Grall wrote:

> Hi all,
> 
> Xen 4.9 rc6 is tagged. You can check that out from xen.git:
> 
>  git://xenbits.xen.org/xen.git 4.9.0-rc6
> 
> For your convenience there is also a tarball at:
> https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz
> 
> And the signature is at:
> https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz.sig
> 
> Please send bug reports and test reports to xen-devel@lists.xenproject.org.
> When sending bug reports, please CC relevant maintainers and me (julien.grall@arm.com).
> 
> We are aware of bugs below:
> 	- Recent patches introduced a regression in the build. Some targets
> 	(e.g install-tools) will not install the headers. A patch has been sent
> 	on the mailing list (see [1]). A known workaround is to call `make`.
> 	- HVM_set_hvm_param and HVMOP_flush_tlbs may fail if requiring continuation.
> 	A patch has been sent on the mailing list (see [2]).
> 
> 
> As a reminder, there will be another Xen Test Day tomorrow (Tuesday 23th May),
> for the instructions see:
> 
> https://blog.xenproject.org/2017/04/13/announcing-xen-project-4-9-rc-and-test-day-schedule/
> 
> Cheers,
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02165.html
> [2] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02108.html

I had build problems with these two patches added (and before I added 
them). It looks like at the stage in my build process where
make -j2 prefix=/usr tools
gets run it is running
make -C tools/include install
make -C tools/include dist
together and it fails soon after when the alignment checks run at the same 
time.

The full build log is at
https://copr-be.cloud.fedoraproject.org/results/myoung/xentest/fedora-26-x86_64/00555373-xen/build.log.gz

	Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6

[Julien Grall]

(CC Andrew and Ian)

On 23/05/17 10:24, M A Young wrote:
> On Mon, 22 May 2017, Julien Grall wrote:
>
>> Hi all,
>>
>> Xen 4.9 rc6 is tagged. You can check that out from xen.git:
>>
>>  git://xenbits.xen.org/xen.git 4.9.0-rc6
>>
>> For your convenience there is also a tarball at:
>> https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz
>>
>> And the signature is at:
>> https://downloads.xenproject.org/release/xen/4.9.0-rc6/xen-4.9.0-rc6.tar.gz.sig
>>
>> Please send bug reports and test reports to xen-devel@lists.xenproject.org.
>> When sending bug reports, please CC relevant maintainers and me (julien.grall@arm.com).
>>
>> We are aware of bugs below:
>> 	- Recent patches introduced a regression in the build. Some targets
>> 	(e.g install-tools) will not install the headers. A patch has been sent
>> 	on the mailing list (see [1]). A known workaround is to call `make`.
>> 	- HVM_set_hvm_param and HVMOP_flush_tlbs may fail if requiring continuation.
>> 	A patch has been sent on the mailing list (see [2]).
>>
>>
>> As a reminder, there will be another Xen Test Day tomorrow (Tuesday 23th May),
>> for the instructions see:
>>
>> https://blog.xenproject.org/2017/04/13/announcing-xen-project-4-9-rc-and-test-day-schedule/
>>
>> Cheers,
>>
>> [1] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02165.html
>> [2] https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02108.html
>
> I had build problems with these two patches added (and before I added
> them). It looks like at the stage in my build process where
> make -j2 prefix=/usr tools
> gets run it is running
> make -C tools/include install
> make -C tools/include dist
> together and it fails soon after when the alignment checks run at the same
> time.
>
> The full build log is at
> https://copr-be.cloud.fedoraproject.org/results/myoung/xentest/fedora-26-x86_64/00555373-xen/build.log.gz
>
> 	Michael Young
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6

[Ian Jackson]

Julien Grall writes ("Re: [Xen-devel] Xen 4.9 rc6"):
> On 23/05/17 10:24, M A Young wrote:
> > I had build problems with these two patches added (and before I added
> > them). It looks like at the stage in my build process where
> > make -j2 prefix=/usr tools
> > gets run it is running
> > make -C tools/include install
> > make -C tools/include dist
> > together and it fails soon after when the alignment checks run at the same
> > time.

I think this is happening because, in xen.git/Makeefile:

   dist-tools: dist-tools-public-headers

   dist-%: DESTDIR=$(DISTDIR)/install
   dist-%: install-%
           @: # do nothing

   install-tools: build-tools-public-headers

So make thinks it can try to `build' the targets
build-tools-public-headers and dist-tools-public-headers
simultaneously.

The problem here is that
 1. /Makefile needs to invoke each subdirectory exactly
    once, not multiple times, or they come in parallel
 2. /Makefile is (now) confused about when it should
    handle the relationship between different targets for
    the same subcomponent, and when the subdirectory
    Makefile is supposed to do that.

The rule for (2) used to be:
  /Makefile converts  make dist  to  DESTDIR=... make install
  for all other targets, /Makefile's make <target>-<subdir>
  passes the <target> to <subdir> and does not consider
  what <target> might mean and whether it ought to imply
  some other targets in subdir.

I think therefore that maybe this can fixed by:

  * Dropping the `dist-tools' dependency on dist-tools-p.-h.

  * Replacing the `install-tools' dependency by one on
    install-tools-p-h.

  * Replacing the rules for *-public-headers with something
    like

        %-tools-public-headers:
            $(MAKE) -C tools/include $*

Does this sound plausible ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6

[Ian Jackson]

I'm about to post a pair of patches, against staging, which I think
fix this problem.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH for-4.9 1/2] tools/include/Makefile: Support `build' target

[Ian Jackson]

This is the only one of the Makefiles invoked with -C from the
toplevel which lacks this target.

CC: Julien Grall <julien.grall@arm.com>
CC: M A Young <m.a.young@durham.ac.uk>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 tools/include/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/include/Makefile b/tools/include/Makefile
index 98b479f..db0f030 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -4,8 +4,8 @@ include $(XEN_ROOT)/tools/Rules.mk
 # Relative to $(XEN_ROOT)/xen/xsm/flask
 FLASK_H_DEPEND := policy/initial_sids
 
-.PHONY: all
-all: xen-foreign xen/.dir xen-xsm/.dir
+.PHONY: all build
+all build: xen-foreign xen/.dir xen-xsm/.dir
 
 .PHONY: xen-foreign
 xen-foreign:
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Ian Jackson]

Recent changes to this Makefile have broken some build targets, and
some parallel builds.

Looking at it, I think I have identified the undocumented design
intent in the top-level Makefile.  So in this patch I document it, and
also make it true.

In detail:

 * Add a comment with the new design intent
 * Get rid of the ad-hoc rules for recursing into tools/include,
   and replace them with a pattern rule
 * Add an appropriate dependency on TARGET-tools-public-headers from
   TARGET-tools and TARGET-stubdom (but not dist-*).
 * Get rid of all the separate invocations of $(MAKE) -C tools/include
   which are now obsolete
 * Un-deprecate the simple `tools' etc. targets (aliases for `dist-tools')
   which we seem not to be making any effort to get rid of

I have verified with the following shell script that after my change,
the tree producese the same results for various build targets as
3fafdc28eb98 (before the Makefile-hacking started).

My tests failed as expected for make -C tools, both before and after.

Separately, there is a bug in the Makefiles that `make distclean-tools'
fails.  I have not investigated that bug in detail.

    #!/bin/bash

    set -e
    set -o pipefail

    listings=../listings

    rm -rf $listings
    mkdir $listings

    chks () {
         reskey="C$subdir $*"
         reskey="${reskey// /_}"
         reskey="${reskey//\//:}"
         lk=$listings/$reskey
         for suffix in '' -xen -tools -stubdom -docs; do
             case "$subdir:$suffix" in
             .:*) ;;
             *:) ;;
             *) continue;;
             esac
             git clean -qxdff
             rm -rf $output
             printf '%s' "running -C$subdir suffix=$suffix "
             case "$subdir $suffix" in
             *xen*) ;;
             *) printf 'configure '; ./configure >$lk.cfg 2>&1 ;;
             esac
             fail=''
             for targ in $*; do
                 realtarg=$targ$suffix
                 printf '%s ' "$realtarg"
                 if ! make -C $subdir -j10 $realtarg >${lk}_${realtarg}.log 2>&1
                 then
                    fail=$realtarg
                    break
                 fi
             done
             if [ "$fail" ]; then
               echo fail!
               echo "$fail failed" >$lk.list
             else
               echo ok.
               (test ! -e "$output" || find $output) |sort >$lk.list
             fi
        done
    }

    subdirs='. xen docs tools'

    output=$PWD/dist
    for subdir in $subdirs; do
        chks build clean distclean
    done

    output=$PWD/dist
    subdir=.
    chks dist

    export DESTDIR=$PWD/destdir
    output=$PWD/destdir
    for subdir in $subdirs; do
        chks install
    done

And the output:

    (64)iwj@mariner:~/work/xen.git$ ~/junk/chks
    running -C. suffix= configure build clean distclean ok.
    running -C. suffix=-xen build-xen clean-xen distclean-xen ok.
    running -C. suffix=-tools configure build-tools clean-tools distclean-tools fail!
    running -C. suffix=-stubdom configure build-stubdom clean-stubdom distclean-stubdom ok.
    running -C. suffix=-docs configure build-docs clean-docs distclean-docs ok.
    running -Cxen suffix= build clean distclean ok.
    running -Cdocs suffix= configure build clean distclean ok.
    running -Ctools suffix= configure build fail!
    running -C. suffix= configure dist ok.
    running -C. suffix=-xen dist-xen ok.
    running -C. suffix=-tools configure dist-tools ok.
    running -C. suffix=-stubdom configure dist-stubdom ok.
    running -C. suffix=-docs configure dist-docs ok.
    running -C. suffix= configure install ok.
    running -C. suffix=-xen install-xen ok.
    running -C. suffix=-tools configure install-tools ok.
    running -C. suffix=-stubdom configure install-stubdom ok.
    running -C. suffix=-docs configure install-docs ok.
    running -Cxen suffix= install ok.
    running -Cdocs suffix= configure install ok.
    running -Ctools suffix= configure install fail!
    (64)iwj@mariner:~/work/xen.git$

CC: Julien Grall <julien.grall@arm.com>
CC: M A Young <m.a.young@durham.ac.uk>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Makefile | 39 +++++++++++++++++++++++----------------
 1 file changed, 23 insertions(+), 16 deletions(-)

diff --git a/Makefile b/Makefile
index fc30b3c..51905eb 100644
--- a/Makefile
+++ b/Makefile
@@ -38,18 +38,13 @@ mini-os-dir-force-update: mini-os-dir
 export XEN_TARGET_ARCH
 export DESTDIR
 
-.PHONY: build-tools-public-headers
-build-tools-public-headers:
-	$(MAKE) -C tools/include
-
-.PHONY: dist-tools-public-headers
-dist-tools-public-headers: build-tools-public-headers
-	$(MAKE) -C tools/include dist
+.PHONY: %-tools-public-headers
+%-tools-public-headers:
+	$(MAKE) -C tools/include $*
 
 # build and install everything into the standard system directories
 .PHONY: install
 install: $(TARGS_INSTALL)
-	$(MAKE) -C tools/include install
 
 .PHONY: build
 build: $(TARGS_BUILD)
@@ -80,7 +75,22 @@ build-docs:
 test:
 	$(MAKE) -C tools/python test
 
-# build and install everything into local dist directory
+# For most targets here,
+#   make COMPONENT-TARGET
+# is implemented, more or less, by
+#   make -C COMPONENT TARGET
+#
+# Each rule that does this needs to have dependencies on any
+# other COMPONENTs that have to be processed first.  See
+# The install-tools target here for an example.
+#
+# dist* targets are special: these do not occur in lower-level
+# Makefiles.  Instead, these are all implemented only here.
+# They run the appropriate install targets with DESTDIR set.
+#
+# Also, we have a number of targets COMPONENT which run
+# dist-COMPONENT, for convenience.
+
 .PHONY: dist
 dist: DESTDIR=$(DISTDIR)/install
 dist: $(TARGS_DIST) dist-misc
@@ -92,12 +102,10 @@ dist-misc:
 	$(INSTALL_PROG) ./install.sh $(DISTDIR)
 
 
-dist-tools: dist-tools-public-headers
 dist-%: DESTDIR=$(DISTDIR)/install
 dist-%: install-%
 	@: # do nothing
 
-# Legacy dist targets
 .PHONY: xen tools stubdom docs
 xen: dist-xen
 tools: dist-tools
@@ -109,11 +117,11 @@ install-xen:
 	$(MAKE) -C xen install
 
 .PHONY: install-tools
-install-tools: build-tools-public-headers
+install-tools: install-tools-public-headers
 	$(MAKE) -C tools install
 
 .PHONY: install-stubdom
-install-stubdom: mini-os-dir build-tools-public-headers
+install-stubdom: mini-os-dir install-tools-public-headers
 	$(MAKE) -C stubdom install
 ifeq (x86_64,$(XEN_TARGET_ARCH))
 	XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom install-grub
@@ -180,18 +188,17 @@ src-tarball: subtree-force-update-all
 
 .PHONY: clean
 clean: $(TARGS_CLEAN)
-	$(MAKE) -C tools/include clean
 
 .PHONY: clean-xen
 clean-xen:
 	$(MAKE) -C xen clean
 
 .PHONY: clean-tools
-clean-tools:
+clean-tools: clean-tools-public-headers
 	$(MAKE) -C tools clean
 
 .PHONY: clean-stubdom
-clean-stubdom:
+clean-stubdom: clean-tools-public-headers
 	$(MAKE) -C stubdom crossclean
 ifeq (x86_64,$(XEN_TARGET_ARCH))
 	XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom crossclean
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Andrew Cooper]

On 24/05/17 17:14, Ian Jackson wrote:
> CC: Julien Grall <julien.grall@arm.com>
> CC: M A Young <m.a.young@durham.ac.uk>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

This resolves all the XenServer build issues I encountered.

Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Michael Young]

On Wed, 24 May 2017, Andrew Cooper wrote:

> On 24/05/17 17:14, Ian Jackson wrote:
>> CC: Julien Grall <julien.grall@arm.com>
>> CC: M A Young <m.a.young@durham.ac.uk>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> This resolves all the XenServer build issues I encountered.
>
> Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

I tried building with both patches and it works for me as well.

 	Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Julien Grall]

On 24/05/17 18:14, Andrew Cooper wrote:
> On 24/05/17 17:14, Ian Jackson wrote:
>> CC: Julien Grall <julien.grall@arm.com>
>> CC: M A Young <m.a.young@durham.ac.uk>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> This resolves all the XenServer build issues I encountered.
>
> Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Julien Grall <julien.grall@arm.com>

>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6 [and 1 more messages]

[Ian Jackson]

Thanks for the test reports and the release-ack.  Ideally I would like
a review but I may not get one.  Julien, or Michael, do you feel
qualified to review this ?

Looking at the REST MAINTAINERS:

I know Andrew, Jan and Konrad are extremely busy right now so I don't
want to ask them to stare at these Makefiles, and Wei is away.

Stefano, do you think you could look ?

If I can't get a review, I do think I should get some kind of ack to
commit it.  An ack from a REST maintainer suffices I think.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6 [and 1 more messages]

[Julien Grall]

Hi Ian,

On 25/05/17 13:42, Ian Jackson wrote:
> Thanks for the test reports and the release-ack.  Ideally I would like
> a review but I may not get one.  Julien, or Michael, do you feel
> qualified to review this ?

My knowledge of the build system is very limited. So I don't think my 
review here will be useful sorry.

>
> Looking at the REST MAINTAINERS:
>
> I know Andrew, Jan and Konrad are extremely busy right now so I don't
> want to ask them to stare at these Makefiles, and Wei is away.
>
> Stefano, do you think you could look ?
>
> If I can't get a review, I do think I should get some kind of ack to
> commit it.  An ack from a REST maintainer suffices I think.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen 4.9 rc6 [and 1 more messages]

[Andrew Cooper]

On 25/05/17 13:55, Julien Grall wrote:
> Hi Ian,
>
> On 25/05/17 13:42, Ian Jackson wrote:
>> Thanks for the test reports and the release-ack.  Ideally I would like
>> a review but I may not get one.  Julien, or Michael, do you feel
>> qualified to review this ?
>
> My knowledge of the build system is very limited. So I don't think my
> review here will be useful sorry.
>
>>
>> Looking at the REST MAINTAINERS:
>>
>> I know Andrew, Jan and Konrad are extremely busy right now so I don't
>> want to ask them to stare at these Makefiles, and Wei is away.
>>
>> Stefano, do you think you could look ?
>>
>> If I can't get a review, I do think I should get some kind of ack to
>> commit it.  An ack from a REST maintainer suffices I think.

If it helps, the arguments look persuasive and the changes appear to
match the arguments.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 1/2] tools/include/Makefile: Support `build' target

[Roger Pau Monné]

On Wed, May 24, 2017 at 05:14:29PM +0100, Ian Jackson wrote:
> This is the only one of the Makefiles invoked with -C from the
> toplevel which lacks this target.
> 
> CC: Julien Grall <julien.grall@arm.com>
> CC: M A Young <m.a.young@durham.ac.uk>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Roger Pau Monné]

On Wed, May 24, 2017 at 05:14:30PM +0100, Ian Jackson wrote:
> Recent changes to this Makefile have broken some build targets, and
> some parallel builds.
> 
> Looking at it, I think I have identified the undocumented design
> intent in the top-level Makefile.  So in this patch I document it, and
> also make it true.
> 
> In detail:
> 
>  * Add a comment with the new design intent
>  * Get rid of the ad-hoc rules for recursing into tools/include,
>    and replace them with a pattern rule
>  * Add an appropriate dependency on TARGET-tools-public-headers from
>    TARGET-tools and TARGET-stubdom (but not dist-*).
>  * Get rid of all the separate invocations of $(MAKE) -C tools/include
>    which are now obsolete
>  * Un-deprecate the simple `tools' etc. targets (aliases for `dist-tools')
>    which we seem not to be making any effort to get rid of
> 
> I have verified with the following shell script that after my change,
> the tree producese the same results for various build targets as
> 3fafdc28eb98 (before the Makefile-hacking started).
> 
> My tests failed as expected for make -C tools, both before and after.
> 
> Separately, there is a bug in the Makefiles that `make distclean-tools'
> fails.  I have not investigated that bug in detail.
> 
>     #!/bin/bash
> 
>     set -e
>     set -o pipefail
> 
>     listings=../listings
> 
>     rm -rf $listings
>     mkdir $listings
> 
>     chks () {
>          reskey="C$subdir $*"
>          reskey="${reskey// /_}"
>          reskey="${reskey//\//:}"
>          lk=$listings/$reskey
>          for suffix in '' -xen -tools -stubdom -docs; do
>              case "$subdir:$suffix" in
>              .:*) ;;
>              *:) ;;
>              *) continue;;
>              esac
>              git clean -qxdff
>              rm -rf $output
>              printf '%s' "running -C$subdir suffix=$suffix "
>              case "$subdir $suffix" in
>              *xen*) ;;
>              *) printf 'configure '; ./configure >$lk.cfg 2>&1 ;;
>              esac
>              fail=''
>              for targ in $*; do
>                  realtarg=$targ$suffix
>                  printf '%s ' "$realtarg"
>                  if ! make -C $subdir -j10 $realtarg >${lk}_${realtarg}.log 2>&1
>                  then
>                     fail=$realtarg
>                     break
>                  fi
>              done
>              if [ "$fail" ]; then
>                echo fail!
>                echo "$fail failed" >$lk.list
>              else
>                echo ok.
>                (test ! -e "$output" || find $output) |sort >$lk.list
>              fi
>         done
>     }
> 
>     subdirs='. xen docs tools'
> 
>     output=$PWD/dist
>     for subdir in $subdirs; do
>         chks build clean distclean
>     done
> 
>     output=$PWD/dist
>     subdir=.
>     chks dist
> 
>     export DESTDIR=$PWD/destdir
>     output=$PWD/destdir
>     for subdir in $subdirs; do
>         chks install
>     done
> 
> And the output:
> 
>     (64)iwj@mariner:~/work/xen.git$ ~/junk/chks
>     running -C. suffix= configure build clean distclean ok.
>     running -C. suffix=-xen build-xen clean-xen distclean-xen ok.
>     running -C. suffix=-tools configure build-tools clean-tools distclean-tools fail!
>     running -C. suffix=-stubdom configure build-stubdom clean-stubdom distclean-stubdom ok.
>     running -C. suffix=-docs configure build-docs clean-docs distclean-docs ok.
>     running -Cxen suffix= build clean distclean ok.
>     running -Cdocs suffix= configure build clean distclean ok.
>     running -Ctools suffix= configure build fail!
>     running -C. suffix= configure dist ok.
>     running -C. suffix=-xen dist-xen ok.
>     running -C. suffix=-tools configure dist-tools ok.
>     running -C. suffix=-stubdom configure dist-stubdom ok.
>     running -C. suffix=-docs configure dist-docs ok.
>     running -C. suffix= configure install ok.
>     running -C. suffix=-xen install-xen ok.
>     running -C. suffix=-tools configure install-tools ok.
>     running -C. suffix=-stubdom configure install-stubdom ok.
>     running -C. suffix=-docs configure install-docs ok.
>     running -Cxen suffix= install ok.
>     running -Cdocs suffix= configure install ok.
>     running -Ctools suffix= configure install fail!
>     (64)iwj@mariner:~/work/xen.git$
> 
> CC: Julien Grall <julien.grall@arm.com>
> CC: M A Young <m.a.young@durham.ac.uk>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Just a minor nit/question.

> ---
>  Makefile | 39 +++++++++++++++++++++++----------------
>  1 file changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index fc30b3c..51905eb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -38,18 +38,13 @@ mini-os-dir-force-update: mini-os-dir
>  export XEN_TARGET_ARCH
>  export DESTDIR

Maybe it would be good to add a note like:

"All the Makefiles invoked with -C from the toplevel should have the
following targets: all, build, install, clean, distclean"

?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Ian Jackson]

Thanks to everyone for testing and review and acks.  I have just
pushed those two commits to staging.

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"):
> Maybe it would be good to add a note like:
> 
> "All the Makefiles invoked with -C from the toplevel should have the
> following targets: all, build, install, clean, distclean"

Yes, indeed.  How about the extra patch below ?
There are some special cases, so I think `generally' is right.

I'll wait a bit for opinions, but given that this is a comment-only
patch I guess Julien's exception for docs applies, so I will probably
commit it tomorrow unless someone objects.

Ian.

From 352f4a1f9797d1eee94121565fb4e3d8fc698371 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Thu, 25 May 2017 16:42:12 +0100
Subject: [PATCH] Makefile: Mention usual targets of subdir Makefiles
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: M A Young <m.a.young@durham.ac.uk>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 51905eb..2ff33df 100644
--- a/Makefile
+++ b/Makefile
@@ -90,6 +90,11 @@ test:
 #
 # Also, we have a number of targets COMPONENT which run
 # dist-COMPONENT, for convenience.
+#
+# The Makefiles invoked with -C from the toplevel should
+# generally have the following targets:
+#       all  build  install  clean  distclean
+
 
 .PHONY: dist
 dist: DESTDIR=$(DISTDIR)/install
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Julien Grall]

On 25/05/17 16:45, Ian Jackson wrote:
> Thanks to everyone for testing and review and acks.  I have just
> pushed those two commits to staging.
>
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"):
>> Maybe it would be good to add a note like:
>>
>> "All the Makefiles invoked with -C from the toplevel should have the
>> following targets: all, build, install, clean, distclean"
>
> Yes, indeed.  How about the extra patch below ?
> There are some special cases, so I think `generally' is right.
>
> I'll wait a bit for opinions, but given that this is a comment-only
> patch I guess Julien's exception for docs applies, so I will probably
> commit it tomorrow unless someone objects.

That's right. However, I'd like to try branching tomorrow so we need 
staging != master.

Could you hold the patch until we branch? (I will send an e-mail for a 
commit moratorium).

Cheers,


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

[Roger Pau Monné]

On Thu, May 25, 2017 at 04:45:48PM +0100, Ian Jackson wrote:
> Thanks to everyone for testing and review and acks.  I have just
> pushed those two commits to staging.
> 
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"):
> > Maybe it would be good to add a note like:
> > 
> > "All the Makefiles invoked with -C from the toplevel should have the
> > following targets: all, build, install, clean, distclean"
> 
> Yes, indeed.  How about the extra patch below ?
> There are some special cases, so I think `generally' is right.
> 
> I'll wait a bit for opinions, but given that this is a comment-only
> patch I guess Julien's exception for docs applies, so I will probably
> commit it tomorrow unless someone objects.
> 
> Ian.
> 
> From 352f4a1f9797d1eee94121565fb4e3d8fc698371 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Thu, 25 May 2017 16:42:12 +0100
> Subject: [PATCH] Makefile: Mention usual targets of subdir Makefiles
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel