From: Randy Dunlap <rdunlap@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org,
linux-um <linux-um@lists.infradead.org>,
paulmck@kernel.org, Richard Weinberger <richard@nod.at>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU)
Date: Wed, 16 Mar 2022 21:52:44 -0700 [thread overview]
Message-ID: <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> (raw)
In-Reply-To: <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org>
On 3/16/22 21:30, Andrew Morton wrote:
> On Wed, 16 Mar 2022 21:21:16 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
>>
>>
>> On 3/16/22 17:43, Andrew Morton wrote:
>>> The mm-of-the-moment snapshot 2022-03-16-17-42 has been uploaded to
>>>
>>> https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
>>> https://ozlabs.org/~akpm/mmotm/series
>>
>>
>> UML for x86_64, defconfig:
>>
>> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0,
>> from ../include/linux/compiler.h:248,
>> from ../include/linux/kernel.h:20,
>> from ../include/linux/cpumask.h:10,
>> from ../include/linux/energy_model.h:4,
>> from ../kernel/sched/fair.c:23:
>> ../include/linux/psi.h: In function ‘cgroup_move_task’:
>> ../include/linux/rcupdate.h:414:36: error: dereferencing pointer to incomplete type ‘struct css_set’
>> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
>> ^~~~
>
> Works For Me. I tried `make x86_64_defconfig' and `make i386_defconfig' too.
>
> Can you please share that .config, or debug a bit?
$ make ARCH=um SUBARCH=x86_64 defconfig
This fixes the build error for me when CONFIG_PSI=n.
---
include/linux/psi.h | 3 +++
1 file changed, 3 insertions(+)
--- mmotm-2022-0316-1742.orig/include/linux/psi.h
+++ mmotm-2022-0316-1742/include/linux/psi.h
@@ -53,6 +53,9 @@ static inline int psi_cgroup_alloc(struc
static inline void psi_cgroup_free(struct cgroup *cgrp)
{
}
+
+#include <linux/cgroup-defs.h>
+
static inline void cgroup_move_task(struct task_struct *p, struct css_set *to)
{
rcu_assign_pointer(p->cgroups, to);
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org,
linux-um <linux-um@lists.infradead.org>,
paulmck@kernel.org, Richard Weinberger <richard@nod.at>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU)
Date: Wed, 16 Mar 2022 21:52:44 -0700 [thread overview]
Message-ID: <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> (raw)
In-Reply-To: <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org>
On 3/16/22 21:30, Andrew Morton wrote:
> On Wed, 16 Mar 2022 21:21:16 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
>>
>>
>> On 3/16/22 17:43, Andrew Morton wrote:
>>> The mm-of-the-moment snapshot 2022-03-16-17-42 has been uploaded to
>>>
>>> https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> https://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
>>> https://ozlabs.org/~akpm/mmotm/series
>>
>>
>> UML for x86_64, defconfig:
>>
>> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0,
>> from ../include/linux/compiler.h:248,
>> from ../include/linux/kernel.h:20,
>> from ../include/linux/cpumask.h:10,
>> from ../include/linux/energy_model.h:4,
>> from ../kernel/sched/fair.c:23:
>> ../include/linux/psi.h: In function ‘cgroup_move_task’:
>> ../include/linux/rcupdate.h:414:36: error: dereferencing pointer to incomplete type ‘struct css_set’
>> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
>> ^~~~
>
> Works For Me. I tried `make x86_64_defconfig' and `make i386_defconfig' too.
>
> Can you please share that .config, or debug a bit?
$ make ARCH=um SUBARCH=x86_64 defconfig
This fixes the build error for me when CONFIG_PSI=n.
---
include/linux/psi.h | 3 +++
1 file changed, 3 insertions(+)
--- mmotm-2022-0316-1742.orig/include/linux/psi.h
+++ mmotm-2022-0316-1742/include/linux/psi.h
@@ -53,6 +53,9 @@ static inline int psi_cgroup_alloc(struc
static inline void psi_cgroup_free(struct cgroup *cgrp)
{
}
+
+#include <linux/cgroup-defs.h>
+
static inline void cgroup_move_task(struct task_struct *p, struct css_set *to)
{
rcu_assign_pointer(p->cgroups, to);
--
~Randy
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2022-03-17 6:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 0:43 mmotm 2022-03-16-17-42 uploaded Andrew Morton
2022-03-17 0:43 ` Andrew Morton
2022-03-17 4:21 ` mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU) Randy Dunlap
2022-03-17 4:21 ` Randy Dunlap
2022-03-17 4:27 ` Randy Dunlap
2022-03-17 4:27 ` Randy Dunlap
2022-03-17 4:30 ` Andrew Morton
2022-03-17 4:30 ` Andrew Morton
2022-03-17 4:52 ` Randy Dunlap [this message]
2022-03-17 4:52 ` Randy Dunlap
2022-03-17 13:43 ` Paul E. McKenney
2022-03-17 13:43 ` Paul E. McKenney
2022-03-17 23:51 ` Andrew Morton
2022-03-17 23:51 ` Andrew Morton
2022-03-18 0:10 ` Randy Dunlap
2022-03-18 0:10 ` Randy Dunlap
2022-03-18 3:56 ` Randy Dunlap
2022-03-18 3:56 ` Randy Dunlap
2022-03-18 4:32 ` Sachin Sant
2022-03-18 4:32 ` Sachin Sant
2022-03-17 4:24 ` mmotm 2022-03-16-17-42 uploaded (drivers/iio/afe/iio-rescale.o) Randy Dunlap
2022-03-17 4:37 ` mmotm 2022-03-16-17-42 uploaded (drivers/pinctrl/nuvoton/pinctrl-wpcm450.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=richard@nod.at \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.