* [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;
@ 2019-09-03 18:46 Moritz Fischer
2019-09-03 19:46 ` Florian Fainelli
2019-09-05 9:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Moritz Fischer @ 2019-09-03 18:46 UTC (permalink / raw)
To: netdev
Cc: andrew, f.fainelli, hkallweit1, linux-kernel, davem, Moritz Fischer
Add forward declaration for struct gpio_desc in order to address
the following:
./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
Fixes commit 71bd106d2567 ("net: fixed-phy: Add
fixed_phy_register_with_gpiod() API")
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
include/linux/phy_fixed.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
index 1e5d86ebdaeb..52bc8e487ef7 100644
--- a/include/linux/phy_fixed.h
+++ b/include/linux/phy_fixed.h
@@ -11,6 +11,7 @@ struct fixed_phy_status {
};
struct device_node;
+struct gpio_desc;
#if IS_ENABLED(CONFIG_FIXED_PHY)
extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
--
2.23.0.187.g17f5b7556c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;
2019-09-03 18:46 [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc; Moritz Fischer
@ 2019-09-03 19:46 ` Florian Fainelli
2019-09-05 9:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-09-03 19:46 UTC (permalink / raw)
To: Moritz Fischer, netdev; +Cc: andrew, hkallweit1, linux-kernel, davem
On 9/3/19 11:46 AM, Moritz Fischer wrote:
> Add forward declaration for struct gpio_desc in order to address
> the following:
>
> ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
> ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
>
> Fixes commit 71bd106d2567 ("net: fixed-phy: Add
> fixed_phy_register_with_gpiod() API")
There is a standardized tag for that which is:
Fixes: 71bd106d2567 ("net: fixed-phy: Add
fixed_phy_register_with_gpiod() API")
Other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> include/linux/phy_fixed.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> index 1e5d86ebdaeb..52bc8e487ef7 100644
> --- a/include/linux/phy_fixed.h
> +++ b/include/linux/phy_fixed.h
> @@ -11,6 +11,7 @@ struct fixed_phy_status {
> };
>
> struct device_node;
> +struct gpio_desc;
>
> #if IS_ENABLED(CONFIG_FIXED_PHY)
> extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;
2019-09-03 18:46 [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc; Moritz Fischer
2019-09-03 19:46 ` Florian Fainelli
@ 2019-09-05 9:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-09-05 9:54 UTC (permalink / raw)
To: mdf; +Cc: netdev, andrew, f.fainelli, hkallweit1, linux-kernel
From: Moritz Fischer <mdf@kernel.org>
Date: Tue, 3 Sep 2019 11:46:52 -0700
> Add forward declaration for struct gpio_desc in order to address
> the following:
>
> ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
> ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
>
> Fixes commit 71bd106d2567 ("net: fixed-phy: Add
> fixed_phy_register_with_gpiod() API")
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Applied with Fixes tag fixed up.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-05 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 18:46 [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc; Moritz Fischer
2019-09-03 19:46 ` Florian Fainelli
2019-09-05 9:54 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.