From: Dave Gerlach <d-gerlach@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: Rob Herring <robh@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Nishanth Menon <nm@ti.com> Subject: Re: [PATCH v4 2/4] Documentation: dt: add bindings for ti-cpufreq Date: Mon, 23 Jan 2017 15:48:10 -0600 [thread overview] Message-ID: <91a2d778-ce39-19dd-33cd-77e4eda0d8b7@ti.com> (raw) In-Reply-To: <20170120184324.GJ7403@atomide.com> On 01/20/2017 12:43 PM, Tony Lindgren wrote: > * Dave Gerlach <d-gerlach@ti.com> [170119 10:32]: >> On 01/19/2017 12:07 PM, Rob Herring wrote: >>>> + /* >>>> + * The three following nodes are marked with opp-suspend >>>> + * because they can not be enabled simultaneously on a >>>> + * single SoC. >>>> + */ >>>> + opp50@300000000 { >>> >>> What's the 50, 100, 120 in the names? >> >> Those are the names of the OPPs given in Table 5-7 of the AM335x data >> manual, seen here http://www.ti.com/lit/ds/symlink/am3359.pdf . I typically >> reference the table and document in the commit message of the actual DT >> patches but didn't here for the binding. > > If you don't need the names, you could maybe use: > > opp100: opp@275000000 { > ... > }; > > opp200: opp@300000000 { > ... > }; Thanks for the suggestion, but we have duplicate frequencies that have different voltages defined for them, so the scheme opp@<freq> won't work because then we end up with duplicate nodes. OPPs are a defined by a number of parameters, not just frequency, so always naming the nodes opp@<freq> won't cover all scenarios. Regards, Dave > ... > > Regards, > > Tony >
WARNING: multiple messages have this Message-ID (diff)
From: d-gerlach@ti.com (Dave Gerlach) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 2/4] Documentation: dt: add bindings for ti-cpufreq Date: Mon, 23 Jan 2017 15:48:10 -0600 [thread overview] Message-ID: <91a2d778-ce39-19dd-33cd-77e4eda0d8b7@ti.com> (raw) In-Reply-To: <20170120184324.GJ7403@atomide.com> On 01/20/2017 12:43 PM, Tony Lindgren wrote: > * Dave Gerlach <d-gerlach@ti.com> [170119 10:32]: >> On 01/19/2017 12:07 PM, Rob Herring wrote: >>>> + /* >>>> + * The three following nodes are marked with opp-suspend >>>> + * because they can not be enabled simultaneously on a >>>> + * single SoC. >>>> + */ >>>> + opp50 at 300000000 { >>> >>> What's the 50, 100, 120 in the names? >> >> Those are the names of the OPPs given in Table 5-7 of the AM335x data >> manual, seen here http://www.ti.com/lit/ds/symlink/am3359.pdf . I typically >> reference the table and document in the commit message of the actual DT >> patches but didn't here for the binding. > > If you don't need the names, you could maybe use: > > opp100: opp at 275000000 { > ... > }; > > opp200: opp at 300000000 { > ... > }; Thanks for the suggestion, but we have duplicate frequencies that have different voltages defined for them, so the scheme opp@<freq> won't work because then we end up with duplicate nodes. OPPs are a defined by a number of parameters, not just frequency, so always naming the nodes opp@<freq> won't cover all scenarios. Regards, Dave > ... > > Regards, > > Tony >
next prev parent reply other threads:[~2017-01-23 21:48 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-17 13:18 [PATCH v4 0/4] cpufreq: Introduce TI CPUFreq/OPP Driver Dave Gerlach 2017-01-17 13:18 ` Dave Gerlach 2017-01-17 13:18 ` [PATCH v4 1/4] PM / OPP: Expose _of_get_opp_desc_node as dev_pm_opp API Dave Gerlach 2017-01-17 13:18 ` Dave Gerlach 2017-01-18 3:14 ` Viresh Kumar 2017-01-18 3:14 ` Viresh Kumar 2017-01-17 13:18 ` [PATCH v4 2/4] Documentation: dt: add bindings for ti-cpufreq Dave Gerlach 2017-01-17 13:18 ` Dave Gerlach 2017-01-18 3:16 ` Viresh Kumar 2017-01-18 3:16 ` Viresh Kumar [not found] ` <20170117131808.29798-3-d-gerlach-l0cyMroinI0@public.gmane.org> 2017-01-19 18:07 ` Rob Herring 2017-01-19 18:07 ` Rob Herring 2017-01-19 18:31 ` Dave Gerlach 2017-01-19 18:31 ` Dave Gerlach [not found] ` <b7d11925-879a-9be0-fdd8-45b70e642ce1-l0cyMroinI0@public.gmane.org> 2017-01-20 18:43 ` Tony Lindgren 2017-01-20 18:43 ` Tony Lindgren 2017-01-23 21:48 ` Dave Gerlach [this message] 2017-01-23 21:48 ` Dave Gerlach [not found] ` <20170117131808.29798-1-d-gerlach-l0cyMroinI0@public.gmane.org> 2017-01-17 13:18 ` [PATCH v4 3/4] cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime Dave Gerlach 2017-01-17 13:18 ` Dave Gerlach 2017-01-18 3:17 ` Viresh Kumar 2017-01-18 3:17 ` Viresh Kumar 2017-01-17 13:18 ` [PATCH v4 4/4] cpufreq: dt: Don't use generic platdev driver for ti-cpufreq platforms Dave Gerlach 2017-01-17 13:18 ` Dave Gerlach [not found] ` <20170117131808.29798-5-d-gerlach-l0cyMroinI0@public.gmane.org> 2017-01-18 3:17 ` Viresh Kumar 2017-01-18 3:17 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=91a2d778-ce39-19dd-33cd-77e4eda0d8b7@ti.com \ --to=d-gerlach@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=robh@kernel.org \ --cc=tony@atomide.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.