All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	mad skateman <madskateman@gmail.com>,
	Christian Zigotzky <info@xenosoft.de>
Subject: Re: [FSL P50x0] KVM HV doesn't work anymore
Date: Sun, 30 May 2021 08:49:09 +0200	[thread overview]
Message-ID: <91b8ea0f-0666-7bf7-a526-b3d4f183d4d6@xenosoft.de> (raw)
In-Reply-To: <1621464963.g8v9ejlhyh.astroid@bobo.none>

On 20 May 21 at 01:07am, Nicholas Piggin wrote:
> Excerpts from Christian Zigotzky's message of May 19, 2021 9:52 pm:
>> On 19 May 2021 at 09:57 am, Nicholas Piggin wrote:
>>> Excerpts from Christian Zigotzky's message of May 17, 2021 7:42 pm:
>>>> On 17 May 2021 at 09:42am, Nicholas Piggin wrote:
>>>>> Excerpts from Christian Zigotzky's message of May 15, 2021 11:46 pm:
>>>>>> I tried it but it doesn't solve the issue. The uImage works without
>>>>>> KVM
>>>>>> HV in a virtual e5500 QEMU machine.
>>>>> Any more progress with this? I would say that bisect might have just
>>>>> been a bit unstable and maybe by chance some things did not crash so
>>>>> it's pointing to the wrong patch.
>>>>>
>>>>> Upstream merge of powerpc-5.13-1 was good and powerpc-5.13-2 was bad?
>>>>>
>>>>> Between that looks like some KVM MMU rework. You could try the patch
>>>>> before this one b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU
>>>>> notifier callbacks"). That won't revert cleanly so just try run the
>>>>> tree at that point. If it works, test the patch and see if it fails.
>>>>>
>>>>> Thanks,
>>>>> Nick
>>>> Hi Nick,
>>>>
>>>> Thanks a lot for your answer. Yes, there is a little bit of progress.
>>>> The RC2 of kernel 5.13 successfully boots with -smp 3 in a virtual e5500
>>>> QEMU machine.
>>>> -smp 4 doesn't work anymore since the PowerPC updates 5.13-2. I used
>>>> -smp 4 before 5.13 because my FSL P5040 machine has 4 cores.
>>>>
>>>> Could you please post a patch for reverting the commit before
>>>> b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")?
>>> You could `git checkout b1c5356e873c~1`
>>>
>>> Thanks,
>>> Nick
>> Hi Nick,
>>
>> Thanks for your answer. I checked out the commit b1c5356e873c~1 (HEAD is
>> now at d923ff258423 KVM: MIPS/MMU: Convert to the gfn-based MMU notifier
>> callbacks).
>> The kernel boots with '-smp 4' without any problems.
>> After that I patched with the probable first bad commit (KVM: PPC:
>> Convert to the gfn-based MMU notifier callbacks). The kernel also boots
>> with this patch. That means, this isn't the first bad commit.
>> Further information:
>> https://forum.hyperion-entertainment.com/viewtopic.php?p=53267#p53267
> Hmm, okay that probably rules out those notifier changes then.
>
> Can you remind me were you able to rule these out as suspects?
>
> 8f6cc75a97d1 powerpc: move norestart trap flag to bit 0
> 8dc7f0229b78 powerpc: remove partial register save logic
> c45ba4f44f6b powerpc: clean up do_page_fault
> d738ee8d56de powerpc/64e/interrupt: handle bad_page_fault in C
> ceff77efa4f8 powerpc/64e/interrupt: Use new interrupt context tracking scheme
> 097157e16cf8 powerpc/64e/interrupt: reconcile irq soft-mask state in C
> 3db8aa10de9a powerpc/64e/interrupt: NMI save irq soft-mask state in C
> 0c2472de23ae powerpc/64e/interrupt: use new interrupt return
> dc6231821a14 powerpc/interrupt: update common interrupt code for
> 4228b2c3d20e powerpc/64e/interrupt: always save nvgprs on interrupt
> 5a5a893c4ad8 powerpc/syscall: switch user_exit_irqoff and trace_hardirqs_off order
>
> Thanks,
> Nick
Hi Nick,

Thanks for your answer. Smp 4 still doesn't work on quad core e5500 
CPUs. I use -smp 3 currently. Shall I checkout the commits above (in 
your last answer) and test them? Do you prefer a commit for testing?

Thanks,
Christian

WARNING: multiple messages have this Message-ID (diff)
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	mad skateman <madskateman@gmail.com>,
	Christian Zigotzky <info@xenosoft.de>
Subject: Re: [FSL P50x0] KVM HV doesn't work anymore
Date: Sun, 30 May 2021 06:49:09 +0000	[thread overview]
Message-ID: <91b8ea0f-0666-7bf7-a526-b3d4f183d4d6@xenosoft.de> (raw)
In-Reply-To: <1621464963.g8v9ejlhyh.astroid@bobo.none>

On 20 May 21 at 01:07am, Nicholas Piggin wrote:
> Excerpts from Christian Zigotzky's message of May 19, 2021 9:52 pm:
>> On 19 May 2021 at 09:57 am, Nicholas Piggin wrote:
>>> Excerpts from Christian Zigotzky's message of May 17, 2021 7:42 pm:
>>>> On 17 May 2021 at 09:42am, Nicholas Piggin wrote:
>>>>> Excerpts from Christian Zigotzky's message of May 15, 2021 11:46 pm:
>>>>>> I tried it but it doesn't solve the issue. The uImage works without
>>>>>> KVM
>>>>>> HV in a virtual e5500 QEMU machine.
>>>>> Any more progress with this? I would say that bisect might have just
>>>>> been a bit unstable and maybe by chance some things did not crash so
>>>>> it's pointing to the wrong patch.
>>>>>
>>>>> Upstream merge of powerpc-5.13-1 was good and powerpc-5.13-2 was bad?
>>>>>
>>>>> Between that looks like some KVM MMU rework. You could try the patch
>>>>> before this one b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU
>>>>> notifier callbacks"). That won't revert cleanly so just try run the
>>>>> tree at that point. If it works, test the patch and see if it fails.
>>>>>
>>>>> Thanks,
>>>>> Nick
>>>> Hi Nick,
>>>>
>>>> Thanks a lot for your answer. Yes, there is a little bit of progress.
>>>> The RC2 of kernel 5.13 successfully boots with -smp 3 in a virtual e5500
>>>> QEMU machine.
>>>> -smp 4 doesn't work anymore since the PowerPC updates 5.13-2. I used
>>>> -smp 4 before 5.13 because my FSL P5040 machine has 4 cores.
>>>>
>>>> Could you please post a patch for reverting the commit before
>>>> b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")?
>>> You could `git checkout b1c5356e873c~1`
>>>
>>> Thanks,
>>> Nick
>> Hi Nick,
>>
>> Thanks for your answer. I checked out the commit b1c5356e873c~1 (HEAD is
>> now at d923ff258423 KVM: MIPS/MMU: Convert to the gfn-based MMU notifier
>> callbacks).
>> The kernel boots with '-smp 4' without any problems.
>> After that I patched with the probable first bad commit (KVM: PPC:
>> Convert to the gfn-based MMU notifier callbacks). The kernel also boots
>> with this patch. That means, this isn't the first bad commit.
>> Further information:
>> https://forum.hyperion-entertainment.com/viewtopic.php?pS267#p53267
> Hmm, okay that probably rules out those notifier changes then.
>
> Can you remind me were you able to rule these out as suspects?
>
> 8f6cc75a97d1 powerpc: move norestart trap flag to bit 0
> 8dc7f0229b78 powerpc: remove partial register save logic
> c45ba4f44f6b powerpc: clean up do_page_fault
> d738ee8d56de powerpc/64e/interrupt: handle bad_page_fault in C
> ceff77efa4f8 powerpc/64e/interrupt: Use new interrupt context tracking scheme
> 097157e16cf8 powerpc/64e/interrupt: reconcile irq soft-mask state in C
> 3db8aa10de9a powerpc/64e/interrupt: NMI save irq soft-mask state in C
> 0c2472de23ae powerpc/64e/interrupt: use new interrupt return
> dc6231821a14 powerpc/interrupt: update common interrupt code for
> 4228b2c3d20e powerpc/64e/interrupt: always save nvgprs on interrupt
> 5a5a893c4ad8 powerpc/syscall: switch user_exit_irqoff and trace_hardirqs_off order
>
> Thanks,
> Nick
Hi Nick,

Thanks for your answer. Smp 4 still doesn't work on quad core e5500 
CPUs. I use -smp 3 currently. Shall I checkout the commits above (in 
your last answer) and test them? Do you prefer a commit for testing?

Thanks,
Christian

  reply	other threads:[~2021-05-30  6:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  8:10 [FSL P50x0] KVM HV doesn't work anymore Christian Zigotzky
2021-05-14  8:10 ` Christian Zigotzky
2021-05-15  9:48 ` Christian Zigotzky
2021-05-15  9:48   ` Christian Zigotzky
2021-05-15 10:08   ` Christophe Leroy
2021-05-15 10:08     ` Christophe Leroy
2021-05-15 13:46     ` Christian Zigotzky
2021-05-15 13:46       ` Christian Zigotzky
2021-05-17  7:42       ` Nicholas Piggin
2021-05-17  7:42         ` Nicholas Piggin
2021-05-17  9:42         ` Christian Zigotzky
2021-05-17  9:42           ` Christian Zigotzky
2021-05-18  6:33           ` Christian Zigotzky
2021-05-18  6:33             ` Christian Zigotzky
2021-05-19  7:57           ` Nicholas Piggin
2021-05-19  7:57             ` Nicholas Piggin
2021-05-19 11:52             ` Christian Zigotzky
2021-05-19 11:52               ` Christian Zigotzky
2021-05-19 23:07               ` Nicholas Piggin
2021-05-19 23:07                 ` Nicholas Piggin
2021-05-30  6:49                 ` Christian Zigotzky [this message]
2021-05-30  6:49                   ` Christian Zigotzky
2021-06-02 11:26                 ` Christian Zigotzky
2021-06-02 11:26                   ` Christian Zigotzky
2021-06-07  7:21                   ` Christian Zigotzky
2021-06-07  7:21                     ` Christian Zigotzky
2021-06-11  2:24                     ` Nicholas Piggin
2021-06-11  2:24                       ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b8ea0f-0666-7bf7-a526-b3d4f183d4d6@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=darren@stevens-zone.net \
    --cc=info@xenosoft.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madskateman@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=rtd2@xtra.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.