All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
@ 2018-12-01  2:10 ` YueHaibing
  0 siblings, 0 replies; 11+ messages in thread
From: YueHaibing @ 2018-12-01  2:10 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: YueHaibing, xen-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
drivers/xen/pvcalls-front.c:506:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
drivers/xen/pvcalls-front.c:603:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/pvcalls-front.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 77224d8..223ad7b 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -503,7 +503,6 @@ static int __write_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 			  size_t len)
 {
-	struct pvcalls_bedata *bedata;
 	struct sock_mapping *map;
 	int sent, tot_sent = 0;
 	int count = 0, flags;
@@ -515,7 +514,6 @@ int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.out_mutex);
 	if ((flags & MSG_DONTWAIT) && !pvcalls_front_write_todo(map)) {
@@ -600,7 +598,6 @@ static int __read_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 		     int flags)
 {
-	struct pvcalls_bedata *bedata;
 	int ret;
 	struct sock_mapping *map;
 
@@ -610,7 +607,6 @@ int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.in_mutex);
 	if (len > XEN_FLEX_RING_SIZE(PVCALLS_RING_ORDER))




^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
@ 2018-12-01  2:10 ` YueHaibing
  0 siblings, 0 replies; 11+ messages in thread
From: YueHaibing @ 2018-12-01  2:10 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: YueHaibing, xen-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
drivers/xen/pvcalls-front.c:506:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
drivers/xen/pvcalls-front.c:603:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/pvcalls-front.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 77224d8..223ad7b 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -503,7 +503,6 @@ static int __write_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 			  size_t len)
 {
-	struct pvcalls_bedata *bedata;
 	struct sock_mapping *map;
 	int sent, tot_sent = 0;
 	int count = 0, flags;
@@ -515,7 +514,6 @@ int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.out_mutex);
 	if ((flags & MSG_DONTWAIT) && !pvcalls_front_write_todo(map)) {
@@ -600,7 +598,6 @@ static int __read_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 		     int flags)
 {
-	struct pvcalls_bedata *bedata;
 	int ret;
 	struct sock_mapping *map;
 
@@ -610,7 +607,6 @@ int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.in_mutex);
 	if (len > XEN_FLEX_RING_SIZE(PVCALLS_RING_ORDER))

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
  2018-12-01  2:10 ` YueHaibing
@ 2018-12-03  6:45   ` Juergen Gross
  -1 siblings, 0 replies; 11+ messages in thread
From: Juergen Gross @ 2018-12-03  6:45 UTC (permalink / raw)
  To: YueHaibing, Boris Ostrovsky, Stefano Stabellini
  Cc: xen-devel, linux-kernel, kernel-janitors

On 01/12/2018 03:10, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
> drivers/xen/pvcalls-front.c:506:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
> drivers/xen/pvcalls-front.c:603:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
@ 2018-12-03  6:45   ` Juergen Gross
  0 siblings, 0 replies; 11+ messages in thread
From: Juergen Gross @ 2018-12-03  6:45 UTC (permalink / raw)
  To: YueHaibing, Boris Ostrovsky, Stefano Stabellini
  Cc: xen-devel, linux-kernel, kernel-janitors

On 01/12/2018 03:10, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
> drivers/xen/pvcalls-front.c:506:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
> drivers/xen/pvcalls-front.c:603:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
  2018-12-01  2:10 ` YueHaibing
  (?)
@ 2018-12-03  6:45 ` Juergen Gross
  -1 siblings, 0 replies; 11+ messages in thread
From: Juergen Gross @ 2018-12-03  6:45 UTC (permalink / raw)
  To: YueHaibing, Boris Ostrovsky, Stefano Stabellini
  Cc: xen-devel, kernel-janitors, linux-kernel

On 01/12/2018 03:10, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
> drivers/xen/pvcalls-front.c:506:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
> drivers/xen/pvcalls-front.c:603:25: warning:
>  variable 'bedata' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
@ 2019-01-04  6:03   ` YueHaibing
  0 siblings, 0 replies; 11+ messages in thread
From: YueHaibing @ 2019-01-04  5:57 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: YueHaibing, xen-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
drivers/xen/pvcalls-back.c:286:28: warning:
 variable 'intf' set but not used [-Wunused-but-set-variable]

It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
pvcalls_conn_back_read")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/pvcalls-back.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 71b6287..7aa64d1 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -283,12 +283,10 @@ static int pvcalls_back_socket(struct xenbus_device *dev,
 static void pvcalls_sk_state_change(struct sock *sock)
 {
 	struct sock_mapping *map = sock->sk_user_data;
-	struct pvcalls_data_intf *intf;
 
 	if (map = NULL)
 		return;
 
-	intf = map->ring;
 	atomic_inc(&map->read);
 	notify_remote_via_irq(map->irq);
 }

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
@ 2019-01-04  6:03   ` YueHaibing
  0 siblings, 0 replies; 11+ messages in thread
From: YueHaibing @ 2019-01-04  6:03 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: YueHaibing, xen-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
drivers/xen/pvcalls-back.c:286:28: warning:
 variable 'intf' set but not used [-Wunused-but-set-variable]

It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
pvcalls_conn_back_read")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/pvcalls-back.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 71b6287..7aa64d1 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -283,12 +283,10 @@ static int pvcalls_back_socket(struct xenbus_device *dev,
 static void pvcalls_sk_state_change(struct sock *sock)
 {
 	struct sock_mapping *map = sock->sk_user_data;
-	struct pvcalls_data_intf *intf;
 
 	if (map == NULL)
 		return;
 
-	intf = map->ring;
 	atomic_inc(&map->read);
 	notify_remote_via_irq(map->irq);
 }




^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
  2019-01-04  6:03   ` YueHaibing
@ 2019-01-04 16:10     ` Boris Ostrovsky
  -1 siblings, 0 replies; 11+ messages in thread
From: Boris Ostrovsky @ 2019-01-04 16:10 UTC (permalink / raw)
  To: YueHaibing, Juergen Gross, Stefano Stabellini
  Cc: xen-devel, linux-kernel, kernel-janitors

On 1/4/19 1:03 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
> drivers/xen/pvcalls-back.c:286:28: warning:
>  variable 'intf' set but not used [-Wunused-but-set-variable]
>
> It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
> pvcalls_conn_back_read")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

and applied to for-linus-4.21.

Thanks.
-boris



^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
@ 2019-01-04 16:10     ` Boris Ostrovsky
  0 siblings, 0 replies; 11+ messages in thread
From: Boris Ostrovsky @ 2019-01-04 16:10 UTC (permalink / raw)
  To: YueHaibing, Juergen Gross, Stefano Stabellini
  Cc: xen-devel, linux-kernel, kernel-janitors

On 1/4/19 1:03 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
> drivers/xen/pvcalls-back.c:286:28: warning:
>  variable 'intf' set but not used [-Wunused-but-set-variable]
>
> It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
> pvcalls_conn_back_read")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

and applied to for-linus-4.21.

Thanks.
-boris

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
  2019-01-04  6:03   ` YueHaibing
  (?)
@ 2019-01-04 16:10   ` Boris Ostrovsky
  -1 siblings, 0 replies; 11+ messages in thread
From: Boris Ostrovsky @ 2019-01-04 16:10 UTC (permalink / raw)
  To: YueHaibing, Juergen Gross, Stefano Stabellini
  Cc: xen-devel, kernel-janitors, linux-kernel

On 1/4/19 1:03 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
> drivers/xen/pvcalls-back.c:286:28: warning:
>  variable 'intf' set but not used [-Wunused-but-set-variable]
>
> It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
> pvcalls_conn_back_read")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

and applied to for-linus-4.21.

Thanks.
-boris



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata'
@ 2018-12-01  2:10 YueHaibing
  0 siblings, 0 replies; 11+ messages in thread
From: YueHaibing @ 2018-12-01  2:10 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: xen-devel, kernel-janitors, YueHaibing, linux-kernel

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_sendmsg':
drivers/xen/pvcalls-front.c:506:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

drivers/xen/pvcalls-front.c: In function 'pvcalls_front_recvmsg':
drivers/xen/pvcalls-front.c:603:25: warning:
 variable 'bedata' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/pvcalls-front.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 77224d8..223ad7b 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -503,7 +503,6 @@ static int __write_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 			  size_t len)
 {
-	struct pvcalls_bedata *bedata;
 	struct sock_mapping *map;
 	int sent, tot_sent = 0;
 	int count = 0, flags;
@@ -515,7 +514,6 @@ int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.out_mutex);
 	if ((flags & MSG_DONTWAIT) && !pvcalls_front_write_todo(map)) {
@@ -600,7 +598,6 @@ static int __read_ring(struct pvcalls_data_intf *intf,
 int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 		     int flags)
 {
-	struct pvcalls_bedata *bedata;
 	int ret;
 	struct sock_mapping *map;
 
@@ -610,7 +607,6 @@ int pvcalls_front_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 	map = pvcalls_enter_sock(sock);
 	if (IS_ERR(map))
 		return PTR_ERR(map);
-	bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
 
 	mutex_lock(&map->active.in_mutex);
 	if (len > XEN_FLEX_RING_SIZE(PVCALLS_RING_ORDER))




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-01-04 16:11 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-01  2:10 [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata' YueHaibing
2018-12-01  2:10 ` YueHaibing
2018-12-03  6:45 ` Juergen Gross
2018-12-03  6:45 ` Juergen Gross
2018-12-03  6:45   ` Juergen Gross
2019-01-04  5:57 ` [PATCH -next] xen/pvcalls: remove set but not used variable 'intf' YueHaibing
2019-01-04  6:03   ` YueHaibing
2019-01-04 16:10   ` Boris Ostrovsky
2019-01-04 16:10   ` Boris Ostrovsky
2019-01-04 16:10     ` Boris Ostrovsky
2018-12-01  2:10 [PATCH -next] xen/pvcalls: remove set but not used variable 'bedata' YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.