linux-next: Fixes tags need some work in the scsi-fixes tree

linux-next: Fixes tags need some work in the scsi-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

Hi all,

In commit

  f4c5e949056d ("scsi: ibmvfc: Reinitialize sub-CRQs and perform channel enquiry after LPM")

Fixes tag

  Fixes: 3034ebe26389 ("ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels")

has these problem(s):

  - Subject does not match target commit subject

In commit

  5bc26ea9498a ("scsi: ibmvfc: Store return code of H_FREE_SUB_CRQ during cleanup")

Fixes tag

  Fixes: 39e461fddff0 ("ibmvfc: map/request irq and register Sub-CRQ interrupt handler")

has these problem(s):

  - Subject does not match target commit subject

In commit

  98cf9a92b8d6 ("scsi: ibmvfc: Treat H_CLOSED as success during sub-CRQ registration")

Fixes tag

  Fixes: 3034ebe26389 ("ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels")

has these problem(s):

  - Subject does not match target commit subject

In commit

  2de4c19179b1 ("scsi: ibmvfc: Fix invalid sub-CRQ handles after hard reset")

Fixes tag

  Fixes: 3034ebe26389 ("ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels")

has these problem(s):

  - Subject does not match target commit subject

Plese just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the scsi-fixes tree

[Martin K. Petersen]

Stephen,

>   - Subject does not match target commit subject

Fun. I actually have a check for this in my validation script but for
some reason lost in the mists of time it was commented out. Reinstated.

I fixed the tags up.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: linux-next: Fixes tags need some work in the scsi-fixes tree

[Tyrel Datwyler]

On 3/4/21 1:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f4c5e949056d ("scsi: ibmvfc: Reinitialize sub-CRQs and perform channel enquiry after LPM")
> 
> Fixes tag
> 
>   Fixes: 3034ebe26389 ("ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
> 

Well crap. I realized I botched them in v4, and fixed up the commit ids in v5
but clearly not the subjects.

> Plese just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 

Noted.

-Tyrel