All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Anand Gore" <anand.gore@broadcom.com>,
	"Kursad Oney" <kursad.oney@broadcom.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
Date: Wed, 9 Nov 2022 21:11:31 +0100	[thread overview]
Message-ID: <923207f7-387d-2ed8-db64-118db6167669@gmail.com> (raw)
In-Reply-To: <78ac1b7d-5f7c-c9d3-118b-5e419a7c20dc@gmail.com>

On 9.11.2022 19:37, Florian Fainelli wrote:
> On 11/3/22 03:41, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> String "nand" was never a valid interrupt name. It was never documented
>> and never used in Linux or U-Boot driver. This mistake was propagated
>> from the bcm63138.dtsi.
>>
>> The whole "interrupt-names" property is optional and can be skipped.
>>
>> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?

I don't have any real preference.

Since we already have this patch, we may just apply it. If you think
having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send
V2.

WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Anand Gore" <anand.gore@broadcom.com>,
	"Kursad Oney" <kursad.oney@broadcom.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
Date: Wed, 9 Nov 2022 21:11:31 +0100	[thread overview]
Message-ID: <923207f7-387d-2ed8-db64-118db6167669@gmail.com> (raw)
In-Reply-To: <78ac1b7d-5f7c-c9d3-118b-5e419a7c20dc@gmail.com>

On 9.11.2022 19:37, Florian Fainelli wrote:
> On 11/3/22 03:41, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> String "nand" was never a valid interrupt name. It was never documented
>> and never used in Linux or U-Boot driver. This mistake was propagated
>> from the bcm63138.dtsi.
>>
>> The whole "interrupt-names" property is optional and can be skipped.
>>
>> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?

I don't have any real preference.

Since we already have this patch, we may just apply it. If you think
having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send
V2.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-09 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 10:41 [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name Rafał Miłecki
2022-11-03 10:41 ` Rafał Miłecki
2022-11-09 18:37 ` Florian Fainelli
2022-11-09 18:37   ` Florian Fainelli
2022-11-09 20:11   ` Rafał Miłecki [this message]
2022-11-09 20:11     ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=923207f7-387d-2ed8-db64-118db6167669@gmail.com \
    --to=zajec5@gmail.com \
    --cc=anand.gore@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kursad.oney@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.