All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: fix ascii art in networking docs
@ 2017-09-16 16:22 Pavel Machek
  2017-09-16 16:51 ` Andrew Lunn
  2017-09-16 18:18 ` Andreas Schwab
  0 siblings, 2 replies; 6+ messages in thread
From: Pavel Machek @ 2017-09-16 16:22 UTC (permalink / raw)
  To: David S. Miller; +Cc: Netdev list

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]


Fix ascii-art.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

---

Resent, because I did not get DaveM's address right.

diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: fix ascii art in networking docs
  2017-09-16 16:22 [PATCH] Documentation: fix ascii art in networking docs Pavel Machek
@ 2017-09-16 16:51 ` Andrew Lunn
  2017-09-16 18:18 ` Andreas Schwab
  1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2017-09-16 16:51 UTC (permalink / raw)
  To: Pavel Machek; +Cc: David S. Miller, Netdev list

On Sat, Sep 16, 2017 at 06:22:17PM +0200, Pavel Machek wrote:
> 
> Fix ascii-art.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> ---
> 
> Resent, because I did not get DaveM's address right.
> 
> diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
> index 5e40e1f..6309e90 100644
> --- a/Documentation/networking/switchdev.txt
> +++ b/Documentation/networking/switchdev.txt
> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>  ??????????????????????????????????????????????????????????????????sw1p1??? +  sw1p3  + ???sw1p5  +  ????????????????????????eth1
>  ????????????????????????????????????????????????????????????????????????+????????????|????????????+????????????|????????????+????????????|????????????????????????????????????+
>  ????????????????????????????????????????????????????????????????????????|????????????|????????????|????????????|????????????|????????????|????????????????????????????????????|
> -???????????????????????????????????????????????????????????????+--+----+----+----+-+--+----+---+??????+-----+-----+
> +???????????????????????????????????????????????????????????????+--+----+----+----+----+----+---+??????+-----+-----+
>  ???????????????????????????????????????????????????????????????|???????????????????????????Switch???driver???????????????????????????|??????|????????????mgmt?????????|
>  ???????????????????????????????????????????????????????????????|????????????????????????(this???document)????????????????????????|??????|?????????driver??????|
>  ???????????????????????????????????????????????????????????????|?????????????????????????????????????????????????????????????????????????????????????????????|??????|?????????????????????????????????|

Hi Pavel

This is not very readable. Has the patch been mangled by your email?

   Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: fix ascii art in networking docs
  2017-09-16 16:22 [PATCH] Documentation: fix ascii art in networking docs Pavel Machek
  2017-09-16 16:51 ` Andrew Lunn
@ 2017-09-16 18:18 ` Andreas Schwab
  2017-09-16 19:25   ` Pavel Machek
  2017-09-16 19:47   ` Randy Dunlap
  1 sibling, 2 replies; 6+ messages in thread
From: Andreas Schwab @ 2017-09-16 18:18 UTC (permalink / raw)
  To: Pavel Machek; +Cc: David S. Miller, Netdev list

On Sep 16 2017, Pavel Machek <pavel@ucw.cz> wrote:

> diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
> index 5e40e1f..6309e90 100644
> --- a/Documentation/networking/switchdev.txt
> +++ b/Documentation/networking/switchdev.txt
> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>                        sw1p1  +  sw1p3  +  sw1p5  +          eth1
>                          +    |    +    |    +    |            +
>                          |    |    |    |    |    |            |
> -                     +--+----+----+----+-+--+----+---+  +-----+-----+
> +                     +--+----+----+----+----+----+---+  +-----+-----+
>                       |         Switch driver         |  |    mgmt   |
>                       |        (this document)        |  |   driver  |
>                       |                               |  |           |
>

This is all mis-aligned.  How about replacing all the thin space
characters by normal spaces?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: fix ascii art in networking docs
  2017-09-16 18:18 ` Andreas Schwab
@ 2017-09-16 19:25   ` Pavel Machek
  2017-09-16 19:47   ` Randy Dunlap
  1 sibling, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2017-09-16 19:25 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: David S. Miller, Netdev list

[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]

On Sat 2017-09-16 20:18:15, Andreas Schwab wrote:
> On Sep 16 2017, Pavel Machek <pavel@ucw.cz> wrote:
> 
> > diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
> > index 5e40e1f..6309e90 100644
> > --- a/Documentation/networking/switchdev.txt
> > +++ b/Documentation/networking/switchdev.txt
> > @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
> >                        sw1p1  +  sw1p3  +  sw1p5  +          eth1
> >                          +    |    +    |    +    |            +
> >                          |    |    |    |    |    |            |
> > -                     +--+----+----+----+-+--+----+---+  +-----+-----+
> > +                     +--+----+----+----+----+----+---+  +-----+-----+
> >                       |         Switch driver         |  |    mgmt   |
> >                       |        (this document)        |  |   driver  |
> >                       |                               |  |           |
> >
> 
> This is all mis-aligned.  How about replacing all the thin space
> characters by normal spaces?

It looked perfectly ok to me, in emacs. If you see a problem, please
submit followup patch.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: fix ascii art in networking docs
  2017-09-16 18:18 ` Andreas Schwab
  2017-09-16 19:25   ` Pavel Machek
@ 2017-09-16 19:47   ` Randy Dunlap
  1 sibling, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2017-09-16 19:47 UTC (permalink / raw)
  To: Andreas Schwab, Pavel Machek; +Cc: David S. Miller, Netdev list

On 09/16/17 11:18, Andreas Schwab wrote:
> On Sep 16 2017, Pavel Machek <pavel@ucw.cz> wrote:
> 
>> diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
>> index 5e40e1f..6309e90 100644
>> --- a/Documentation/networking/switchdev.txt
>> +++ b/Documentation/networking/switchdev.txt
>> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>>                        sw1p1  +  sw1p3  +  sw1p5  +          eth1
>>                          +    |    +    |    +    |            +
>>                          |    |    |    |    |    |            |
>> -                     +--+----+----+----+-+--+----+---+  +-----+-----+
>> +                     +--+----+----+----+----+----+---+  +-----+-----+
>>                       |         Switch driver         |  |    mgmt   |
>>                       |        (this document)        |  |   driver  |
>>                       |                               |  |           |
>>
> 
> This is all mis-aligned.  How about replacing all the thin space
> characters by normal spaces?

Yes, there are lots of non-ASCII "spaces" in the ASCII art.  :(

-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Documentation: fix ascii art in networking docs
@ 2017-09-16 11:49 Pavel Machek
  0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2017-09-16 11:49 UTC (permalink / raw)
  To: kernel list, davem, linux-doc, corbet

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]


Fix ascii-art.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-09-16 19:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-16 16:22 [PATCH] Documentation: fix ascii art in networking docs Pavel Machek
2017-09-16 16:51 ` Andrew Lunn
2017-09-16 18:18 ` Andreas Schwab
2017-09-16 19:25   ` Pavel Machek
2017-09-16 19:47   ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2017-09-16 11:49 Pavel Machek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.