From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] Makefile: Add target to generate hex output for combined spl and dtb
Date: Tue, 4 Jun 2019 02:00:28 +0200 [thread overview]
Message-ID: <927ff6ad-bfc2-e1c4-7b41-871b06a777bf@denx.de> (raw)
In-Reply-To: <20190603235718.28381-1-dalon.westergreen@linux.intel.com>
On 6/4/19 1:57 AM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> Some architectures, Stratix10, require a hex formatted spl that combines
> the spl image and dtb. This adds a target to create said hex file with
> and offset of SPL_TEXT_BASE.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
>
[...]
> @@ -363,6 +365,11 @@ endif
> $(obj)/$(SPL_BIN).sfp: $(obj)/$(SPL_BIN).bin FORCE
> $(call if_changed,mkimage)
>
> +OBJCOPYFLAGS_$(SPL_BIN).hex := -I binary -O ihex --change-address=$(CONFIG_SPL_TEXT_BASE)
Do we really need to do it here ? The commit message is not clear why
this is needed ; I think if you link the SPl against the correct
address, this should not be needed.
> +$(obj)/$(SPL_BIN).hex: $(obj)/u-boot-spl.bin FORCE
> + $(call if_changed,objcopy)
> +
> quiet_cmd_mksunxiboot = MKSUNXI $@
> cmd_mksunxiboot = $(objtree)/tools/mksunxiboot \
> --default-dt $(CONFIG_DEFAULT_DEVICE_TREE) $< $@
> @@ -463,3 +470,4 @@ ifdef CONFIG_ARCH_K3
> tispl.bin: $(obj)/u-boot-spl-nodtb.bin $(SHRUNK_ARCH_DTB) $(SPL_ITS) FORCE
> $(call if_changed,mkfitimage)
> endif
> +
Drop this hunk
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-06-04 0:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 23:57 [U-Boot] [PATCH v2 1/2] Makefile: Add target to generate hex output for combined spl and dtb Dalon Westergreen
2019-06-03 23:57 ` [U-Boot] [PATCH v2 2/2] ARM: socfpga: stratix10: Remove CONFIG_OF_EMBED Dalon Westergreen
2019-06-04 5:13 ` Simon Goldschmidt
2019-06-04 5:58 ` See, Chin Liang
2019-06-04 6:12 ` Simon Goldschmidt
2019-06-04 16:10 ` Dalon L Westergreen
2019-06-04 18:15 ` Tom Rini
2019-06-04 18:34 ` Simon Goldschmidt
2019-06-04 0:00 ` Marek Vasut [this message]
2019-06-04 3:12 ` [U-Boot] [PATCH v2 1/2] Makefile: Add target to generate hex output for combined spl and dtb Dalon L Westergreen
2019-06-04 11:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927ff6ad-bfc2-e1c4-7b41-871b06a777bf@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.