All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Harfbuzz bump major version question
@ 2021-09-19 21:10 Giulio Benetti
  2021-09-20  6:41 ` Thomas Petazzoni
  0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2021-09-19 21:10 UTC (permalink / raw)
  To: Buildroot Mailing List; +Cc: Yann E. MORIN, Thomas Petazzoni

Hi All,

I'm going to bump harfbuzz to version 3.0.0 but being a major version it 
looses 15 apis[1] and introduce some new ones. So I'm not that sure if 
this can be a normal bump or I need to introduce the new package 
harfbuzz3. Package pango that requires harfbuzz builds fine, but how 
should I proceed? Should I build every package that depends on it and 
check if it builds fine? Or should I add package harfbuzz3 and then 
every package that depends on harfbuzz should move to harfbuzz3 package 
per package? I'm new to this case so help is appreciated.

Thanks in advance!

[1]: https://github.com/harfbuzz/harfbuzz/blob/main/NEWS#L29-L49
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] Harfbuzz bump major version question
  2021-09-19 21:10 [Buildroot] Harfbuzz bump major version question Giulio Benetti
@ 2021-09-20  6:41 ` Thomas Petazzoni
  2021-09-20  9:00   ` Arnout Vandecappelle
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2021-09-20  6:41 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Yann E. MORIN, Buildroot Mailing List

Hello Giulio,

On Sun, 19 Sep 2021 23:10:23 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> I'm going to bump harfbuzz to version 3.0.0 but being a major version it 
> looses 15 apis[1] and introduce some new ones. So I'm not that sure if 
> this can be a normal bump or I need to introduce the new package 
> harfbuzz3. Package pango that requires harfbuzz builds fine, but how 
> should I proceed? Should I build every package that depends on it and 
> check if it builds fine? Or should I add package harfbuzz3 and then 
> every package that depends on harfbuzz should move to harfbuzz3 package 
> per package? I'm new to this case so help is appreciated.

The best is to not have to introduce a separate harfbuzz3 package, as
it really complicates things.

There are not that many packages that have a dependency on harfbuzz:

package/efl/efl.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
package/libass/Config.in:       select BR2_PACKAGE_HARFBUZZ
package/mupdf/Config.in:        select BR2_PACKAGE_HARFBUZZ
package/pango/Config.in:        select BR2_PACKAGE_HARFBUZZ
package/qt5/qt5base/Config.in:config BR2_PACKAGE_QT5BASE_HARFBUZZ
package/qt5/qt5base/Config.in:  select BR2_PACKAGE_HARFBUZZ if \
package/qt5/qt5base/qt5base.mk:ifeq ($(BR2_PACKAGE_QT5BASE_HARFBUZZ),y)
package/supertuxkart/Config.in: select BR2_PACKAGE_HARFBUZZ
package/vlc/vlc.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
package/webkitgtk/Config.in:    select BR2_PACKAGE_HARFBUZZ
package/wpewebkit/Config.in:    select BR2_PACKAGE_HARFBUZZ

So I would suggest to create a configuration that builds all those
packages successfully prior to the harfbuzz bump, and then retry this
configuration with the harfbuzz bump applied. This will give you a
sense of how much breakage the API changes are causing.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] Harfbuzz bump major version question
  2021-09-20  6:41 ` Thomas Petazzoni
@ 2021-09-20  9:00   ` Arnout Vandecappelle
  2021-09-20 11:15     ` Giulio Benetti
  2021-09-20 11:11   ` Giulio Benetti
  2021-09-20 19:12   ` [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0 Giulio Benetti
  2 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2021-09-20  9:00 UTC (permalink / raw)
  To: Thomas Petazzoni, Giulio Benetti; +Cc: Yann E. MORIN, Buildroot Mailing List



On 20/09/2021 08:41, Thomas Petazzoni wrote:
> Hello Giulio,
> 
> On Sun, 19 Sep 2021 23:10:23 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> I'm going to bump harfbuzz to version 3.0.0 but being a major version it
>> looses 15 apis[1] and introduce some new ones. So I'm not that sure if
>> this can be a normal bump or I need to introduce the new package
>> harfbuzz3. Package pango that requires harfbuzz builds fine, but how
>> should I proceed? Should I build every package that depends on it and
>> check if it builds fine? Or should I add package harfbuzz3 and then
>> every package that depends on harfbuzz should move to harfbuzz3 package
>> per package? I'm new to this case so help is appreciated.
> 
> The best is to not have to introduce a separate harfbuzz3 package, as
> it really complicates things.
> 
> There are not that many packages that have a dependency on harfbuzz:
> 
> package/efl/efl.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
> package/libass/Config.in:       select BR2_PACKAGE_HARFBUZZ
> package/mupdf/Config.in:        select BR2_PACKAGE_HARFBUZZ
> package/pango/Config.in:        select BR2_PACKAGE_HARFBUZZ
> package/qt5/qt5base/Config.in:config BR2_PACKAGE_QT5BASE_HARFBUZZ
> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_HARFBUZZ if \
> package/qt5/qt5base/qt5base.mk:ifeq ($(BR2_PACKAGE_QT5BASE_HARFBUZZ),y)
> package/supertuxkart/Config.in: select BR2_PACKAGE_HARFBUZZ
> package/vlc/vlc.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
> package/webkitgtk/Config.in:    select BR2_PACKAGE_HARFBUZZ
> package/wpewebkit/Config.in:    select BR2_PACKAGE_HARFBUZZ
> 
> So I would suggest to create a configuration that builds all those
> packages successfully prior to the harfbuzz bump, and then retry this
> configuration with the harfbuzz bump applied. This will give you a
> sense of how much breakage the API changes are causing.

  It would be nice to convert the explanation above into a documentation update!

  Regards,
  Arnout

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] Harfbuzz bump major version question
  2021-09-20  6:41 ` Thomas Petazzoni
  2021-09-20  9:00   ` Arnout Vandecappelle
@ 2021-09-20 11:11   ` Giulio Benetti
  2021-09-20 19:12   ` [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0 Giulio Benetti
  2 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-09-20 11:11 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Yann E. MORIN, Buildroot Mailing List

On 9/20/21 8:41 AM, Thomas Petazzoni wrote:
> Hello Giulio,
> 
> On Sun, 19 Sep 2021 23:10:23 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> I'm going to bump harfbuzz to version 3.0.0 but being a major version it
>> looses 15 apis[1] and introduce some new ones. So I'm not that sure if
>> this can be a normal bump or I need to introduce the new package
>> harfbuzz3. Package pango that requires harfbuzz builds fine, but how
>> should I proceed? Should I build every package that depends on it and
>> check if it builds fine? Or should I add package harfbuzz3 and then
>> every package that depends on harfbuzz should move to harfbuzz3 package
>> per package? I'm new to this case so help is appreciated.
> 
> The best is to not have to introduce a separate harfbuzz3 package, as
> it really complicates things.
> 
> There are not that many packages that have a dependency on harfbuzz:
> 
> package/efl/efl.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
> package/libass/Config.in:       select BR2_PACKAGE_HARFBUZZ
> package/mupdf/Config.in:        select BR2_PACKAGE_HARFBUZZ
> package/pango/Config.in:        select BR2_PACKAGE_HARFBUZZ
> package/qt5/qt5base/Config.in:config BR2_PACKAGE_QT5BASE_HARFBUZZ
> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_HARFBUZZ if \
> package/qt5/qt5base/qt5base.mk:ifeq ($(BR2_PACKAGE_QT5BASE_HARFBUZZ),y)
> package/supertuxkart/Config.in: select BR2_PACKAGE_HARFBUZZ
> package/vlc/vlc.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
> package/webkitgtk/Config.in:    select BR2_PACKAGE_HARFBUZZ
> package/wpewebkit/Config.in:    select BR2_PACKAGE_HARFBUZZ
> 
> So I would suggest to create a configuration that builds all those
> packages successfully prior to the harfbuzz bump, and then retry this
> configuration with the harfbuzz bump applied. This will give you a
> sense of how much breakage the API changes are causing.

Ok, I proceed this way then.

Thank you
Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] Harfbuzz bump major version question
  2021-09-20  9:00   ` Arnout Vandecappelle
@ 2021-09-20 11:15     ` Giulio Benetti
  0 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-09-20 11:15 UTC (permalink / raw)
  To: Arnout Vandecappelle, Thomas Petazzoni
  Cc: Yann E. MORIN, Buildroot Mailing List

On 9/20/21 11:00 AM, Arnout Vandecappelle wrote:
> 
> 
> On 20/09/2021 08:41, Thomas Petazzoni wrote:
>> Hello Giulio,
>>
>> On Sun, 19 Sep 2021 23:10:23 +0200
>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>
>>> I'm going to bump harfbuzz to version 3.0.0 but being a major version it
>>> looses 15 apis[1] and introduce some new ones. So I'm not that sure if
>>> this can be a normal bump or I need to introduce the new package
>>> harfbuzz3. Package pango that requires harfbuzz builds fine, but how
>>> should I proceed? Should I build every package that depends on it and
>>> check if it builds fine? Or should I add package harfbuzz3 and then
>>> every package that depends on harfbuzz should move to harfbuzz3 package
>>> per package? I'm new to this case so help is appreciated.
>>
>> The best is to not have to introduce a separate harfbuzz3 package, as
>> it really complicates things.
>>
>> There are not that many packages that have a dependency on harfbuzz:
>>
>> package/efl/efl.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
>> package/libass/Config.in:       select BR2_PACKAGE_HARFBUZZ
>> package/mupdf/Config.in:        select BR2_PACKAGE_HARFBUZZ
>> package/pango/Config.in:        select BR2_PACKAGE_HARFBUZZ
>> package/qt5/qt5base/Config.in:config BR2_PACKAGE_QT5BASE_HARFBUZZ
>> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_HARFBUZZ if \
>> package/qt5/qt5base/qt5base.mk:ifeq ($(BR2_PACKAGE_QT5BASE_HARFBUZZ),y)
>> package/supertuxkart/Config.in: select BR2_PACKAGE_HARFBUZZ
>> package/vlc/vlc.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
>> package/webkitgtk/Config.in:    select BR2_PACKAGE_HARFBUZZ
>> package/wpewebkit/Config.in:    select BR2_PACKAGE_HARFBUZZ
>>
>> So I would suggest to create a configuration that builds all those
>> packages successfully prior to the harfbuzz bump, and then retry this
>> configuration with the harfbuzz bump applied. This will give you a
>> sense of how much breakage the API changes are causing.
> 
>    It would be nice to convert the explanation above into a documentation update!

I could add 'Updating a package' under 'III. Developer guide' in the 
manual on the same level of 'Adding new packages to Buildroot', does it 
sound good?

I've never contributed to the manual.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>    Regards,
>    Arnout
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0
  2021-09-20  6:41 ` Thomas Petazzoni
  2021-09-20  9:00   ` Arnout Vandecappelle
  2021-09-20 11:11   ` Giulio Benetti
@ 2021-09-20 19:12   ` Giulio Benetti
  2021-09-26 21:43     ` Arnout Vandecappelle
  2 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2021-09-20 19:12 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Thomas Petazzoni

This major version introduces 16 new APIs[1] and remove 20 of them
considered unstable[2]. All packages that depends on harfbuzz build
correctly with this new version because they don't use the "old unstable"
APIs.

[1]: https://github.com/harfbuzz/harfbuzz/blob/main/NEWS#L11-L27
[2]: https://github.com/harfbuzz/harfbuzz/blob/main/NEWS#L29-L49

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/harfbuzz/harfbuzz.hash | 2 +-
 package/harfbuzz/harfbuzz.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/harfbuzz/harfbuzz.hash b/package/harfbuzz/harfbuzz.hash
index c00195cba6..97fc5a2c5f 100644
--- a/package/harfbuzz/harfbuzz.hash
+++ b/package/harfbuzz/harfbuzz.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  0edcc980f526a338452180e701d6aba6323aef457b6686976a7d17ccbddc51cf  harfbuzz-2.9.1.tar.xz
+sha256  036b0ee118451539783ec7864148bb4106be42a2eb964df4e83e6703ec46f3d9  harfbuzz-3.0.0.tar.xz
 sha256  4345e1735f8bc6d812fed5180cabb5a5e88a4109d332652f2a45c13cfa5ee692  COPYING
diff --git a/package/harfbuzz/harfbuzz.mk b/package/harfbuzz/harfbuzz.mk
index 70c1e1f7e6..4534d166ef 100644
--- a/package/harfbuzz/harfbuzz.mk
+++ b/package/harfbuzz/harfbuzz.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-HARFBUZZ_VERSION = 2.9.1
+HARFBUZZ_VERSION = 3.0.0
 HARFBUZZ_SITE = https://github.com/harfbuzz/harfbuzz/releases/download/$(HARFBUZZ_VERSION)
 HARFBUZZ_SOURCE = harfbuzz-$(HARFBUZZ_VERSION).tar.xz
 HARFBUZZ_LICENSE = MIT, ISC (ucdn library)
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0
  2021-09-20 19:12   ` [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0 Giulio Benetti
@ 2021-09-26 21:43     ` Arnout Vandecappelle
  0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2021-09-26 21:43 UTC (permalink / raw)
  To: Giulio Benetti, buildroot; +Cc: Thomas Petazzoni



On 20/09/2021 21:12, Giulio Benetti wrote:
> This major version introduces 16 new APIs[1] and remove 20 of them
> considered unstable[2]. All packages that depends on harfbuzz build
> correctly with this new version because they don't use the "old unstable"
> APIs.
> 
> [1]: https://github.com/harfbuzz/harfbuzz/blob/main/NEWS#L11-L27
> [2]: https://github.com/harfbuzz/harfbuzz/blob/main/NEWS#L29-L49
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

  Applied to master, thanks. Let's see if the autobuilders complain :-)

  Regards,
  Arnout

> ---
>   package/harfbuzz/harfbuzz.hash | 2 +-
>   package/harfbuzz/harfbuzz.mk   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/harfbuzz/harfbuzz.hash b/package/harfbuzz/harfbuzz.hash
> index c00195cba6..97fc5a2c5f 100644
> --- a/package/harfbuzz/harfbuzz.hash
> +++ b/package/harfbuzz/harfbuzz.hash
> @@ -1,3 +1,3 @@
>   # Locally computed
> -sha256  0edcc980f526a338452180e701d6aba6323aef457b6686976a7d17ccbddc51cf  harfbuzz-2.9.1.tar.xz
> +sha256  036b0ee118451539783ec7864148bb4106be42a2eb964df4e83e6703ec46f3d9  harfbuzz-3.0.0.tar.xz
>   sha256  4345e1735f8bc6d812fed5180cabb5a5e88a4109d332652f2a45c13cfa5ee692  COPYING
> diff --git a/package/harfbuzz/harfbuzz.mk b/package/harfbuzz/harfbuzz.mk
> index 70c1e1f7e6..4534d166ef 100644
> --- a/package/harfbuzz/harfbuzz.mk
> +++ b/package/harfbuzz/harfbuzz.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -HARFBUZZ_VERSION = 2.9.1
> +HARFBUZZ_VERSION = 3.0.0
>   HARFBUZZ_SITE = https://github.com/harfbuzz/harfbuzz/releases/download/$(HARFBUZZ_VERSION)
>   HARFBUZZ_SOURCE = harfbuzz-$(HARFBUZZ_VERSION).tar.xz
>   HARFBUZZ_LICENSE = MIT, ISC (ucdn library)
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-26 21:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 21:10 [Buildroot] Harfbuzz bump major version question Giulio Benetti
2021-09-20  6:41 ` Thomas Petazzoni
2021-09-20  9:00   ` Arnout Vandecappelle
2021-09-20 11:15     ` Giulio Benetti
2021-09-20 11:11   ` Giulio Benetti
2021-09-20 19:12   ` [Buildroot] [PATCH] package/harfbuzz: bump to version 3.0.0 Giulio Benetti
2021-09-26 21:43     ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.