All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Alessandro Zummo <a.zummo@towertech.it>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-rtc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH V2 2/2] rtc: Introduce ti-k3-rtc
Date: Tue, 10 May 2022 19:52:57 -0500	[thread overview]
Message-ID: <92aa19b5-0e6e-057f-9dd8-becd7733d1f0@ti.com> (raw)
In-Reply-To: <20220511002600.27964-3-nm@ti.com>

On 5/10/22 7:25 PM, Nishanth Menon wrote:
> Introduce support for Texas Instruments Real Time Clock controller on
> newer K3 family of SoCs such as AM62x.
> 
> The hardware module that is being supported is the "digital only"
> version which does'nt have capability of external wakeup sources and
> external power backup. However, for many practical applications, this
> should suffice as RTC is operational across low power sequences.
> 
> The hardware block by itself is split into two distinct domains
> internally to further reduce the power consumption with the actual
> counter block and comparators clocked off a 32k clock source (which
> based on SoC integration can be sourced by an external crystal) and an
> register interface block which is driven by the bus clock. While optimal
> from power perspective, it does create some complicated synchronizations
> and sequences that one must be wary of in the driver handling.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V1:
> (Andrew's comments):
> * Moved entirely to regmap fields - except for setting time, which I
>    have documented as to why regmap is necessary
> * Dropped the redundant MOD_ALIAS

Isn't regmap fun :)

Acked-by: Andrew Davis <afd@ti.com>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Alessandro Zummo <a.zummo@towertech.it>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-rtc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH V2 2/2] rtc: Introduce ti-k3-rtc
Date: Tue, 10 May 2022 19:52:57 -0500	[thread overview]
Message-ID: <92aa19b5-0e6e-057f-9dd8-becd7733d1f0@ti.com> (raw)
In-Reply-To: <20220511002600.27964-3-nm@ti.com>

On 5/10/22 7:25 PM, Nishanth Menon wrote:
> Introduce support for Texas Instruments Real Time Clock controller on
> newer K3 family of SoCs such as AM62x.
> 
> The hardware module that is being supported is the "digital only"
> version which does'nt have capability of external wakeup sources and
> external power backup. However, for many practical applications, this
> should suffice as RTC is operational across low power sequences.
> 
> The hardware block by itself is split into two distinct domains
> internally to further reduce the power consumption with the actual
> counter block and comparators clocked off a 32k clock source (which
> based on SoC integration can be sourced by an external crystal) and an
> register interface block which is driven by the bus clock. While optimal
> from power perspective, it does create some complicated synchronizations
> and sequences that one must be wary of in the driver handling.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V1:
> (Andrew's comments):
> * Moved entirely to regmap fields - except for setting time, which I
>    have documented as to why regmap is necessary
> * Dropped the redundant MOD_ALIAS

Isn't regmap fun :)

Acked-by: Andrew Davis <afd@ti.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-11  0:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  0:25 [PATCH V2 0/2] rtc: Introduce rtc-ti-k3 Nishanth Menon
2022-05-11  0:25 ` Nishanth Menon
2022-05-11  0:25 ` [PATCH V2 1/2] dt-bindings: rtc: Add TI K3 RTC description Nishanth Menon
2022-05-11  0:25   ` Nishanth Menon
2022-05-11 16:28   ` Krzysztof Kozlowski
2022-05-11 16:28     ` Krzysztof Kozlowski
2022-05-11 19:38     ` Nishanth Menon
2022-05-11 19:38       ` Nishanth Menon
2022-05-12 10:12       ` Krzysztof Kozlowski
2022-05-12 10:12         ` Krzysztof Kozlowski
2022-05-11  0:25 ` [PATCH V2 2/2] rtc: Introduce ti-k3-rtc Nishanth Menon
2022-05-11  0:25   ` Nishanth Menon
2022-05-11  0:52   ` Andrew Davis [this message]
2022-05-11  0:52     ` Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92aa19b5-0e6e-057f-9dd8-becd7733d1f0@ti.com \
    --to=afd@ti.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.