All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: accel: mma8452: Add missing documentation for name element of chip_info
@ 2022-04-10 15:33 Jonathan Cameron
  2022-04-11  7:41 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2022-04-10 15:33 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron, Hans de Goede

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Documentation needed to avoid build warning with W=1 builds. It doesn't
really add any non obvious information but good to have it anyway.

No fixes tag as not worth backporting onto the fix that added the name
element to the structure.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/iio/accel/mma8452.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 9c02c681c84c..912a447e6310 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -166,6 +166,7 @@ static const struct mma8452_event_regs trans_ev_regs = {
 
 /**
  * struct mma_chip_info - chip specific data
+ * @name:			part number of device reported via 'name' attr
  * @chip_id:			WHO_AM_I register's value
  * @channels:			struct iio_chan_spec matching the device's
  *				capabilities
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: accel: mma8452: Add missing documentation for name element of chip_info
  2022-04-10 15:33 [PATCH] iio: accel: mma8452: Add missing documentation for name element of chip_info Jonathan Cameron
@ 2022-04-11  7:41 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-04-11  7:41 UTC (permalink / raw)
  To: Jonathan Cameron, linux-iio; +Cc: Jonathan Cameron

Hi,

For some reason your email is seen by my thunderbird as haivng an empty body +
a nameless attachment with the patch... ?

So no quote of the patch here.

With that said, thank you for the patch and the patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-11  7:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-10 15:33 [PATCH] iio: accel: mma8452: Add missing documentation for name element of chip_info Jonathan Cameron
2022-04-11  7:41 ` Hans de Goede

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.