* [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement
@ 2019-02-14 9:34 Kazuo Ito
2019-02-21 22:33 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Kazuo Ito @ 2019-02-14 9:34 UTC (permalink / raw)
To: Trond Myklebust, anna.schumaker, linux-nfs, konishi.ryusuke,
OS渡辺
This set of patches attempt to fix potential data integrity problem
in nfs_want_read_modify_write() and improve full page overwrite
performance of pNFS block/SCSI layouts.
The patch set comprises of two patches:
- 1/2 "pNFS: Fix potential corruption of page being written"
fixes the integrity issue
- 2/2 "pNFS: Avoid read/modify/write when it is not necessary"
addresses the cases where read/modify/write was requested for a full-
page write.
v1 -> v2:
- added the fix for missing PagePrivate in the pNFS block layout
- made the check for full page write a separate inline function
- merged the duplicated code for the pNFS block/SCSI layouts and
for the other layout + normal NFS
- type usage clean up (int to bool, unsigned to unsigned int)
kazuo ito (2):
pNFS: Fix potential corruption of page being written
pNFS: Avoid read/modify/write when it is not necessary
fs/nfs/file.c | 40 ++++++++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 14 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement
2019-02-14 9:34 [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement Kazuo Ito
@ 2019-02-21 22:33 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2019-02-21 22:33 UTC (permalink / raw)
To: anna.schumaker, ito_kazuo_g3, linux-nfs, konishi.ryusuke,
watanabe.hiroyuki
On Thu, 2019-02-14 at 18:34 +0900, Kazuo Ito wrote:
> This set of patches attempt to fix potential data integrity problem
> in nfs_want_read_modify_write() and improve full page overwrite
> performance of pNFS block/SCSI layouts.
>
> The patch set comprises of two patches:
> - 1/2 "pNFS: Fix potential corruption of page being written"
> fixes the integrity issue
> - 2/2 "pNFS: Avoid read/modify/write when it is not necessary"
> addresses the cases where read/modify/write was requested for a
> full-
> page write.
>
> v1 -> v2:
> - added the fix for missing PagePrivate in the pNFS block layout
> - made the check for full page write a separate inline function
> - merged the duplicated code for the pNFS block/SCSI layouts and
> for the other layout + normal NFS
> - type usage clean up (int to bool, unsigned to unsigned int)
>
> kazuo ito (2):
> pNFS: Fix potential corruption of page being written
> pNFS: Avoid read/modify/write when it is not necessary
>
> fs/nfs/file.c | 40 ++++++++++++++++++++++++++--------------
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
These look good so I've applied them to the linux-next branch for the
5.1 merge window,
Thanks!
Trond
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-21 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 9:34 [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement Kazuo Ito
2019-02-21 22:33 ` Trond Myklebust
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.