* [linux-next:master 2417/10784] drivers/video/console/newport_con.c:362:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean
@ 2020-07-24 5:57 kernel test robot
2020-07-24 6:27 ` Jiri Slaby
0 siblings, 1 reply; 19+ messages in thread
From: kernel test robot @ 2020-07-24 5:57 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5006 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4f5baedd579d5499876eadb1de12ddfdadcaa3ab
commit: 28bc24fc46f9c9f39ddefb424d6072041805b563 [2417/10784] vc: separate state
config: mips-randconfig-r004-20200724 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 28bc24fc46f9c9f39ddefb424d6072041805b563
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/video/console/newport_con.c: In function 'newport_show_logo':
drivers/video/console/newport_con.c:132:1: warning: no return statement in function returning non-void [-Wreturn-type]
132 | }
| ^
drivers/video/console/newport_con.c: In function 'newport_clear':
>> drivers/video/console/newport_con.c:362:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean 'vc_cols'?
362 | (vc->vc_color & 0xf0) >> 4);
| ^~~~~~~~
| vc_cols
drivers/video/console/newport_con.c:365:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean 'vc_cols'?
365 | (vc->vc_color & 0xf0) >> 4);
| ^~~~~~~~
| vc_cols
drivers/video/console/newport_con.c:367:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean 'vc_cols'?
367 | (vc->vc_color & 0xf0) >> 4);
| ^~~~~~~~
| vc_cols
drivers/video/console/newport_con.c: In function 'newport_scroll':
drivers/video/console/newport_con.c:591:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean 'vc_cols'?
591 | (vc->vc_color & 0xf0) >> 4);
| ^~~~~~~~
| vc_cols
drivers/video/console/newport_con.c:595:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean 'vc_cols'?
595 | (vc->vc_color & 0xf0) >> 4);
| ^~~~~~~~
| vc_cols
drivers/video/console/newport_con.c: At top level:
drivers/video/console/newport_con.c:745:12: warning: no previous prototype for 'newport_console_init' [-Wmissing-prototypes]
745 | int __init newport_console_init(void)
| ^~~~~~~~~~~~~~~~~~~~
drivers/video/console/newport_con.c:750:13: warning: no previous prototype for 'newport_console_exit' [-Wmissing-prototypes]
750 | void __exit newport_console_exit(void)
| ^~~~~~~~~~~~~~~~~~~~
vim +362 drivers/video/console/newport_con.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 349
^1da177e4c3f415 Linus Torvalds 2005-04-16 350 static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
^1da177e4c3f415 Linus Torvalds 2005-04-16 351 int width)
^1da177e4c3f415 Linus Torvalds 2005-04-16 352 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 353 int xend = ((sx + width) << 3) - 1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 354 int ystart = ((sy << 4) + topscan) & 0x3ff;
^1da177e4c3f415 Linus Torvalds 2005-04-16 355 int yend = (((sy + height) << 4) + topscan - 1) & 0x3ff;
^1da177e4c3f415 Linus Torvalds 2005-04-16 356
^1da177e4c3f415 Linus Torvalds 2005-04-16 357 if (logo_active)
^1da177e4c3f415 Linus Torvalds 2005-04-16 358 return;
^1da177e4c3f415 Linus Torvalds 2005-04-16 359
^1da177e4c3f415 Linus Torvalds 2005-04-16 360 if (ystart < yend) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 361 newport_clear_screen(sx << 3, ystart, xend, yend,
^1da177e4c3f415 Linus Torvalds 2005-04-16 @362 (vc->vc_color & 0xf0) >> 4);
^1da177e4c3f415 Linus Torvalds 2005-04-16 363 } else {
^1da177e4c3f415 Linus Torvalds 2005-04-16 364 newport_clear_screen(sx << 3, ystart, xend, 1023,
^1da177e4c3f415 Linus Torvalds 2005-04-16 365 (vc->vc_color & 0xf0) >> 4);
^1da177e4c3f415 Linus Torvalds 2005-04-16 366 newport_clear_screen(sx << 3, 0, xend, yend,
^1da177e4c3f415 Linus Torvalds 2005-04-16 367 (vc->vc_color & 0xf0) >> 4);
^1da177e4c3f415 Linus Torvalds 2005-04-16 368 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 369 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 370
:::::: The code at line 362 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21416 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] newport_con: vc_color is now in state
2020-07-24 5:57 [linux-next:master 2417/10784] drivers/video/console/newport_con.c:362:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean kernel test robot
2020-07-24 6:27 ` Jiri Slaby
@ 2020-07-24 6:27 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 6:27 UTC (permalink / raw)
To: gregkh
Cc: linux-serial, linux-kernel, Jiri Slaby,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-mips
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
vc->state.color. Somehow both me and 0-day bot missed this driver during
the conversion.
So fix the driver now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-mips@vger.kernel.org
---
drivers/video/console/newport_con.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index df3c52d72159..72f146d047d9 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -362,12 +362,12 @@ static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
if (ystart < yend) {
newport_clear_screen(sx << 3, ystart, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
newport_clear_screen(sx << 3, ystart, xend, 1023,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
newport_clear_screen(sx << 3, 0, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
}
@@ -591,11 +591,11 @@ static bool newport_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
topscan = (topscan + (lines << 4)) & 0x3ff;
newport_clear_lines(vc->vc_rows - lines,
vc->vc_rows - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
topscan = (topscan + (-lines << 4)) & 0x3ff;
newport_clear_lines(0, lines - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
npregs->cset.topscan = (topscan - 1) & 0x3ff;
return false;
--
2.27.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 6:27 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 6:27 UTC (permalink / raw)
To: gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel,
linux-mips, linux-serial, Jiri Slaby
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
vc->state.color. Somehow both me and 0-day bot missed this driver during
the conversion.
So fix the driver now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-mips@vger.kernel.org
---
drivers/video/console/newport_con.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index df3c52d72159..72f146d047d9 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -362,12 +362,12 @@ static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
if (ystart < yend) {
newport_clear_screen(sx << 3, ystart, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
newport_clear_screen(sx << 3, ystart, xend, 1023,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
newport_clear_screen(sx << 3, 0, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
}
@@ -591,11 +591,11 @@ static bool newport_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
topscan = (topscan + (lines << 4)) & 0x3ff;
newport_clear_lines(vc->vc_rows - lines,
vc->vc_rows - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
topscan = (topscan + (-lines << 4)) & 0x3ff;
newport_clear_lines(0, lines - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
npregs->cset.topscan = (topscan - 1) & 0x3ff;
return false;
--
2.27.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 6:27 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 6:27 UTC (permalink / raw)
To: gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel,
linux-mips, linux-serial, Jiri Slaby
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
vc->state.color. Somehow both me and 0-day bot missed this driver during
the conversion.
So fix the driver now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-mips@vger.kernel.org
---
drivers/video/console/newport_con.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index df3c52d72159..72f146d047d9 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -362,12 +362,12 @@ static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
if (ystart < yend) {
newport_clear_screen(sx << 3, ystart, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
newport_clear_screen(sx << 3, ystart, xend, 1023,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
newport_clear_screen(sx << 3, 0, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
}
@@ -591,11 +591,11 @@ static bool newport_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
topscan = (topscan + (lines << 4)) & 0x3ff;
newport_clear_lines(vc->vc_rows - lines,
vc->vc_rows - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
topscan = (topscan + (-lines << 4)) & 0x3ff;
newport_clear_lines(0, lines - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
npregs->cset.topscan = (topscan - 1) & 0x3ff;
return false;
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 6:27 ` Jiri Slaby
(?)
@ 2020-07-24 7:58 ` Greg KH
-1 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 7:58 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
> ---
> drivers/video/console/newport_con.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
You forgot the "Reported-by:" line :(
I'll go add it, thanks for the fix.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 7:58 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 7:58 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
> ---
> drivers/video/console/newport_con.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
You forgot the "Reported-by:" line :(
I'll go add it, thanks for the fix.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 7:58 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 7:58 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
> ---
> drivers/video/console/newport_con.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
You forgot the "Reported-by:" line :(
I'll go add it, thanks for the fix.
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 7:58 ` Greg KH
(?)
@ 2020-07-24 7:59 ` Jiri Slaby
-1 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 7:59 UTC (permalink / raw)
To: Greg KH
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24. 07. 20, 9:58, Greg KH wrote:
> On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>> vc->state.color. Somehow both me and 0-day bot missed this driver during
>> the conversion.
>>
>> So fix the driver now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: linux-mips@vger.kernel.org
>> ---
>> drivers/video/console/newport_con.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> You forgot the "Reported-by:" line :(
Ah, I didn't know/notice. Will do next time. Thanks.
--
js
suse labs
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 7:59 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 7:59 UTC (permalink / raw)
To: Greg KH
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24. 07. 20, 9:58, Greg KH wrote:
> On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>> vc->state.color. Somehow both me and 0-day bot missed this driver during
>> the conversion.
>>
>> So fix the driver now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: linux-mips@vger.kernel.org
>> ---
>> drivers/video/console/newport_con.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> You forgot the "Reported-by:" line :(
Ah, I didn't know/notice. Will do next time. Thanks.
--
js
suse labs
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 7:59 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 7:59 UTC (permalink / raw)
To: Greg KH
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24. 07. 20, 9:58, Greg KH wrote:
> On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>> vc->state.color. Somehow both me and 0-day bot missed this driver during
>> the conversion.
>>
>> So fix the driver now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: linux-mips@vger.kernel.org
>> ---
>> drivers/video/console/newport_con.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> You forgot the "Reported-by:" line :(
Ah, I didn't know/notice. Will do next time. Thanks.
--
js
suse labs
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 6:27 ` Jiri Slaby
(?)
@ 2020-07-24 9:30 ` Sergei Shtylyov
-1 siblings, 0 replies; 19+ messages in thread
From: Sergei Shtylyov @ 2020-07-24 9:30 UTC (permalink / raw)
To: Jiri Slaby, gregkh
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24.07.2020 9:27, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
enclose the commit summary in (""), not just ()...
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 9:30 ` Sergei Shtylyov
0 siblings, 0 replies; 19+ messages in thread
From: Sergei Shtylyov @ 2020-07-24 9:30 UTC (permalink / raw)
To: Jiri Slaby, gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24.07.2020 9:27, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
enclose the commit summary in (""), not just ()...
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 9:30 ` Sergei Shtylyov
0 siblings, 0 replies; 19+ messages in thread
From: Sergei Shtylyov @ 2020-07-24 9:30 UTC (permalink / raw)
To: Jiri Slaby, gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24.07.2020 9:27, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
enclose the commit summary in (""), not just ()...
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
[...]
MBR, Sergei
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 9:30 ` Sergei Shtylyov
(?)
@ 2020-07-24 9:38 ` Greg KH
-1 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 9:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Jiri Slaby, linux-serial, linux-kernel,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-mips
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
> > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
> enclose the commit summary in (""), not just ()...
I've added the proper "Fixes:" tag when committing this, no worries.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 9:38 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 9:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel,
linux-mips, linux-serial, Jiri Slaby
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
> > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
> enclose the commit summary in (""), not just ()...
I've added the proper "Fixes:" tag when committing this, no worries.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 9:38 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2020-07-24 9:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-kernel, dri-devel,
linux-mips, linux-serial, Jiri Slaby
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
> > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
> enclose the commit summary in (""), not just ()...
I've added the proper "Fixes:" tag when committing this, no worries.
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 9:30 ` Sergei Shtylyov
(?)
@ 2020-07-24 10:30 ` Jiri Slaby
-1 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 10:30 UTC (permalink / raw)
To: Sergei Shtylyov, gregkh
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24. 07. 20, 11:30, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo).
That's because it's not in Linus' repo yet.
--
js
suse labs
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 10:30 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 10:30 UTC (permalink / raw)
To: Sergei Shtylyov, gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24. 07. 20, 11:30, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo).
That's because it's not in Linus' repo yet.
--
js
suse labs
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
@ 2020-07-24 10:30 ` Jiri Slaby
0 siblings, 0 replies; 19+ messages in thread
From: Jiri Slaby @ 2020-07-24 10:30 UTC (permalink / raw)
To: Sergei Shtylyov, gregkh
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, linux-mips, dri-devel,
linux-kernel, linux-serial
On 24. 07. 20, 11:30, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo).
That's because it's not in Linus' repo yet.
--
js
suse labs
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-07-26 15:03 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 5:57 [linux-next:master 2417/10784] drivers/video/console/newport_con.c:362:15: error: 'struct vc_data' has no member named 'vc_color'; did you mean kernel test robot
2020-07-24 6:27 ` [PATCH] newport_con: vc_color is now in state Jiri Slaby
2020-07-24 6:27 ` Jiri Slaby
2020-07-24 6:27 ` Jiri Slaby
2020-07-24 7:58 ` Greg KH
2020-07-24 7:58 ` Greg KH
2020-07-24 7:58 ` Greg KH
2020-07-24 7:59 ` Jiri Slaby
2020-07-24 7:59 ` Jiri Slaby
2020-07-24 7:59 ` Jiri Slaby
2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:38 ` Greg KH
2020-07-24 9:38 ` Greg KH
2020-07-24 9:38 ` Greg KH
2020-07-24 10:30 ` Jiri Slaby
2020-07-24 10:30 ` Jiri Slaby
2020-07-24 10:30 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.