* [PATCH, trivial, for-6.1] spelling: sytem => system
@ 2021-08-18 14:06 Michael Tokarev
2021-08-18 14:17 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael Tokarev @ 2021-08-18 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev
Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
---
It is safe for 6.1
block/file-posix.c | 2 +-
tools/virtiofsd/fuse_lowlevel.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index cb9bffe047..1854bfa397 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1705,7 +1705,7 @@ static int handle_aiocb_write_zeroes(void *opaque)
*/
warn_report_once("Your file system is misbehaving: "
"fallocate(FALLOC_FL_PUNCH_HOLE) returned EINVAL. "
- "Please report this bug to your file sytem "
+ "Please report this bug to your file system "
"vendor.");
} else if (ret != -ENOTSUP) {
return ret;
diff --git a/tools/virtiofsd/fuse_lowlevel.h b/tools/virtiofsd/fuse_lowlevel.h
index 4b4e8c9724..c55c0ca2fc 100644
--- a/tools/virtiofsd/fuse_lowlevel.h
+++ b/tools/virtiofsd/fuse_lowlevel.h
@@ -1603,7 +1603,7 @@ int fuse_lowlevel_notify_inval_inode(struct fuse_session *se, fuse_ino_t ino,
* parent/name
*
* To avoid a deadlock this function must not be called in the
- * execution path of a related filesytem operation or within any code
+ * execution path of a related filesystem operation or within any code
* that could hold a lock that could be needed to execute such an
* operation. As of kernel 4.18, a "related operation" is a lookup(),
* symlink(), mknod(), mkdir(), unlink(), rename(), link() or create()
@@ -1636,7 +1636,7 @@ int fuse_lowlevel_notify_inval_entry(struct fuse_session *se, fuse_ino_t parent,
* that the dentry has been deleted.
*
* To avoid a deadlock this function must not be called while
- * executing a related filesytem operation or while holding a lock
+ * executing a related filesystem operation or while holding a lock
* that could be needed to execute such an operation (see the
* description of fuse_lowlevel_notify_inval_entry() for more
* details).
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH, trivial, for-6.1] spelling: sytem => system
2021-08-18 14:06 [PATCH, trivial, for-6.1] spelling: sytem => system Michael Tokarev
@ 2021-08-18 14:17 ` Laurent Vivier
2021-08-18 14:28 ` Philippe Mathieu-Daudé
2021-09-15 13:52 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-08-18 14:17 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial
Le 18/08/2021 à 16:06, Michael Tokarev a écrit :
> Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
> ---
> It is safe for 6.1
>
> block/file-posix.c | 2 +-
> tools/virtiofsd/fuse_lowlevel.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index cb9bffe047..1854bfa397 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -1705,7 +1705,7 @@ static int handle_aiocb_write_zeroes(void *opaque)
> */
> warn_report_once("Your file system is misbehaving: "
> "fallocate(FALLOC_FL_PUNCH_HOLE) returned EINVAL. "
> - "Please report this bug to your file sytem "
> + "Please report this bug to your file system "
> "vendor.");
> } else if (ret != -ENOTSUP) {
> return ret;
> diff --git a/tools/virtiofsd/fuse_lowlevel.h b/tools/virtiofsd/fuse_lowlevel.h
> index 4b4e8c9724..c55c0ca2fc 100644
> --- a/tools/virtiofsd/fuse_lowlevel.h
> +++ b/tools/virtiofsd/fuse_lowlevel.h
> @@ -1603,7 +1603,7 @@ int fuse_lowlevel_notify_inval_inode(struct fuse_session *se, fuse_ino_t ino,
> * parent/name
> *
> * To avoid a deadlock this function must not be called in the
> - * execution path of a related filesytem operation or within any code
> + * execution path of a related filesystem operation or within any code
> * that could hold a lock that could be needed to execute such an
> * operation. As of kernel 4.18, a "related operation" is a lookup(),
> * symlink(), mknod(), mkdir(), unlink(), rename(), link() or create()
> @@ -1636,7 +1636,7 @@ int fuse_lowlevel_notify_inval_entry(struct fuse_session *se, fuse_ino_t parent,
> * that the dentry has been deleted.
> *
> * To avoid a deadlock this function must not be called while
> - * executing a related filesytem operation or while holding a lock
> + * executing a related filesystem operation or while holding a lock
> * that could be needed to execute such an operation (see the
> * description of fuse_lowlevel_notify_inval_entry() for more
> * details).
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
I think it's a bit late for 6.1... even if it's safe, it's not really critical and can wait.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH, trivial, for-6.1] spelling: sytem => system
2021-08-18 14:06 [PATCH, trivial, for-6.1] spelling: sytem => system Michael Tokarev
2021-08-18 14:17 ` Laurent Vivier
@ 2021-08-18 14:28 ` Philippe Mathieu-Daudé
2021-09-15 13:52 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-18 14:28 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial
On 8/18/21 4:06 PM, Michael Tokarev wrote:
> Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
> ---
> It is safe for 6.1
But too late ;)
>
> block/file-posix.c | 2 +-
> tools/virtiofsd/fuse_lowlevel.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, trivial, for-6.1] spelling: sytem => system
2021-08-18 14:06 [PATCH, trivial, for-6.1] spelling: sytem => system Michael Tokarev
2021-08-18 14:17 ` Laurent Vivier
2021-08-18 14:28 ` Philippe Mathieu-Daudé
@ 2021-09-15 13:52 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-09-15 13:52 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial
Le 18/08/2021 à 16:06, Michael Tokarev a écrit :
> Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
> ---
> It is safe for 6.1
>
> block/file-posix.c | 2 +-
> tools/virtiofsd/fuse_lowlevel.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index cb9bffe047..1854bfa397 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -1705,7 +1705,7 @@ static int handle_aiocb_write_zeroes(void *opaque)
> */
> warn_report_once("Your file system is misbehaving: "
> "fallocate(FALLOC_FL_PUNCH_HOLE) returned EINVAL. "
> - "Please report this bug to your file sytem "
> + "Please report this bug to your file system "
> "vendor.");
> } else if (ret != -ENOTSUP) {
> return ret;
> diff --git a/tools/virtiofsd/fuse_lowlevel.h b/tools/virtiofsd/fuse_lowlevel.h
> index 4b4e8c9724..c55c0ca2fc 100644
> --- a/tools/virtiofsd/fuse_lowlevel.h
> +++ b/tools/virtiofsd/fuse_lowlevel.h
> @@ -1603,7 +1603,7 @@ int fuse_lowlevel_notify_inval_inode(struct fuse_session *se, fuse_ino_t ino,
> * parent/name
> *
> * To avoid a deadlock this function must not be called in the
> - * execution path of a related filesytem operation or within any code
> + * execution path of a related filesystem operation or within any code
> * that could hold a lock that could be needed to execute such an
> * operation. As of kernel 4.18, a "related operation" is a lookup(),
> * symlink(), mknod(), mkdir(), unlink(), rename(), link() or create()
> @@ -1636,7 +1636,7 @@ int fuse_lowlevel_notify_inval_entry(struct fuse_session *se, fuse_ino_t parent,
> * that the dentry has been deleted.
> *
> * To avoid a deadlock this function must not be called while
> - * executing a related filesytem operation or while holding a lock
> + * executing a related filesystem operation or while holding a lock
> * that could be needed to execute such an operation (see the
> * description of fuse_lowlevel_notify_inval_entry() for more
> * details).
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-15 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 14:06 [PATCH, trivial, for-6.1] spelling: sytem => system Michael Tokarev
2021-08-18 14:17 ` Laurent Vivier
2021-08-18 14:28 ` Philippe Mathieu-Daudé
2021-09-15 13:52 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.