* [PATCH] wil6210: remove set but not used variable 'wdev'
2018-09-11 12:32 ` YueHaibing
@ 2018-12-05 7:59 ` YueHaibing
-1 siblings, 0 replies; 13+ messages in thread
From: YueHaibing @ 2018-12-05 7:59 UTC (permalink / raw)
To: Maya Erez, Kalle Valo
Cc: YueHaibing, linux-wireless, wil6210, netdev, linux-kernel,
kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
variable 'wdev' set but not used [-Wunused-but-set-variable]
It never used since commit ("e1b43407c034 wil6210: refactor disconnect flow")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/ath/wil6210/main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index ba6a2ee..5b7de00 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -404,7 +404,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
{
struct wil6210_priv *wil;
struct net_device *ndev;
- struct wireless_dev *wdev;
int cid = -ENOENT;
if (unlikely(!vif))
@@ -412,7 +411,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
wil = vif_to_wil(vif);
ndev = vif_to_ndev(vif);
- wdev = vif_to_wdev(vif);
might_sleep();
wil_info(wil, "disconnect bssid=%pM, reason=%d\n", bssid, reason_code);
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH] wil6210: remove set but not used variable 'wdev'
@ 2018-12-05 7:59 ` YueHaibing
0 siblings, 0 replies; 13+ messages in thread
From: YueHaibing @ 2018-12-05 7:59 UTC (permalink / raw)
To: Maya Erez, Kalle Valo
Cc: YueHaibing, linux-wireless, wil6210, netdev, linux-kernel,
kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
variable 'wdev' set but not used [-Wunused-but-set-variable]
It never used since commit ("e1b43407c034 wil6210: refactor disconnect flow")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/ath/wil6210/main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index ba6a2ee..5b7de00 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -404,7 +404,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
{
struct wil6210_priv *wil;
struct net_device *ndev;
- struct wireless_dev *wdev;
int cid = -ENOENT;
if (unlikely(!vif))
@@ -412,7 +411,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
wil = vif_to_wil(vif);
ndev = vif_to_ndev(vif);
- wdev = vif_to_wdev(vif);
might_sleep();
wil_info(wil, "disconnect bssid=%pM, reason=%d\n", bssid, reason_code);
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] wil6210: remove set but not used variable 'wdev'
2018-12-05 7:59 ` YueHaibing
@ 2018-12-08 18:08 ` merez
-1 siblings, 0 replies; 13+ messages in thread
From: merez @ 2018-12-08 18:08 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, linux-wireless, wil6210, netdev, linux-kernel,
kernel-janitors, linux-wireless-owner
On 2018-12-05 09:59, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/main.c: In function
> '_wil6210_disconnect':
> drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
> variable 'wdev' set but not used [-Wunused-but-set-variable]
>
> It never used since commit ("e1b43407c034 wil6210: refactor disconnect
> flow")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/ath/wil6210/main.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] wil6210: remove set but not used variable 'wdev'
@ 2018-12-08 18:08 ` merez
0 siblings, 0 replies; 13+ messages in thread
From: merez @ 2018-12-08 18:08 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, linux-wireless, wil6210, netdev, linux-kernel,
kernel-janitors, linux-wireless-owner
On 2018-12-05 09:59, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/main.c: In function
> '_wil6210_disconnect':
> drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
> variable 'wdev' set but not used [-Wunused-but-set-variable]
>
> It never used since commit ("e1b43407c034 wil6210: refactor disconnect
> flow")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/ath/wil6210/main.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wil6210: remove set but not used variable 'wdev'
2018-12-05 7:59 ` YueHaibing
@ 2018-12-20 7:45 ` Kalle Valo
-1 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2018-12-20 7:45 UTC (permalink / raw)
To: YueHaibing
Cc: Maya Erez, YueHaibing, linux-wireless, wil6210, netdev,
linux-kernel, kernel-janitors
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
> drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
> variable 'wdev' set but not used [-Wunused-but-set-variable]
>
> It never used since commit ("e1b43407c034 wil6210: refactor disconnect flow")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
3fe970e76b37 wil6210: remove set but not used variable 'wdev'
--
https://patchwork.kernel.org/patch/10713127/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] wil6210: remove set but not used variable 'start'
@ 2018-09-11 12:32 ` YueHaibing
0 siblings, 0 replies; 13+ messages in thread
From: YueHaibing @ 2018-09-11 12:32 UTC (permalink / raw)
To: Maya Erez, Kalle Valo
Cc: YueHaibing, linux-wireless, wil6210, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/ath/wil6210/pm.c: In function 'wil_suspend_keep_radio_on':
drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
variable 'start' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/ath/wil6210/pm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/pm.c b/drivers/net/wireless/ath/wil6210/pm.c
index 3a41947..75fe932 100644
--- a/drivers/net/wireless/ath/wil6210/pm.c
+++ b/drivers/net/wireless/ath/wil6210/pm.c
@@ -190,7 +190,7 @@ static int wil_resume_keep_radio_on(struct wil6210_priv *wil)
static int wil_suspend_keep_radio_on(struct wil6210_priv *wil)
{
int rc = 0;
- unsigned long start, data_comp_to;
+ unsigned long data_comp_to;
wil_dbg_pm(wil, "suspend keep radio on\n");
@@ -232,7 +232,6 @@ static int wil_suspend_keep_radio_on(struct wil6210_priv *wil)
}
/* Wait for completion of the pending RX packets */
- start = jiffies;
data_comp_to = jiffies + msecs_to_jiffies(WIL_DATA_COMPLETION_TO_MS);
if (test_bit(wil_status_napi_en, wil->status)) {
while (!wil->txrx_ops.is_rx_idle(wil)) {
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH] wil6210: remove set but not used variable 'start'
@ 2018-09-11 12:32 ` YueHaibing
0 siblings, 0 replies; 13+ messages in thread
From: YueHaibing @ 2018-09-11 12:32 UTC (permalink / raw)
To: Maya Erez, Kalle Valo
Cc: YueHaibing, linux-wireless, wil6210, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/ath/wil6210/pm.c: In function 'wil_suspend_keep_radio_on':
drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
variable 'start' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/ath/wil6210/pm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/pm.c b/drivers/net/wireless/ath/wil6210/pm.c
index 3a41947..75fe932 100644
--- a/drivers/net/wireless/ath/wil6210/pm.c
+++ b/drivers/net/wireless/ath/wil6210/pm.c
@@ -190,7 +190,7 @@ static int wil_resume_keep_radio_on(struct wil6210_priv *wil)
static int wil_suspend_keep_radio_on(struct wil6210_priv *wil)
{
int rc = 0;
- unsigned long start, data_comp_to;
+ unsigned long data_comp_to;
wil_dbg_pm(wil, "suspend keep radio on\n");
@@ -232,7 +232,6 @@ static int wil_suspend_keep_radio_on(struct wil6210_priv *wil)
}
/* Wait for completion of the pending RX packets */
- start = jiffies;
data_comp_to = jiffies + msecs_to_jiffies(WIL_DATA_COMPLETION_TO_MS);
if (test_bit(wil_status_napi_en, wil->status)) {
while (!wil->txrx_ops.is_rx_idle(wil)) {
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] wil6210: remove set but not used variable 'start'
@ 2018-09-11 19:04 ` merez-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 13+ messages in thread
From: merez @ 2018-09-11 19:04 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, linux-wireless, wil6210, netdev, kernel-janitors,
linux-wireless-owner
On 2018-09-11 15:32, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/pm.c: In function
> 'wil_suspend_keep_radio_on':
> drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
> variable 'start' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wil6210: remove set but not used variable 'start'
@ 2018-09-11 19:04 ` merez-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 13+ messages in thread
From: merez @ 2018-09-11 19:04 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, linux-wireless, wil6210, netdev, kernel-janitors,
linux-wireless-owner
On 2018-09-11 15:32, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/pm.c: In function
> 'wil_suspend_keep_radio_on':
> drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
> variable 'start' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wil6210: remove set but not used variable 'start'
@ 2018-09-11 19:04 ` merez-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 13+ messages in thread
From: merez-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-09-11 19:04 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
wil6210-Rm6X0d1/PG5y9aJCnZT0Uw, netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA
On 2018-09-11 15:32, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/pm.c: In function
> 'wil_suspend_keep_radio_on':
> drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
> variable 'start' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Reviewed-by: Maya Erez <merez-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wil6210: remove set but not used variable 'start'
2018-09-11 12:32 ` YueHaibing
@ 2018-10-01 14:08 ` Kalle Valo
-1 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2018-10-01 14:08 UTC (permalink / raw)
To: YueHaibing
Cc: Maya Erez, YueHaibing, linux-wireless, wil6210, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/pm.c: In function 'wil_suspend_keep_radio_on':
> drivers/net/wireless/ath/wil6210/pm.c:193:16: warning:
> variable 'start' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
ec95e84c3955 wil6210: remove set but not used variable 'start'
--
https://patchwork.kernel.org/patch/10595613/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-12-20 7:45 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 7:59 [PATCH] wil6210: remove set but not used variable 'wdev' YueHaibing
2018-12-05 7:59 ` YueHaibing
2018-12-08 18:08 ` merez
2018-12-08 18:08 ` merez
2018-12-20 7:45 ` Kalle Valo
2018-12-20 7:45 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 12:32 [PATCH] wil6210: remove set but not used variable 'start' YueHaibing
2018-09-11 12:32 ` YueHaibing
2018-09-11 19:04 ` merez
2018-09-11 19:04 ` merez
2018-09-11 19:04 ` merez-sgV2jX0FEOL9JmXXK+q4OQ
2018-10-01 14:08 ` Kalle Valo
2018-10-01 14:08 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.