All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Dollinger Florian <dollinger.florian@gmx.de>, andrew.smirnov@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@kernel.org,
	linux-input@vger.kernel.org
Subject: XBox One S controller, Bluetooth support (was Re: hid: microsoft: Add rumble support for Xbox One S controller)
Date: Wed, 26 Sep 2018 18:09:33 +0200	[thread overview]
Message-ID: <932c109c28bbba7b833ff82cc68ee0ccc9a30374.camel@hadess.net> (raw)
In-Reply-To: <701e5f0fc3b24adf4b1ca4d817b3091fe73102ba.camel@hadess.net>

On Wed, 2018-09-26 at 15:45 +0200, Bastien Nocera wrote:
> Hey Florian,
> 
> On Wed, 2018-09-26 at 14:51 +0200, Dollinger Florian wrote:
> > From: Florian Dollinger <dollinger.florian@gmx.de>
> > 
> > Hi there! Why do you re-engineer the wheel? :) There is already a
> > fully functional and tested driver out there (
> > https://github.com/atar-axis/xpadneo). Would be much easier to help
> > me (the owner of xpadneo) to push it into the kernel.
> 
> Probably because he didn't know about it, and how would he? I also
> didn't know about it, because it didn't exist last I worked on those
> joypads.
> 
> I spent quite a bit of time trying to get the XBox One S controller
> working over Bluetooth, without success, and I see that you have a
> patch for that which you didn't send upstream either:
> https://github.com/atar-axis/xpadneo/blob/master/misc/kernel_patches/0001-fix_bluetooth_reconnect.patch

For this patch, after speaking with the Bluetooth maintainers, we would
need to:
- add relevant btmon outputs before and after the patch in the commit
message
- remove the mention of "many devices" (if you've seen other devices
with that problem in the wild, please mention them, otherwise mention
that it's for "XBox One S" controllers, and clones)
- run the patch against the "Profile Tuning Suite Tool" from the
Bluetooth SIG. This requires a Windows laptop, and a piece of hardware
from the Bluetooth SIG, see below.

The first 2 should be pretty easy to do, just send your patch using
"git send-email" to the linux-bluetooth list (CC:ed), with the data
attached.

For the qualification test, I was told Szymon has a test suite that he
could use to double-check the tests. If not, I should be able to buy
the adapter and run that test suite locally.

Cheers


  parent reply	other threads:[~2018-09-26 16:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  0:17 [PATCH] hid: microsoft: Add rumble support for Xbox One S controller Andrey Smirnov
2018-08-10  9:36 ` Benjamin Tissoires
2018-08-13 14:25   ` Andrey Smirnov
2018-08-10 11:38 ` Bastien Nocera
2018-08-13 14:37   ` Andrey Smirnov
2018-08-13 14:52     ` Bastien Nocera
2018-09-26 12:51 ` Dollinger Florian
2018-09-26 13:45   ` Bastien Nocera
2018-09-26 15:15     ` AW: " dollinger.florian
2018-09-26 15:15       ` dollinger.florian
2018-09-26 18:02       ` Bastien Nocera
2018-09-26 22:50         ` Florian Dollinger
2018-09-26 16:09     ` Bastien Nocera [this message]
2018-09-26 17:43     ` XBox One S controller, Bluetooth support (was Re: hid: microsoft: Add rumble support for Xbox One S controller) Bastien Nocera
2018-09-26 22:35       ` Florian Dollinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932c109c28bbba7b833ff82cc68ee0ccc9a30374.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=andrew.smirnov@gmail.com \
    --cc=dollinger.florian@gmx.de \
    --cc=linux-bluetooth@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.