* [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
@ 2021-09-03 7:51 ` Yang Li
0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-09-03 7:51 UTC (permalink / raw)
To: jdike; +Cc: richard, anton.ivanov, linux-um, linux-kernel, Yang Li
sizeof() when applied to a pointer typed expression gives the size of
the pointer.
Clean up coccicheck warning:
./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
pointer
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/um/drivers/virt-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index c080666..156af2f 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
buf = get_cpu_var(um_pci_msg_bufs);
data = buf->data;
- memset(data, 0xff, sizeof(data));
+ memset(data, 0xff, sizeof(*data));
switch (size) {
case 1:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
@ 2021-09-03 7:51 ` Yang Li
0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-09-03 7:51 UTC (permalink / raw)
To: jdike; +Cc: richard, anton.ivanov, linux-um, linux-kernel, Yang Li
sizeof() when applied to a pointer typed expression gives the size of
the pointer.
Clean up coccicheck warning:
./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
pointer
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/um/drivers/virt-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index c080666..156af2f 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
buf = get_cpu_var(um_pci_msg_bufs);
data = buf->data;
- memset(data, 0xff, sizeof(data));
+ memset(data, 0xff, sizeof(*data));
switch (size) {
case 1:
--
1.8.3.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
2021-09-03 7:51 ` Yang Li
@ 2021-09-03 8:20 ` Johannes Berg
-1 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2021-09-03 8:20 UTC (permalink / raw)
To: Yang Li, jdike; +Cc: richard, anton.ivanov, linux-um, linux-kernel
On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
>
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
>
> - memset(data, 0xff, sizeof(data));
> + memset(data, 0xff, sizeof(*data));
Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)
A Fixes: tag would be nice, but otherwise
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
@ 2021-09-03 8:20 ` Johannes Berg
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2021-09-03 8:20 UTC (permalink / raw)
To: Yang Li, jdike; +Cc: richard, anton.ivanov, linux-um, linux-kernel
On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
>
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
>
> - memset(data, 0xff, sizeof(data));
> + memset(data, 0xff, sizeof(*data));
Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)
A Fixes: tag would be nice, but otherwise
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-03 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 7:51 [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer Yang Li
2021-09-03 7:51 ` Yang Li
2021-09-03 8:20 ` Johannes Berg
2021-09-03 8:20 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.