* [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()
@ 2022-11-08 13:04 YueHaibing
2022-11-08 13:16 ` Mark Zhang
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2022-11-08 13:04 UTC (permalink / raw)
To: borisp, saeedm, leon, davem, edumazet, kuba, pabeni, lkayal, tariqt
Cc: netdev, linux-rdma, linux-kernel, YueHaibing
'accel_tcp' is allocated by kzalloc(), which should freed by kvfree().
Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
index 285d32d2fd08..7843c60d5b99 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
@@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
err_destroy_tables:
while (--i >= 0)
accel_fs_tcp_destroy_table(fs, i);
- kfree(accel_tcp);
+ kvfree(accel_tcp);
mlx5e_fs_set_accel_tcp(fs, NULL);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()
2022-11-08 13:04 [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create() YueHaibing
@ 2022-11-08 13:16 ` Mark Zhang
2022-11-08 13:52 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Mark Zhang @ 2022-11-08 13:16 UTC (permalink / raw)
To: YueHaibing, borisp, saeedm, leon, davem, edumazet, kuba, pabeni,
lkayal, tariqt
Cc: netdev, linux-rdma, linux-kernel
On 11/8/2022 9:04 PM, YueHaibing wrote:
> 'accel_tcp' is allocated by kzalloc(), which should freed by kvfree().
'accel_tcp' is allocated by kvzalloc()
>
> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> index 285d32d2fd08..7843c60d5b99 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
> err_destroy_tables:
> while (--i >= 0)
> accel_fs_tcp_destroy_table(fs, i);
> - kfree(accel_tcp);
> + kvfree(accel_tcp);
> mlx5e_fs_set_accel_tcp(fs, NULL);
> return err;
> }
Need to fix mlx5e_accel_fs_tcp_destroy() as well?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()
2022-11-08 13:16 ` Mark Zhang
@ 2022-11-08 13:52 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2022-11-08 13:52 UTC (permalink / raw)
To: Mark Zhang, borisp, saeedm, leon, davem, edumazet, kuba, pabeni,
lkayal, tariqt
Cc: netdev, linux-rdma, linux-kernel
On 2022/11/8 21:16, Mark Zhang wrote:
> On 11/8/2022 9:04 PM, YueHaibing wrote:
>> 'accel_tcp' is allocated by kzalloc(), which should freed by kvfree().
>
> 'accel_tcp' is allocated by kvzalloc()>
>>
>> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>> index 285d32d2fd08..7843c60d5b99 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>> @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
>> err_destroy_tables:
>> while (--i >= 0)
>> accel_fs_tcp_destroy_table(fs, i);
>> - kfree(accel_tcp);
>> + kvfree(accel_tcp);
>> mlx5e_fs_set_accel_tcp(fs, NULL);
>> return err;
>> }
>
> Need to fix mlx5e_accel_fs_tcp_destroy() as well?
Indeed, thanks for your review.
>
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-08 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 13:04 [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create() YueHaibing
2022-11-08 13:16 ` Mark Zhang
2022-11-08 13:52 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.