All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Daniel Baluta <daniel.baluta@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: sof: include types.h at header.h
Date: Tue, 15 Oct 2019 08:27:15 -0500	[thread overview]
Message-ID: <93911ba6-370e-4b93-d3c2-81081b1be0aa@linux.intel.com> (raw)
In-Reply-To: <CAEnQRZDtwFoXQ2H_j1v-95Pnh=QzZFX86jHk1RTq1oqSO+5jRw@mail.gmail.com>



On 10/15/19 2:07 AM, Daniel Baluta wrote:
> On Tue, Oct 15, 2019 at 9:57 AM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
>>
>>
>> Hi Daniel
>>
>>>> Content-Transfer-Encoding: 8bit
>>>>
>>>> Without <types.h> we will get these error
>>>>
>>>> linux/include/sound/sof/header.h:125:2: error: unknown type name ‘uint32_t’uint32_t size;
>>>> linux/include/sound/sof/header.h:136:2: error: unknown type name ‘uint32_t’uint32_t size;
>>>> linux/include/sound/sof/header.h:137:2: error: unknown type name ‘uint32_t’uint32_t cmd;
>>>> ...
>>>> linux/include/sound/sof/dai-imx.h:18:2: error: unknown type name ‘uint16_t’uint16_t reserved1;
>>>> linux/include/sound/sof/dai-imx.h:30:2: error: unknown type name ‘uint16_t’uint16_t tdm_slot_width;
>>>> linux/include/sound/sof/dai-imx.h:31:2: error: unknown type name ‘uint16_t’uint16_t reserved2;
>>>>
>>>
>>> I think your patch is OK, but you should update the commit message because
>>> Stephen Rothwell already fixed dai-imx.h compilation error  in linux-next.
>>
>> I see. Thanks
>>
>> But hmm... I couldn't find it at linux-next/master today...
>> Not yet merged ?
> 
> Yes, this is strange. I've sent an email to Stephen and
> also added you to Cc.
> 
> But, your patch is still valid because Stephen used +#include <linux/types.h>
> in dai-imx.h and you are now fixing the generic situation by including it in
> header.h.
> 
> Lets see if Stephen can clarify the situation. Perhaps we can drop his patch
> and only have yours.

this is a file shared with the firmware, we shouldn't have to add linux 
specific stuff in there.

Also I don't know how you get those errors, we've been using this file 
for some time, can you clarify how this error happens?

Thanks.

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-10-15 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  5:44 [alsa-devel] [PATCH] ASoC: sof: include types.h at header.h Kuninori Morimoto
2019-10-15  6:49 ` Daniel Baluta
2019-10-15  6:57   ` Kuninori Morimoto
2019-10-15  7:07     ` Daniel Baluta
2019-10-15 13:27       ` Pierre-Louis Bossart [this message]
2019-10-16  0:28         ` Kuninori Morimoto
2019-10-16 11:02           ` Daniel Baluta
2019-10-16 11:11           ` Daniel Baluta
2019-10-16 11:21             ` Mark Brown
2019-10-16 12:02               ` Daniel Baluta
2019-10-15  9:26 ` [alsa-devel] Applied "ASoC: sof: include types.h at header.h" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93911ba6-370e-4b93-d3c2-81081b1be0aa@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.