From: Daniel Baluta <daniel.baluta@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: sof: include types.h at header.h
Date: Tue, 15 Oct 2019 09:49:19 +0300 [thread overview]
Message-ID: <CAEnQRZAsZ=Q=tcqCzVp8bvj4Jme+YTH9GxmMoBgvOT+w6z8iiw@mail.gmail.com> (raw)
In-Reply-To: <87a7a24l7r.wl-kuninori.morimoto.gx@renesas.com>
Hello Morimoto-san,
On Tue, Oct 15, 2019 at 8:45 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Content-Transfer-Encoding: 8bit
>
> Without <types.h> we will get these error
>
> linux/include/sound/sof/header.h:125:2: error: unknown type name ‘uint32_t’uint32_t size;
> linux/include/sound/sof/header.h:136:2: error: unknown type name ‘uint32_t’uint32_t size;
> linux/include/sound/sof/header.h:137:2: error: unknown type name ‘uint32_t’uint32_t cmd;
> ...
> linux/include/sound/sof/dai-imx.h:18:2: error: unknown type name ‘uint16_t’uint16_t reserved1;
> linux/include/sound/sof/dai-imx.h:30:2: error: unknown type name ‘uint16_t’uint16_t tdm_slot_width;
> linux/include/sound/sof/dai-imx.h:31:2: error: unknown type name ‘uint16_t’uint16_t reserved2;
>
I think your patch is OK, but you should update the commit message because
Stephen Rothwell already fixed dai-imx.h compilation error in linux-next.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> include/sound/sof/header.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/sof/header.h b/include/sound/sof/header.h
> index 10f00c0..332143f 100644
> --- a/include/sound/sof/header.h
> +++ b/include/sound/sof/header.h
> @@ -9,6 +9,7 @@
> #ifndef __INCLUDE_SOUND_SOF_HEADER_H__
> #define __INCLUDE_SOUND_SOF_HEADER_H__
>
> +#include <linux/types.h>
> #include <uapi/sound/sof/abi.h>
>
> /** \addtogroup sof_uapi uAPI
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-15 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 5:44 [alsa-devel] [PATCH] ASoC: sof: include types.h at header.h Kuninori Morimoto
2019-10-15 6:49 ` Daniel Baluta [this message]
2019-10-15 6:57 ` Kuninori Morimoto
2019-10-15 7:07 ` Daniel Baluta
2019-10-15 13:27 ` Pierre-Louis Bossart
2019-10-16 0:28 ` Kuninori Morimoto
2019-10-16 11:02 ` Daniel Baluta
2019-10-16 11:11 ` Daniel Baluta
2019-10-16 11:21 ` Mark Brown
2019-10-16 12:02 ` Daniel Baluta
2019-10-15 9:26 ` [alsa-devel] Applied "ASoC: sof: include types.h at header.h" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEnQRZAsZ=Q=tcqCzVp8bvj4Jme+YTH9GxmMoBgvOT+w6z8iiw@mail.gmail.com' \
--to=daniel.baluta@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.