* [PATCH] Fix spurious config-mycompat.h warnings
@ 2018-05-18 19:24 Brad Love
2018-05-18 20:28 ` Jasmin J.
0 siblings, 1 reply; 2+ messages in thread
From: Brad Love @ 2018-05-18 19:24 UTC (permalink / raw)
To: linux-media, jasmin; +Cc: Brad Love
Apparently a zero byte file size leads to "could not open" warnings.
Adding a single comment to the file removes the warnings displayed
after compilation.
To prevent overwriting a user supplied config-mycompat.h the file
is only created if it does not already exist.
Also fix for possible spaces in the path.
Works without warning when using both the do-it-all build script
as well as manual operation via make targets.
Signed-off-by: Brad Love <brad@nextdimension.cc>
---
v4l/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v4l/Makefile b/v4l/Makefile
index 385fa83..a7c7b60 100644
--- a/v4l/Makefile
+++ b/v4l/Makefile
@@ -273,7 +273,7 @@ links::
@find ../linux/drivers/misc -name '*.[ch]' -type f -print0 | xargs -0n 255 ln -sf --target-directory=.
config-compat.h:: $(obj)/.version .myconfig scripts/make_config_compat.pl
- -touch $(obj)/config-mycompat.h
+ [ ! -f "$(obj)/config-mycompat.h" ] && echo "/* empty config-mycompat.h */" > "$(obj)/config-mycompat.h" || true
perl scripts/make_config_compat.pl $(SRCDIR) $(obj)/.myconfig $(obj)/config-compat.h
kernel-links makelinks::
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix spurious config-mycompat.h warnings
2018-05-18 19:24 [PATCH] Fix spurious config-mycompat.h warnings Brad Love
@ 2018-05-18 20:28 ` Jasmin J.
0 siblings, 0 replies; 2+ messages in thread
From: Jasmin J. @ 2018-05-18 20:28 UTC (permalink / raw)
To: Brad Love, linux-media, Hans Verkuil
Hi!
THX for the patch.
@Hans:
I applied the patch already, but I can't delete it from Patchwork.
Please remove it there.
BR,
Jasmin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-18 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18 19:24 [PATCH] Fix spurious config-mycompat.h warnings Brad Love
2018-05-18 20:28 ` Jasmin J.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.