Regression in v5.19-rc4 Sound Distortion

Regression in v5.19-rc4 Sound Distortion

[Daniel Exner]

Hi everyone,


(please keep me CC as I am currently not subscribed to LKML)


Since  v5.19-rc4 this box got some *loud* distorting sound on boot and 
after some time without any sound if something plays sound again from 
the integrated speakers in my monitor.


I managed to bisect this down to:

> commit 202773260023b56e868d09d13d3a417028f1ff5b
> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Date:   Fri Jun 17 15:24:02 2022 +0300
>
>    PM: hibernate: Use kernel_can_power_off()
>

Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.

Any ideas?


Greetings,

Daniel

Re: Regression in v5.19-rc4 Sound Distortion

[Dmitry Osipenko]

On 7/12/22 19:02, Daniel Exner wrote:
> Hi everyone,
> 
> 
> (please keep me CC as I am currently not subscribed to LKML)
> 
> 
> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
> after some time without any sound if something plays sound again from
> the integrated speakers in my monitor.
> 
> 
> I managed to bisect this down to:
> 
>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>
>>    PM: hibernate: Use kernel_can_power_off()
>>
> 
> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
> 
> Any ideas?

You're saying that the problem is on boot, but this patch is about
suspension to disk, which has nothing to do neither with the boot nor
with power-off. I'm afraid your bisection is incorrect.

-- 
Best regards,
Dmitry

Re: Regression in v5.19-rc4 Sound Distortion

[Thorsten Leemhuis]

On 12.07.22 18:35, Dmitry Osipenko wrote:
> On 7/12/22 19:02, Daniel Exner wrote:
>
>> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
>> after some time without any sound if something plays sound again from
>> the integrated speakers in my monitor.
>>
>> I managed to bisect this down to:
>>
>>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>>
>>>    PM: hibernate: Use kernel_can_power_off()
>>
>> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
> 
> You're saying that the problem is on boot, but this patch is about
> suspension to disk, which has nothing to do neither with the boot nor
> with power-off. I'm afraid your bisection is incorrect.

After quickly looking at the code this looks appropriate, but why does
reverting that commit help then? That's a bit odd. Daniel: are you maybe
using suspend-to-disk and forgot to mention it?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

Re: Regression in v5.19-rc4 Sound Distortion

[Daniel Exner]

horsten Leemhuis wrote:
> On 12.07.22 18:35, Dmitry Osipenko wrote:
>> On 7/12/22 19:02, Daniel Exner wrote:
>>
>>> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
>>> after some time without any sound if something plays sound again from
>>> the integrated speakers in my monitor.
>>>
>>> I managed to bisect this down to:
>>>
>>>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>>>
>>>>     PM: hibernate: Use kernel_can_power_off()
>>> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
>> You're saying that the problem is on boot, but this patch is about
>> suspension to disk, which has nothing to do neither with the boot nor
>> with power-off. I'm afraid your bisection is incorrect.
> After quickly looking at the code this looks appropriate, but why does
> reverting that commit help then? That's a bit odd. Daniel: are you maybe
> using suspend-to-disk and forgot to mention it?

No, I am not. But it seems Dmitry was right, at some point I bisected 
wrong by declaring some point good too early because I didn't have the 
bug on boot.

Perhaps I have two effects here: some bug resulting in sound distortion 
and some bug triggering that faster.


I will redo the bisection, but I fear it will take some time.


Greetings

Daniel

Re: Regression in v5.19-rc4 Sound Distortion

[Thorsten Leemhuis]

On 13.07.22 12:12, Daniel Exner wrote:
> horsten Leemhuis wrote:
>> On 12.07.22 18:35, Dmitry Osipenko wrote:
>>> On 7/12/22 19:02, Daniel Exner wrote:
>>>
>>>> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
>>>> after some time without any sound if something plays sound again from
>>>> the integrated speakers in my monitor.
>>>>
>>>> I managed to bisect this down to:
>>>>
>>>>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>>>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>>>>
>>>>>     PM: hibernate: Use kernel_can_power_off()
>>>> Reverting that commit on top of v5.19-rc6 does indeed fix the
>>>> problem here.
>>> You're saying that the problem is on boot, but this patch is about
>>> suspension to disk, which has nothing to do neither with the boot nor
>>> with power-off. I'm afraid your bisection is incorrect.
>> After quickly looking at the code this looks appropriate, but why does
>> reverting that commit help then? That's a bit odd. Daniel: are you maybe
>> using suspend-to-disk and forgot to mention it?
> 
> No, I am not. But it seems Dmitry was right, at some point I bisected
> wrong by declaring some point good too early because I didn't have the
> bug on boot.
> 
> Perhaps I have two effects here: some bug resulting in sound distortion
> and some bug triggering that faster.

Happens, thx for letting us know.

> I will redo the bisection, but I fear it will take some time.

BTW, what was the last Linux version that actually worked? I'm tracking
this regressions with regzbot (https://gitlab.com/knurd42/regzbot/ ) and
it would be good to have that on record at least roughly. From the text
it was not totally clear. I assume it was something like this:

#regzbot introduced: v5.19-rc1..v5.19-rc4

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

Re: Regression in v5.19-rc4 Sound Distortion

[Thorsten Leemhuis]

[TLDR: I'm adding this regression report to the list of tracked
regressions; all text from me you find below is based on a few templates
paragraphs you might have encountered already already in similar form.]

Hi, this is your Linux kernel regression tracker.

On 12.07.22 18:02, Daniel Exner wrote:
> 
> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
> after some time without any sound if something plays sound again from
> the integrated speakers in my monitor.
> 
> 
> I managed to bisect this down to:
> 
>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>
>>    PM: hibernate: Use kernel_can_power_off()
>>
> 
> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
> 
> Any ideas?

CCing the regression mailing list, as it should be in the loop for all
regressions, as explained here:
https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html

Thanks for the report. To be sure below issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression
tracking bot:

#regzbot ^introduced 202773260023b56e868d09d13d3a417028f1f
#regzbot title PM: hibernate: Sound Distortion on boot
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply -- ideally with also
telling regzbot about it, as explained here:
https://linux-regtracking.leemhuis.info/tracked-regression/

Reminder for developers: When fixing the issue, add 'Link:' tags
pointing to the report (the mail this one replies to), as explained for
in the Linux kernel's documentation; above webpage explains why this is
important for tracked regressions.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

Re: Regression in v5.19-rc4 Sound Distortion

[Daniel Exner]

Hi!

Something in between 6.0.0-rc3 and 6.0.0-rc4 fixed this issue for me.

Greetings
Daniel
> Hi everyone,
> 
> 
> (please keep me CC as I am currently not subscribed to LKML)
> 
> 
> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and 
> after some time without any sound if something plays sound again from 
> the integrated speakers in my monitor.
> 
> 
> I managed to bisect this down to:
> 
>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>
>>    PM: hibernate: Use kernel_can_power_off()
>>
> 
> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
> 
> Any ideas?
> 
> 
> Greetings,
> 
> Daniel
> 

Re: Regression in v5.19-rc4 Sound Distortion #forregzbot

[Thorsten Leemhuis]

TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

[trimmed the list of recipients]

On 16.09.22 22:34, Daniel Exner wrote:
>
> Something in between 6.0.0-rc3 and 6.0.0-rc4 fixed this issue for me.

Thx for letting us know!

#regzbot invalid: fixed Something in between 6.0.0-rc3 and 6.0.0-rc4
fixed this issue

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

>> Hi everyone,
>>
>>
>> (please keep me CC as I am currently not subscribed to LKML)
>>
>>
>> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
>> after some time without any sound if something plays sound again from
>> the integrated speakers in my monitor.
>>
>>
>> I managed to bisect this down to:
>>
>>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>>
>>>    PM: hibernate: Use kernel_can_power_off()
>>>
>>
>> Reverting that commit on top of v5.19-rc6 does indeed fix the problem
>> here.
>>
>> Any ideas?
>>
>>
>> Greetings,
>>
>> Daniel
>>
> 
>