All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Kossifidis <mick@ics.forth.gr>
To: Conor.Dooley@microchip.com
Cc: mick@ics.forth.gr, palmer@dabbelt.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	paul.walmsley@sifive.com, aou@eecs.berkeley.edu
Subject: Re: [PATCH] RISC-V-fixes: relocate DTB if it's outside memory region
Date: Sun, 27 Mar 2022 11:52:11 +0300	[thread overview]
Message-ID: <941622f4f76ecd5bc071e310479b3ad3@mailhost.ics.forth.gr> (raw)
In-Reply-To: <ebaa9b4e-9e37-e2f4-2bee-37d324e7302b@microchip.com>

Στις 2022-03-24 11:37, Conor.Dooley@microchip.com έγραψε:
> On 22/03/2022 13:28, Nick Kossifidis wrote:
>> In case the DTB provided by the bootloader/BootROM is before the 
>> kernel
>> image or outside /memory, we won't be able to access it through the
>> linear mapping, and get a segfault on setup_arch(). Currently OpenSBI
>> relocates DTB but that's not always the case (e.g. if FW_JUMP_FDT_ADDR
>> is not specified), and it's also not the most portable approach since
>> the default FW_JUMP_FDT_ADDR of the generic platform relocates the DTB
>> at a specific offset that may not be available. To avoid this 
>> situation
>> copy DTB so that it's visible through the linear mapping.
>> 
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> 
> Albeit in a backport, I tested this on a PolarFire SoC based board.
> So I guess, Tested-by: Conor Dooley <conor.dooley@microchip.com>
> 
> And a lot cleaner than using create_pgd_mapping in setup_vm_final to do 
> it :)
> 
> Thanks,
> Conor.
> 

Thanks !

WARNING: multiple messages have this Message-ID (diff)
From: Nick Kossifidis <mick@ics.forth.gr>
To: Conor.Dooley@microchip.com
Cc: mick@ics.forth.gr, palmer@dabbelt.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	paul.walmsley@sifive.com, aou@eecs.berkeley.edu
Subject: Re: [PATCH] RISC-V-fixes: relocate DTB if it's outside memory region
Date: Sun, 27 Mar 2022 11:52:11 +0300	[thread overview]
Message-ID: <941622f4f76ecd5bc071e310479b3ad3@mailhost.ics.forth.gr> (raw)
In-Reply-To: <ebaa9b4e-9e37-e2f4-2bee-37d324e7302b@microchip.com>

Στις 2022-03-24 11:37, Conor.Dooley@microchip.com έγραψε:
> On 22/03/2022 13:28, Nick Kossifidis wrote:
>> In case the DTB provided by the bootloader/BootROM is before the 
>> kernel
>> image or outside /memory, we won't be able to access it through the
>> linear mapping, and get a segfault on setup_arch(). Currently OpenSBI
>> relocates DTB but that's not always the case (e.g. if FW_JUMP_FDT_ADDR
>> is not specified), and it's also not the most portable approach since
>> the default FW_JUMP_FDT_ADDR of the generic platform relocates the DTB
>> at a specific offset that may not be available. To avoid this 
>> situation
>> copy DTB so that it's visible through the linear mapping.
>> 
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> 
> Albeit in a backport, I tested this on a PolarFire SoC based board.
> So I guess, Tested-by: Conor Dooley <conor.dooley@microchip.com>
> 
> And a lot cleaner than using create_pgd_mapping in setup_vm_final to do 
> it :)
> 
> Thanks,
> Conor.
> 

Thanks !

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-03-27  8:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 13:28 [PATCH] RISC-V-fixes: relocate DTB if it's outside memory region Nick Kossifidis
2022-03-22 13:28 ` Nick Kossifidis
2022-03-23 17:21 ` Conor Dooley
2022-03-23 17:21   ` Conor Dooley
2022-03-24  9:37 ` Conor.Dooley
2022-03-24  9:37   ` Conor.Dooley
2022-03-27  8:52   ` Nick Kossifidis [this message]
2022-03-27  8:52     ` Nick Kossifidis
2022-04-28 21:48   ` Palmer Dabbelt
2022-04-28 21:48     ` Palmer Dabbelt
2022-04-28 21:58     ` Conor Dooley
2022-04-28 21:58       ` Conor Dooley
2022-04-26  6:11 ` Nick Kossifidis
2022-04-26  6:11   ` Nick Kossifidis
2022-04-28 21:48   ` Palmer Dabbelt
2022-04-28 21:48     ` Palmer Dabbelt
2022-04-29 15:28     ` Palmer Dabbelt
2022-04-29 15:28       ` Palmer Dabbelt
2022-04-29 19:18       ` Nick Kossifidis
2022-04-29 19:18         ` Nick Kossifidis
2022-05-06 16:36         ` Palmer Dabbelt
2022-05-06 16:36           ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=941622f4f76ecd5bc071e310479b3ad3@mailhost.ics.forth.gr \
    --to=mick@ics.forth.gr \
    --cc=Conor.Dooley@microchip.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.