From: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Subject: Re: [PATCH 4/5] dt-bindings: pwm: sunxi: add new compatible strings Date: Thu, 8 Mar 2018 09:09:02 +0000 [thread overview] Message-ID: <9431a141-8b9c-9743-0907-8f0720df34a2@arm.com> (raw) In-Reply-To: <20180308020822.35utrgw3ksoldr24@rob-hp-laptop> Hi, On 08/03/18 02:08, Rob Herring wrote: > On Wed, Mar 07, 2018 at 02:07:18AM +0000, Andre Przywara wrote: >> The PWM controllers found in the Allwinner A64, H5 and H6 SoCs are fully >> compatible to the PWM controllers found in the A13 and H3. > > If fully compatible, then shouldn't there be a fallback to one of the > existing compatible strings? Yes, that was the idea. I was already wondering how we would differentiate that from "real" compatible strings, but couldn't find convincing examples. So should that read: - compatible: should at least contain be one of: - "allwinner,sun4i-a10-pwm" - "allwinner,sun5i-a10s-pwm" - "allwinner,sun5i-a13-pwm" - "allwinner,sun7i-a20-pwm" - "allwinner,sun8i-h3-pwm" May in addition contain one of: - "allwinner,sun50i-a64-pwm" - "allwinner,sun50i-h5-pwm" - "allwinner,sun50i-h6-pwm" And this would possibly need to be amended once we need to actually use one of those strings (to implement a quirk, for instance)? Or is there some other way of reserving those compatible strings, which are not expected to be matched in drivers directly? Cheers, Andre. >> Add new compatible strings for those SoCs to the binding document, so >> that they can be safely used, together with a fallback string >> (preferably "allwinner,sun5i-a13-pwm"). >> Add add the optionals "resets" property, needed by the H6. >> >> Signed-off-by: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org> >> --- >> Documentation/devicetree/bindings/pwm/pwm-sun4i.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> index 51ff54c8b8ef..b3a127a0e58c 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> +++ b/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> @@ -7,11 +7,17 @@ Required properties: >> - "allwinner,sun5i-a13-pwm" >> - "allwinner,sun7i-a20-pwm" >> - "allwinner,sun8i-h3-pwm" >> + - "allwinner,sun50i-a64-pwm" >> + - "allwinner,sun50i-h5-pwm" >> + - "allwinner,sun50i-h6-pwm" >> - reg: physical base address and length of the controller's registers >> - #pwm-cells: should be 3. See pwm.txt in this directory for a description of >> the cells format. >> - clocks: From common clock binding, handle to the parent clock. >> >> +Optional properties: >> + - resets: shall be the reset control phandle for the PWM block, if required. >> + >> Example: >> >> pwm: pwm@1c20e00 { >> -- >> 2.14.1 >>
WARNING: multiple messages have this Message-ID (diff)
From: andre.przywara@arm.com (Andre Przywara) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] dt-bindings: pwm: sunxi: add new compatible strings Date: Thu, 8 Mar 2018 09:09:02 +0000 [thread overview] Message-ID: <9431a141-8b9c-9743-0907-8f0720df34a2@arm.com> (raw) In-Reply-To: <20180308020822.35utrgw3ksoldr24@rob-hp-laptop> Hi, On 08/03/18 02:08, Rob Herring wrote: > On Wed, Mar 07, 2018 at 02:07:18AM +0000, Andre Przywara wrote: >> The PWM controllers found in the Allwinner A64, H5 and H6 SoCs are fully >> compatible to the PWM controllers found in the A13 and H3. > > If fully compatible, then shouldn't there be a fallback to one of the > existing compatible strings? Yes, that was the idea. I was already wondering how we would differentiate that from "real" compatible strings, but couldn't find convincing examples. So should that read: - compatible: should at least contain be one of: - "allwinner,sun4i-a10-pwm" - "allwinner,sun5i-a10s-pwm" - "allwinner,sun5i-a13-pwm" - "allwinner,sun7i-a20-pwm" - "allwinner,sun8i-h3-pwm" May in addition contain one of: - "allwinner,sun50i-a64-pwm" - "allwinner,sun50i-h5-pwm" - "allwinner,sun50i-h6-pwm" And this would possibly need to be amended once we need to actually use one of those strings (to implement a quirk, for instance)? Or is there some other way of reserving those compatible strings, which are not expected to be matched in drivers directly? Cheers, Andre. >> Add new compatible strings for those SoCs to the binding document, so >> that they can be safely used, together with a fallback string >> (preferably "allwinner,sun5i-a13-pwm"). >> Add add the optionals "resets" property, needed by the H6. >> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com> >> --- >> Documentation/devicetree/bindings/pwm/pwm-sun4i.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> index 51ff54c8b8ef..b3a127a0e58c 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> +++ b/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt >> @@ -7,11 +7,17 @@ Required properties: >> - "allwinner,sun5i-a13-pwm" >> - "allwinner,sun7i-a20-pwm" >> - "allwinner,sun8i-h3-pwm" >> + - "allwinner,sun50i-a64-pwm" >> + - "allwinner,sun50i-h5-pwm" >> + - "allwinner,sun50i-h6-pwm" >> - reg: physical base address and length of the controller's registers >> - #pwm-cells: should be 3. See pwm.txt in this directory for a description of >> the cells format. >> - clocks: From common clock binding, handle to the parent clock. >> >> +Optional properties: >> + - resets: shall be the reset control phandle for the PWM block, if required. >> + >> Example: >> >> pwm: pwm at 1c20e00 { >> -- >> 2.14.1 >>
next prev parent reply other threads:[~2018-03-08 9:09 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-07 2:07 [PATCH 0/5] drivers: pwm: sun4i: Improve support for A64 and H6 SoCs Andre Przywara 2018-03-07 2:07 ` Andre Przywara [not found] ` <20180307020719.6675-1-andre.przywara-5wv7dgnIgG8@public.gmane.org> 2018-03-07 2:07 ` [PATCH 1/5] pwm: sun4i: drop unused .has_rdy member Andre Przywara 2018-03-07 2:07 ` Andre Przywara 2018-03-07 7:40 ` Maxime Ripard 2018-03-07 7:40 ` Maxime Ripard 2018-03-07 2:07 ` [PATCH 2/5] pwm: sun4i: simplify controller mapping Andre Przywara 2018-03-07 2:07 ` Andre Przywara 2018-03-07 7:44 ` Maxime Ripard 2018-03-07 7:44 ` Maxime Ripard 2018-03-07 2:07 ` [PATCH 3/5] pwm: sun4i: Introduce (optional) reset support Andre Przywara 2018-03-07 2:07 ` Andre Przywara 2018-03-07 7:45 ` Maxime Ripard 2018-03-07 7:45 ` Maxime Ripard [not found] ` <20180307074516.dbak7ztkua4p7mr5-ZC1Zs529Oq4@public.gmane.org> 2018-03-13 14:05 ` Andre Przywara 2018-03-13 14:05 ` Andre Przywara 2018-03-13 15:32 ` Maxime Ripard 2018-03-13 15:32 ` Maxime Ripard 2018-03-07 2:07 ` [PATCH 4/5] dt-bindings: pwm: sunxi: add new compatible strings Andre Przywara 2018-03-07 2:07 ` Andre Przywara [not found] ` <20180307020719.6675-5-andre.przywara-5wv7dgnIgG8@public.gmane.org> 2018-03-08 2:08 ` Rob Herring 2018-03-08 2:08 ` Rob Herring 2018-03-08 9:09 ` Andre Przywara [this message] 2018-03-08 9:09 ` Andre Przywara [not found] ` <9431a141-8b9c-9743-0907-8f0720df34a2-5wv7dgnIgG8@public.gmane.org> 2018-03-08 14:37 ` Rob Herring 2018-03-08 14:37 ` Rob Herring [not found] ` <CAL_Jsq+e8uRm0gi1dn3Ln-b37SC9WGw5aWPaBKoRA2vi-==j6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-08 15:27 ` Andre Przywara 2018-03-08 15:27 ` [linux-sunxi] " Andre Przywara 2018-03-07 2:07 ` [PATCH 5/5] dts: sunxi: A64: Add PWM controllers Andre Przywara 2018-03-07 2:07 ` Andre Przywara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9431a141-8b9c-9743-0907-8f0720df34a2@arm.com \ --to=andre.przywara-5wv7dgnigg8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=wens-jdAy2FN1RRM@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.