* [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux
@ 2022-02-06 7:48 Sergey Kuzminov
2022-02-06 8:04 ` Giulio Benetti
2022-02-12 22:11 ` Arnout Vandecappelle
0 siblings, 2 replies; 5+ messages in thread
From: Sergey Kuzminov @ 2022-02-06 7:48 UTC (permalink / raw)
To: buildroot; +Cc: Sergey Kuzminov
Changes:
* Exclude FAT partition, it is no longer needed for U-Boot.
* Switch the rootfs partition from MBR to GPT for partition-uuid to work.
* Switch to extlinux, this is convenient for debugging.
* Create common scenarios for multiple boards to create an SD image: board/orangepi/common.
* Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem read-write during boot.
Signed-off-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
---
V1->V2:
* improved commit log
* removed commented line in extlinux.conf
* removed one boot option from extlinux.conf
V2->V3:
* improved commit log
* removed comment from board/orangepi/common/genimage.cfg
V3->V4:
* fixed Signed-off-by position
---
board/orangepi/common/extlinux.conf | 4 +++
board/orangepi/common/genimage.cfg | 20 +++++++++++++
board/orangepi/common/post-build.sh | 34 +++++++++++++++++++++
board/orangepi/orangepi-zero/boot.cmd | 9 ------
board/orangepi/orangepi-zero/genimage.cfg | 36 -----------------------
configs/orangepi_zero_defconfig | 11 ++++---
6 files changed, 63 insertions(+), 51 deletions(-)
create mode 100644 board/orangepi/common/extlinux.conf
create mode 100644 board/orangepi/common/genimage.cfg
create mode 100755 board/orangepi/common/post-build.sh
delete mode 100644 board/orangepi/orangepi-zero/boot.cmd
delete mode 100644 board/orangepi/orangepi-zero/genimage.cfg
diff --git a/board/orangepi/common/extlinux.conf b/board/orangepi/common/extlinux.conf
new file mode 100644
index 0000000000..12f496b1fa
--- /dev/null
+++ b/board/orangepi/common/extlinux.conf
@@ -0,0 +1,4 @@
+LABEL default
+ kernel /boot/%LINUXIMAGE%
+ devicetreedir /boot
+ append root=PARTUUID=%PARTUUID% rootwait console=${console} rootfstype=ext4 quiet panic=10
diff --git a/board/orangepi/common/genimage.cfg b/board/orangepi/common/genimage.cfg
new file mode 100644
index 0000000000..a61c4a039f
--- /dev/null
+++ b/board/orangepi/common/genimage.cfg
@@ -0,0 +1,20 @@
+image sdcard.img {
+ partition u-boot {
+ in-partition-table = false
+ image = "u-boot-sunxi-with-spl.bin"
+ offset = 8K
+ size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
+ }
+
+ hdimage {
+ partition-table-type = gpt
+ gpt-location = 1008K # 1MB - 16KB(GPT)
+ gpt-no-backup = true
+ }
+
+ partition rootfs {
+ offset = 1M
+ image = "rootfs.ext4"
+ partition-uuid = %PARTUUID%
+ }
+}
diff --git a/board/orangepi/common/post-build.sh b/board/orangepi/common/post-build.sh
new file mode 100755
index 0000000000..296f94b174
--- /dev/null
+++ b/board/orangepi/common/post-build.sh
@@ -0,0 +1,34 @@
+#!/bin/sh
+
+linux_image()
+{
+ if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
+ echo "uImage"
+ elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
+ echo "Image"
+ elif grep -Eq "^BR2_LINUX_KERNEL_IMAGEGZ=y$" ${BR2_CONFIG}; then
+ echo "Image.gz"
+ else
+ echo "zImage"
+ fi
+}
+
+generic_getty()
+{
+ if grep -Eq "^BR2_TARGET_GENERIC_GETTY=y$" ${BR2_CONFIG}; then
+ echo ""
+ else
+ echo "s/\s*console=\S*//"
+ fi
+}
+
+PARTUUID="$($HOST_DIR/bin/uuidgen)"
+
+install -d "$TARGET_DIR/boot/extlinux/"
+
+sed -e "$(generic_getty)" \
+ -e "s/%LINUXIMAGE%/$(linux_image)/g" \
+ -e "s/%PARTUUID%/$PARTUUID/g" \
+ "board/orangepi/common/extlinux.conf" > "$TARGET_DIR/boot/extlinux/extlinux.conf"
+
+sed "s/%PARTUUID%/$PARTUUID/g" "board/orangepi/common/genimage.cfg" > "$BINARIES_DIR/genimage.cfg"
diff --git a/board/orangepi/orangepi-zero/boot.cmd b/board/orangepi/orangepi-zero/boot.cmd
deleted file mode 100644
index d094a64fe5..0000000000
--- a/board/orangepi/orangepi-zero/boot.cmd
+++ /dev/null
@@ -1,9 +0,0 @@
-setenv fdt_high ffffffff
-
-part uuid mmc 0:2 uuid
-setenv bootargs console=ttyS0,115200 root=PARTUUID=${uuid} rootwait
-
-fatload mmc 0 $kernel_addr_r zImage
-fatload mmc 0 $fdt_addr_r sun8i-h2-plus-orangepi-zero.dtb
-
-bootz $kernel_addr_r - $fdt_addr_r
diff --git a/board/orangepi/orangepi-zero/genimage.cfg b/board/orangepi/orangepi-zero/genimage.cfg
deleted file mode 100644
index 32f5454ae6..0000000000
--- a/board/orangepi/orangepi-zero/genimage.cfg
+++ /dev/null
@@ -1,36 +0,0 @@
-# Minimal SD card image for the OrangePi Zero
-#
-image boot.vfat {
- vfat {
- files = {
- "zImage",
- "sun8i-h2-plus-orangepi-zero.dtb",
- "boot.scr"
- }
- }
- size = 10M
-}
-
-image sdcard.img {
- hdimage {
- }
-
- partition u-boot {
- in-partition-table = "no"
- image = "u-boot-sunxi-with-spl.bin"
- offset = 8K
- size = 1016K # 1MB - 8KB
- }
-
- partition boot {
- partition-type = 0xC
- bootable = "true"
- image = "boot.vfat"
- }
-
- partition rootfs {
- partition-type = 0x83
- image = "rootfs.ext4"
- size = 512M
- }
-}
diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig
index 5aaa1566c5..96f0c3f600 100644
--- a/configs/orangepi_zero_defconfig
+++ b/configs/orangepi_zero_defconfig
@@ -20,10 +20,13 @@ BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-h2-plus-orangepi-zero"
BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/orangepi/orangepi-zero/linux-extras.fragment"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
# Filesystem
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="63M"
+BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y
# BR2_TARGET_ROOTFS_TAR is not set
# Bootloader
@@ -39,16 +42,12 @@ BR2_TARGET_UBOOT_SPL=y
BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
# Required tools to create the SD image
-BR2_PACKAGE_HOST_UBOOT_TOOLS=y
-BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
-BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/orangepi/orangepi-zero/boot.cmd"
-BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
-BR2_PACKAGE_HOST_MTOOLS=y
# Image
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
-BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/orangepi/orangepi-zero/genimage.cfg"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
# Wireless driver and firmware
BR2_PACKAGE_XR819_XRADIO=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux
2022-02-06 7:48 [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux Sergey Kuzminov
@ 2022-02-06 8:04 ` Giulio Benetti
2022-02-12 22:11 ` Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2022-02-06 8:04 UTC (permalink / raw)
To: Sergey Kuzminov, buildroot
Hi Sergey,
On 06/02/22 08:48, Sergey Kuzminov wrote:
> Changes:
> * Exclude FAT partition, it is no longer needed for U-Boot.
> * Switch the rootfs partition from MBR to GPT for partition-uuid to work.
> * Switch to extlinux, this is convenient for debugging.
> * Create common scenarios for multiple boards to create an SD image: board/orangepi/common.
> * Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem read-write during boot.
>
> Signed-off-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
[Only built successfully]
Best regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> V1->V2:
> * improved commit log
> * removed commented line in extlinux.conf
> * removed one boot option from extlinux.conf
>
> V2->V3:
> * improved commit log
> * removed comment from board/orangepi/common/genimage.cfg
>
> V3->V4:
> * fixed Signed-off-by position
> ---
> board/orangepi/common/extlinux.conf | 4 +++
> board/orangepi/common/genimage.cfg | 20 +++++++++++++
> board/orangepi/common/post-build.sh | 34 +++++++++++++++++++++
> board/orangepi/orangepi-zero/boot.cmd | 9 ------
> board/orangepi/orangepi-zero/genimage.cfg | 36 -----------------------
> configs/orangepi_zero_defconfig | 11 ++++---
> 6 files changed, 63 insertions(+), 51 deletions(-)
> create mode 100644 board/orangepi/common/extlinux.conf
> create mode 100644 board/orangepi/common/genimage.cfg
> create mode 100755 board/orangepi/common/post-build.sh
> delete mode 100644 board/orangepi/orangepi-zero/boot.cmd
> delete mode 100644 board/orangepi/orangepi-zero/genimage.cfg
>
> diff --git a/board/orangepi/common/extlinux.conf b/board/orangepi/common/extlinux.conf
> new file mode 100644
> index 0000000000..12f496b1fa
> --- /dev/null
> +++ b/board/orangepi/common/extlinux.conf
> @@ -0,0 +1,4 @@
> +LABEL default
> + kernel /boot/%LINUXIMAGE%
> + devicetreedir /boot
> + append root=PARTUUID=%PARTUUID% rootwait console=${console} rootfstype=ext4 quiet panic=10
> diff --git a/board/orangepi/common/genimage.cfg b/board/orangepi/common/genimage.cfg
> new file mode 100644
> index 0000000000..a61c4a039f
> --- /dev/null
> +++ b/board/orangepi/common/genimage.cfg
> @@ -0,0 +1,20 @@
> +image sdcard.img {
> + partition u-boot {
> + in-partition-table = false
> + image = "u-boot-sunxi-with-spl.bin"
> + offset = 8K
> + size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
> + }
> +
> + hdimage {
> + partition-table-type = gpt
> + gpt-location = 1008K # 1MB - 16KB(GPT)
> + gpt-no-backup = true
> + }
> +
> + partition rootfs {
> + offset = 1M
> + image = "rootfs.ext4"
> + partition-uuid = %PARTUUID%
> + }
> +}
> diff --git a/board/orangepi/common/post-build.sh b/board/orangepi/common/post-build.sh
> new file mode 100755
> index 0000000000..296f94b174
> --- /dev/null
> +++ b/board/orangepi/common/post-build.sh
> @@ -0,0 +1,34 @@
> +#!/bin/sh
> +
> +linux_image()
> +{
> + if grep -Eq "^BR2_LINUX_KERNEL_UIMAGE=y$" ${BR2_CONFIG}; then
> + echo "uImage"
> + elif grep -Eq "^BR2_LINUX_KERNEL_IMAGE=y$" ${BR2_CONFIG}; then
> + echo "Image"
> + elif grep -Eq "^BR2_LINUX_KERNEL_IMAGEGZ=y$" ${BR2_CONFIG}; then
> + echo "Image.gz"
> + else
> + echo "zImage"
> + fi
> +}
> +
> +generic_getty()
> +{
> + if grep -Eq "^BR2_TARGET_GENERIC_GETTY=y$" ${BR2_CONFIG}; then
> + echo ""
> + else
> + echo "s/\s*console=\S*//"
> + fi
> +}
> +
> +PARTUUID="$($HOST_DIR/bin/uuidgen)"
> +
> +install -d "$TARGET_DIR/boot/extlinux/"
> +
> +sed -e "$(generic_getty)" \
> + -e "s/%LINUXIMAGE%/$(linux_image)/g" \
> + -e "s/%PARTUUID%/$PARTUUID/g" \
> + "board/orangepi/common/extlinux.conf" > "$TARGET_DIR/boot/extlinux/extlinux.conf"
> +
> +sed "s/%PARTUUID%/$PARTUUID/g" "board/orangepi/common/genimage.cfg" > "$BINARIES_DIR/genimage.cfg"
> diff --git a/board/orangepi/orangepi-zero/boot.cmd b/board/orangepi/orangepi-zero/boot.cmd
> deleted file mode 100644
> index d094a64fe5..0000000000
> --- a/board/orangepi/orangepi-zero/boot.cmd
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -setenv fdt_high ffffffff
> -
> -part uuid mmc 0:2 uuid
> -setenv bootargs console=ttyS0,115200 root=PARTUUID=${uuid} rootwait
> -
> -fatload mmc 0 $kernel_addr_r zImage
> -fatload mmc 0 $fdt_addr_r sun8i-h2-plus-orangepi-zero.dtb
> -
> -bootz $kernel_addr_r - $fdt_addr_r
> diff --git a/board/orangepi/orangepi-zero/genimage.cfg b/board/orangepi/orangepi-zero/genimage.cfg
> deleted file mode 100644
> index 32f5454ae6..0000000000
> --- a/board/orangepi/orangepi-zero/genimage.cfg
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -# Minimal SD card image for the OrangePi Zero
> -#
> -image boot.vfat {
> - vfat {
> - files = {
> - "zImage",
> - "sun8i-h2-plus-orangepi-zero.dtb",
> - "boot.scr"
> - }
> - }
> - size = 10M
> -}
> -
> -image sdcard.img {
> - hdimage {
> - }
> -
> - partition u-boot {
> - in-partition-table = "no"
> - image = "u-boot-sunxi-with-spl.bin"
> - offset = 8K
> - size = 1016K # 1MB - 8KB
> - }
> -
> - partition boot {
> - partition-type = 0xC
> - bootable = "true"
> - image = "boot.vfat"
> - }
> -
> - partition rootfs {
> - partition-type = 0x83
> - image = "rootfs.ext4"
> - size = 512M
> - }
> -}
> diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig
> index 5aaa1566c5..96f0c3f600 100644
> --- a/configs/orangepi_zero_defconfig
> +++ b/configs/orangepi_zero_defconfig
> @@ -20,10 +20,13 @@ BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-h2-plus-orangepi-zero"
> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/orangepi/orangepi-zero/linux-extras.fragment"
> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>
> # Filesystem
> BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="63M"
> +BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y
> # BR2_TARGET_ROOTFS_TAR is not set
>
> # Bootloader
> @@ -39,16 +42,12 @@ BR2_TARGET_UBOOT_SPL=y
> BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>
> # Required tools to create the SD image
> -BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/orangepi/orangepi-zero/boot.cmd"
> -BR2_PACKAGE_HOST_DOSFSTOOLS=y
> BR2_PACKAGE_HOST_GENIMAGE=y
> -BR2_PACKAGE_HOST_MTOOLS=y
>
> # Image
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
> BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/orangepi/orangepi-zero/genimage.cfg"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>
> # Wireless driver and firmware
> BR2_PACKAGE_XR819_XRADIO=y
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux
2022-02-06 7:48 [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux Sergey Kuzminov
2022-02-06 8:04 ` Giulio Benetti
@ 2022-02-12 22:11 ` Arnout Vandecappelle
2022-02-13 5:14 ` Sergey Kuzminov
1 sibling, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-02-12 22:11 UTC (permalink / raw)
To: Sergey Kuzminov, buildroot
On 06/02/2022 08:48, Sergey Kuzminov wrote:
> Changes:
> * Exclude FAT partition, it is no longer needed for U-Boot.
> * Switch the rootfs partition from MBR to GPT for partition-uuid to work.
> * Switch to extlinux, this is convenient for debugging.
> * Create common scenarios for multiple boards to create an SD image: board/orangepi/common.
> * Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem read-write during boot.
>
> Signed-off-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
> ---
> V1->V2:
> * improved commit log
> * removed commented line in extlinux.conf
> * removed one boot option from extlinux.conf
>
> V2->V3:
> * improved commit log
> * removed comment from board/orangepi/common/genimage.cfg
>
> V3->V4:
> * fixed Signed-off-by position
I think I'm going to use this commit message as an example for the
documentation... Well, if I ever get around to it :-)
[snip]
> diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig
> index 5aaa1566c5..96f0c3f600 100644
> --- a/configs/orangepi_zero_defconfig
> +++ b/configs/orangepi_zero_defconfig
> @@ -20,10 +20,13 @@ BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-h2-plus-orangepi-zero"
> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/orangepi/orangepi-zero/linux-extras.fragment"
> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>
> # Filesystem
> BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="63M"
Why? Increase from 60M to 63M seems a bit odd...
I removed this.
> +BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y
We don't do this for any other defconfig. I removed this.
Applied to master, thanks.
Regards,
Arnout
> # BR2_TARGET_ROOTFS_TAR is not set
>
> # Bootloader
> @@ -39,16 +42,12 @@ BR2_TARGET_UBOOT_SPL=y
> BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>
> # Required tools to create the SD image
> -BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/orangepi/orangepi-zero/boot.cmd"
> -BR2_PACKAGE_HOST_DOSFSTOOLS=y
> BR2_PACKAGE_HOST_GENIMAGE=y
> -BR2_PACKAGE_HOST_MTOOLS=y
>
> # Image
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
> BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/orangepi/orangepi-zero/genimage.cfg"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>
> # Wireless driver and firmware
> BR2_PACKAGE_XR819_XRADIO=y
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux
2022-02-12 22:11 ` Arnout Vandecappelle
@ 2022-02-13 5:14 ` Sergey Kuzminov
2022-02-13 10:43 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Sergey Kuzminov @ 2022-02-13 5:14 UTC (permalink / raw)
To: Arnout Vandecappelle, buildroot
Hi Arnout,
13.02.2022 01:11, Arnout Vandecappelle:
>
>
> On 06/02/2022 08:48, Sergey Kuzminov wrote:
>> Changes:
>> * Exclude FAT partition, it is no longer needed for U-Boot.
>> * Switch the rootfs partition from MBR to GPT for partition-uuid to work.
>> * Switch to extlinux, this is convenient for debugging.
>> * Create common scenarios for multiple boards to create an SD image:
>> board/orangepi/common.
>> * Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem
>> read-write during boot.
>>
>> Signed-off-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
>> ---
>> V1->V2:
>> * improved commit log
>> * removed commented line in extlinux.conf
>> * removed one boot option from extlinux.conf
>>
>> V2->V3:
>> * improved commit log
>> * removed comment from board/orangepi/common/genimage.cfg
>>
>> V3->V4:
>> * fixed Signed-off-by position
>
> I think I'm going to use this commit message as an example for the
> documentation... Well, if I ever get around to it :-)
Giulio Benetti helped me. Thanks Giulio.
> [snip]
>> diff --git a/configs/orangepi_zero_defconfig
>> b/configs/orangepi_zero_defconfig
>> index 5aaa1566c5..96f0c3f600 100644
>> --- a/configs/orangepi_zero_defconfig
>> +++ b/configs/orangepi_zero_defconfig
>> @@ -20,10 +20,13 @@ BR2_LINUX_KERNEL_DTS_SUPPORT=y
>> BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-h2-plus-orangepi-zero"
>>
>> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/orangepi/orangepi-zero/linux-extras.fragment"
>>
>> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>> # Filesystem
>> BR2_TARGET_ROOTFS_EXT2=y
>> BR2_TARGET_ROOTFS_EXT2_4=y
>> +BR2_TARGET_ROOTFS_EXT2_SIZE="63M"
>
> Why? Increase from 60M to 63M seems a bit odd...
>
> I removed this.
Initially, 512 MB was in the genimage.cfg configuration. Beautifully
obtained 1 MB (u-boot) + 63 MB (rootfs) = 64 MB (SD Card Image) :)
>> +BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y
>
> We don't do this for any other defconfig. I removed this.
>
>
> Applied to master, thanks.
>
> Regards,
> Arnout
>
>
>> # BR2_TARGET_ROOTFS_TAR is not set
>> # Bootloader
>> @@ -39,16 +42,12 @@ BR2_TARGET_UBOOT_SPL=y
>> BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>> # Required tools to create the SD image
>> -BR2_PACKAGE_HOST_UBOOT_TOOLS=y
>> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
>> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/orangepi/orangepi-zero/boot.cmd"
>>
>> -BR2_PACKAGE_HOST_DOSFSTOOLS=y
>> BR2_PACKAGE_HOST_GENIMAGE=y
>> -BR2_PACKAGE_HOST_MTOOLS=y
>> # Image
>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
>> BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c
>> board/orangepi/orangepi-zero/genimage.cfg"
>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>> # Wireless driver and firmware
>> BR2_PACKAGE_XR819_XRADIO=y
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux
2022-02-13 5:14 ` Sergey Kuzminov
@ 2022-02-13 10:43 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-02-13 10:43 UTC (permalink / raw)
To: Sergey Kuzminov, buildroot
On 13/02/2022 06:14, Sergey Kuzminov wrote:
> Hi Arnout,
>
> 13.02.2022 01:11, Arnout Vandecappelle:
>>
>>
>> On 06/02/2022 08:48, Sergey Kuzminov wrote:
>>> Changes:
>>> * Exclude FAT partition, it is no longer needed for U-Boot.
>>> * Switch the rootfs partition from MBR to GPT for partition-uuid to work.
>>> * Switch to extlinux, this is convenient for debugging.
>>> * Create common scenarios for multiple boards to create an SD image:
>>> board/orangepi/common.
>>> * Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem
>>> read-write during boot.
>>>
>>> Signed-off-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
>>> ---
>>> V1->V2:
>>> * improved commit log
>>> * removed commented line in extlinux.conf
>>> * removed one boot option from extlinux.conf
>>>
>>> V2->V3:
>>> * improved commit log
>>> * removed comment from board/orangepi/common/genimage.cfg
>>>
>>> V3->V4:
>>> * fixed Signed-off-by position
>>
>> I think I'm going to use this commit message as an example for the
>> documentation... Well, if I ever get around to it :-)
>
> Giulio Benetti helped me. Thanks Giulio.
>
>> [snip]
>>> diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig
>>> index 5aaa1566c5..96f0c3f600 100644
>>> --- a/configs/orangepi_zero_defconfig
>>> +++ b/configs/orangepi_zero_defconfig
>>> @@ -20,10 +20,13 @@ BR2_LINUX_KERNEL_DTS_SUPPORT=y
>>> BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-h2-plus-orangepi-zero"
>>> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/orangepi/orangepi-zero/linux-extras.fragment"
>>>
>>> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>>> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>>> # Filesystem
>>> BR2_TARGET_ROOTFS_EXT2=y
>>> BR2_TARGET_ROOTFS_EXT2_4=y
>>> +BR2_TARGET_ROOTFS_EXT2_SIZE="63M"
>>
>> Why? Increase from 60M to 63M seems a bit odd...
>>
>> I removed this.
>
> Initially, 512 MB was in the genimage.cfg configuration. Beautifully obtained 1
> MB (u-boot) + 63 MB (rootfs) = 64 MB (SD Card Image) :)
An SD card labelled as 64MB would typically have about 60-62MB of actual
space, the rest being used for spares for bad blocks. That's why we use 60M as
the default.
Regards,
Arnout
>
>>> +BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y
>>
>> We don't do this for any other defconfig. I removed this.
>>
>>
>> Applied to master, thanks.
>>
>> Regards,
>> Arnout
>>
>>
>>> # BR2_TARGET_ROOTFS_TAR is not set
>>> # Bootloader
>>> @@ -39,16 +42,12 @@ BR2_TARGET_UBOOT_SPL=y
>>> BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>>> # Required tools to create the SD image
>>> -BR2_PACKAGE_HOST_UBOOT_TOOLS=y
>>> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
>>> -BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/orangepi/orangepi-zero/boot.cmd"
>>>
>>> -BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>> BR2_PACKAGE_HOST_GENIMAGE=y
>>> -BR2_PACKAGE_HOST_MTOOLS=y
>>> # Image
>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
>>> BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>>> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/orangepi/orangepi-zero/genimage.cfg"
>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
>>> # Wireless driver and firmware
>>> BR2_PACKAGE_XR819_XRADIO=y
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-13 10:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06 7:48 [Buildroot] [PATCH v4] configs/orangepi_zero_defconfig: switch to extlinux Sergey Kuzminov
2022-02-06 8:04 ` Giulio Benetti
2022-02-12 22:11 ` Arnout Vandecappelle
2022-02-13 5:14 ` Sergey Kuzminov
2022-02-13 10:43 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.